Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A message can be published idempotent #1012

Closed
saig0 opened this issue Jul 4, 2018 · 1 comment · Fixed by #1055
Closed

A message can be published idempotent #1012

saig0 opened this issue Jul 4, 2018 · 1 comment · Fixed by #1055
Assignees
@saig0
Milestone
Message Correlation

Comments

@saig0
Copy link
Member

saig0 commented Jul 4, 2018

AT:

  • a message can be published with an id to ensure that the message is published only once (idempotent)
  • when a message is published with the same id, name and correlation-key then it is rejected

Context:

  • is some case it is important that a message is published/correlated only once (e.g. for a message start event)
  • in order to make the publication easier (i.e. no need to store which message is successfully published), Zeebe take care of this
  • a generic publisher for Kafka can use the Kafka's message position as id
@saig0 saig0 added this to the Message Correlation milestone Jul 4, 2018
@saig0 saig0 mentioned this issue Jul 4, 2018
Closed
saig0 added a commit that referenced this issue Jul 12, 2018
@saig0
feat(broker): a message can be published idempotent
76ddabe 
* new field 'messageId' in message record
* reject message if another message with the same id, name and
correlation-key is already published

related to #1012
@ghost ghost assigned saig0 Jul 12, 2018
@ghost ghost added in progress and removed ready labels Jul 12, 2018
This was referenced Jul 13, 2018
Merged
Merged
@ghost ghost added needs review and removed in progress labels Jul 16, 2018
bors bot added a commit that referenced this issue Jul 16, 2018
@bors @saig0
Merge #1055
8d59363 
1055: feat(broker): a message can be published idempotent r=saig0 a=saig0

* new field 'messageId' in message record
* reject message if another message with the same id, name and
correlation-key is already published

closes #1012 


Co-authored-by: Philipp Ossler <philipp.ossler@gmail.com>
@bors bors bot closed this as completed in #1055 Jul 16, 2018
@ghost ghost removed the needs review label Jul 16, 2018
@berndruecker
Copy link
Member

Please make sure that this is also considered when starting new workflow instances via mesage: #1022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@saig0 saig0

Labels
None yet
Projects
None yet
Milestone
Message Correlation
Development

Successfully merging a pull request may close this issue.

feat(broker): a message can be published idempotent camunda/camunda
2 participants
@berndruecker @saig0