Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose Webpack resolve alias and modules properties #460

Closed
wants to merge 2 commits into from
Closed

Expose Webpack resolve alias and modules properties #460

wants to merge 2 commits into from

Conversation

shcca
Copy link

@shcca shcca commented Jul 15, 2019

This is in regard to #459

@shcca shcca requested review from guybedford and styfle as code owners July 15, 2019 02:32
@codecov-io
Copy link

Codecov Report

Merging #460 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #460   +/-   ##
=======================================
  Coverage   74.68%   74.68%           
=======================================
  Files          13       13           
  Lines         395      395           
=======================================
  Hits          295      295           
  Misses        100      100
Impacted Files Coverage Δ
src/index.js 83.53% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e246437...ed070f7. Read the comment docs.

// https://webpack.js.org/configuration/resolve/#resolvealias
resolveAlias: {}, // default
// https://webpack.js.org/configuration/resolve/#resolvemodules
resolveModules: [] // default
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we want to avoid leaking webpack details through to the ncc API in case we need to swap webpack for rollup or some other alternative.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other tools likely have similar options; Rollup for sure does.

Changing build tool would definitely be a breaking change, if it ever happens, so I don't particularly see the issue with supporting a particular flavor of options.

This option would reduce my bundle by dropping 2 unused heavy sub-dependencies. I just realized that my built file is 1.2MB due a couple of dependencies I don't really use.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants