Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update postcss.config.js #11366

Merged
merged 4 commits into from
Apr 6, 2020
Merged

Update postcss.config.js #11366

merged 4 commits into from
Apr 6, 2020

Conversation

paul-vd
Copy link
Contributor

@paul-vd paul-vd commented Mar 26, 2020

Return empty array if the condition is not met to avoid a null/undefined PostCSS plugin.

@paul-vd
Update postcss.config.js
1a8decb 
Return empty array if the condition is not met to avoid a null/undefined PostCSS plugin.
@paul-vd paul-vd requested review from lfades and Timer as code owners March 26, 2020 10:59
@ijjk
Copy link
Member

ijjk commented Mar 26, 2020

Stats from current PR

Default Server Mode
General
zeit/next.js canary PaulPCIO/next.js patch-4 Change
buildDuration 10.5s 10.6s ⚠️ +103ms
nodeModulesSize 53 MB 53 MB ✓
Client Bundles (main, webpack, commons)
zeit/next.js canary PaulPCIO/next.js patch-4 Change
main-HASH.js gzip 6.24 kB 6.24 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..c6c1.js gzip 10.1 kB 10.1 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 56.2 kB 56.2 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary PaulPCIO/next.js patch-4 Change
main-HASH.module.js gzip 4.78 kB 4.78 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.71 kB 6.71 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 51.4 kB 51.4 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary PaulPCIO/next.js patch-4 Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
zeit/next.js canary PaulPCIO/next.js patch-4 Change
_app.js gzip 1.24 kB 1.24 kB ✓
_error.js gzip 3.15 kB 3.15 kB ✓
hooks.js gzip 664 B 664 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.03 kB 2.03 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 7.86 kB 7.86 kB ✓
Client Pages Modern
zeit/next.js canary PaulPCIO/next.js patch-4 Change
_app.module.js gzip 594 B 594 B ✓
_error.module.js gzip 2.08 kB 2.08 kB ✓
hooks.module.js gzip 370 B 370 B ✓
index.module.js gzip 212 B 212 B ✓
link.module.js gzip 1.48 kB 1.48 kB ✓
routerDirect..dule.js gzip 271 B 271 B ✓
withRouter.m..dule.js gzip 270 B 270 B ✓
Overall change 5.28 kB 5.28 kB ✓
Client Build Manifests
zeit/next.js canary PaulPCIO/next.js patch-4 Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Rendered Page Sizes
zeit/next.js canary PaulPCIO/next.js patch-4 Change
index.html gzip 918 B 918 B ✓
link.html gzip 926 B 926 B ✓
withRouter.html gzip 914 B 914 B ✓
Overall change 2.76 kB 2.76 kB ✓
Serverless Mode (Decrease detected ✓)
General
zeit/next.js canary PaulPCIO/next.js patch-4 Change
buildDuration 11.2s 11.6s ⚠️ +360ms
nodeModulesSize 53 MB 53 MB ✓
Client Bundles (main, webpack, commons)
zeit/next.js canary PaulPCIO/next.js patch-4 Change
main-HASH.js gzip 6.24 kB 6.24 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..c6c1.js gzip 10.1 kB 10.1 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 56.2 kB 56.2 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary PaulPCIO/next.js patch-4 Change
main-HASH.module.js gzip 4.78 kB 4.78 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.71 kB 6.71 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 51.4 kB 51.4 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary PaulPCIO/next.js patch-4 Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
zeit/next.js canary PaulPCIO/next.js patch-4 Change
_app.js gzip 1.24 kB 1.24 kB ✓
_error.js gzip 3.15 kB 3.15 kB ✓
hooks.js gzip 664 B 664 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.03 kB 2.03 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 7.86 kB 7.86 kB ✓
Client Pages Modern
zeit/next.js canary PaulPCIO/next.js patch-4 Change
_app.module.js gzip 594 B 594 B ✓
_error.module.js gzip 2.08 kB 2.08 kB ✓
hooks.module.js gzip 370 B 370 B ✓
index.module.js gzip 212 B 212 B ✓
link.module.js gzip 1.48 kB 1.48 kB ✓
routerDirect..dule.js gzip 271 B 271 B ✓
withRouter.m..dule.js gzip 270 B 270 B ✓
Overall change 5.28 kB 5.28 kB ✓
Client Build Manifests
zeit/next.js canary PaulPCIO/next.js patch-4 Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Serverless bundles Overall decrease ✓
zeit/next.js canary PaulPCIO/next.js patch-4 Change
_error.js gzip 293 kB 293 kB -457 B
404.html gzip 1.32 kB 1.32 kB ✓
hooks.html gzip 957 B 957 B ✓
index.js gzip 294 kB 294 kB ⚠️ +286 B
link.js gzip 302 kB 301 kB -119 B
routerDirect.js gzip 300 kB 300 kB ⚠️ +14 B
withRouter.js gzip 300 kB 300 kB -101 B
Overall change 1.49 MB 1.49 MB -377 B

paul-vd added 2 commits March 27, 2020 16:49
@paul-vd
Update postcss.config.js
76afb95 
Fix array spread
@paul-vd
Update postcss.config.js
6035f32 
remove extra operator
paul-vd
paul-vd commented Mar 27, 2020
View reviewed changes
Copy link
Contributor Author

@paul-vd paul-vd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes made to the array spread

examples/with-tailwindcss/postcss.config.js Outdated Show resolved Hide resolved
@ijjk
Copy link
Member

ijjk commented Mar 27, 2020

Stats from current PR

Default Server Mode
General
zeit/next.js canary PaulPCIO/next.js patch-4 Change
buildDuration 11.9s 11.6s -294ms
nodeModulesSize 52.8 MB 52.8 MB ✓
Client Bundles (main, webpack, commons)
zeit/next.js canary PaulPCIO/next.js patch-4 Change
main-HASH.js gzip 6.24 kB 6.24 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..c6c1.js gzip 10.1 kB 10.1 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 56.2 kB 56.2 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary PaulPCIO/next.js patch-4 Change
main-HASH.module.js gzip 4.77 kB 4.77 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.71 kB 6.71 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 51.4 kB 51.4 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary PaulPCIO/next.js patch-4 Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
zeit/next.js canary PaulPCIO/next.js patch-4 Change
_app.js gzip 1.24 kB 1.24 kB ✓
_error.js gzip 3.15 kB 3.15 kB ✓
hooks.js gzip 664 B 664 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.03 kB 2.03 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 7.86 kB 7.86 kB ✓
Client Pages Modern
zeit/next.js canary PaulPCIO/next.js patch-4 Change
_app.module.js gzip 594 B 594 B ✓
_error.module.js gzip 2.08 kB 2.08 kB ✓
hooks.module.js gzip 370 B 370 B ✓
index.module.js gzip 212 B 212 B ✓
link.module.js gzip 1.48 kB 1.48 kB ✓
routerDirect..dule.js gzip 271 B 271 B ✓
withRouter.m..dule.js gzip 270 B 270 B ✓
Overall change 5.28 kB 5.28 kB ✓
Client Build Manifests
zeit/next.js canary PaulPCIO/next.js patch-4 Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Rendered Page Sizes
zeit/next.js canary PaulPCIO/next.js patch-4 Change
index.html gzip 917 B 917 B ✓
link.html gzip 925 B 925 B ✓
withRouter.html gzip 915 B 915 B ✓
Overall change 2.76 kB 2.76 kB ✓
Serverless Mode (Increase detected ⚠️)
General
zeit/next.js canary PaulPCIO/next.js patch-4 Change
buildDuration 12.7s 12.4s -312ms
nodeModulesSize 52.8 MB 52.8 MB ✓
Client Bundles (main, webpack, commons)
zeit/next.js canary PaulPCIO/next.js patch-4 Change
main-HASH.js gzip 6.24 kB 6.24 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..c6c1.js gzip 10.1 kB 10.1 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 56.2 kB 56.2 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary PaulPCIO/next.js patch-4 Change
main-HASH.module.js gzip 4.77 kB 4.77 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.71 kB 6.71 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 51.4 kB 51.4 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary PaulPCIO/next.js patch-4 Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
zeit/next.js canary PaulPCIO/next.js patch-4 Change
_app.js gzip 1.24 kB 1.24 kB ✓
_error.js gzip 3.15 kB 3.15 kB ✓
hooks.js gzip 664 B 664 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.03 kB 2.03 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 7.86 kB 7.86 kB ✓
Client Pages Modern
zeit/next.js canary PaulPCIO/next.js patch-4 Change
_app.module.js gzip 594 B 594 B ✓
_error.module.js gzip 2.08 kB 2.08 kB ✓
hooks.module.js gzip 370 B 370 B ✓
index.module.js gzip 212 B 212 B ✓
link.module.js gzip 1.48 kB 1.48 kB ✓
routerDirect..dule.js gzip 271 B 271 B ✓
withRouter.m..dule.js gzip 270 B 270 B ✓
Overall change 5.28 kB 5.28 kB ✓
Client Build Manifests
zeit/next.js canary PaulPCIO/next.js patch-4 Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Serverless bundles Overall increase ⚠️
zeit/next.js canary PaulPCIO/next.js patch-4 Change
_error.js gzip 294 kB 294 kB -426 B
404.html gzip 1.32 kB 1.32 kB ✓
hooks.html gzip 958 B 958 B ✓
index.js gzip 294 kB 294 kB -398 B
link.js gzip 301 kB 302 kB ⚠️ +912 B
routerDirect.js gzip 300 kB 300 kB ⚠️ +113 B
withRouter.js gzip 300 kB 300 kB -77 B
Overall change 1.49 MB 1.49 MB ⚠️ +124 B

@ijjk
Copy link
Member

ijjk commented Mar 27, 2020

Stats from current PR

Default Server Mode
General
zeit/next.js canary PaulPCIO/next.js patch-4 Change
buildDuration 11.4s 11.4s ⚠️ +65ms
nodeModulesSize 52.8 MB 52.8 MB ✓
Client Bundles (main, webpack, commons)
zeit/next.js canary PaulPCIO/next.js patch-4 Change
main-HASH.js gzip 6.24 kB 6.24 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..c6c1.js gzip 10.1 kB 10.1 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 56.2 kB 56.2 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary PaulPCIO/next.js patch-4 Change
main-HASH.module.js gzip 4.77 kB 4.77 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.71 kB 6.71 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 51.4 kB 51.4 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary PaulPCIO/next.js patch-4 Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
zeit/next.js canary PaulPCIO/next.js patch-4 Change
_app.js gzip 1.24 kB 1.24 kB ✓
_error.js gzip 3.15 kB 3.15 kB ✓
hooks.js gzip 664 B 664 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.03 kB 2.03 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 7.86 kB 7.86 kB ✓
Client Pages Modern
zeit/next.js canary PaulPCIO/next.js patch-4 Change
_app.module.js gzip 594 B 594 B ✓
_error.module.js gzip 2.08 kB 2.08 kB ✓
hooks.module.js gzip 370 B 370 B ✓
index.module.js gzip 212 B 212 B ✓
link.module.js gzip 1.48 kB 1.48 kB ✓
routerDirect..dule.js gzip 271 B 271 B ✓
withRouter.m..dule.js gzip 270 B 270 B ✓
Overall change 5.28 kB 5.28 kB ✓
Client Build Manifests
zeit/next.js canary PaulPCIO/next.js patch-4 Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Rendered Page Sizes
zeit/next.js canary PaulPCIO/next.js patch-4 Change
index.html gzip 917 B 917 B ✓
link.html gzip 925 B 925 B ✓
withRouter.html gzip 915 B 915 B ✓
Overall change 2.76 kB 2.76 kB ✓
Serverless Mode (Increase detected ⚠️)
General
zeit/next.js canary PaulPCIO/next.js patch-4 Change
buildDuration 12.5s 11.8s -628ms
nodeModulesSize 52.8 MB 52.8 MB ✓
Client Bundles (main, webpack, commons)
zeit/next.js canary PaulPCIO/next.js patch-4 Change
main-HASH.js gzip 6.24 kB 6.24 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..c6c1.js gzip 10.1 kB 10.1 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 56.2 kB 56.2 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary PaulPCIO/next.js patch-4 Change
main-HASH.module.js gzip 4.77 kB 4.77 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.71 kB 6.71 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 51.4 kB 51.4 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary PaulPCIO/next.js patch-4 Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
zeit/next.js canary PaulPCIO/next.js patch-4 Change
_app.js gzip 1.24 kB 1.24 kB ✓
_error.js gzip 3.15 kB 3.15 kB ✓
hooks.js gzip 664 B 664 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.03 kB 2.03 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 7.86 kB 7.86 kB ✓
Client Pages Modern
zeit/next.js canary PaulPCIO/next.js patch-4 Change
_app.module.js gzip 594 B 594 B ✓
_error.module.js gzip 2.08 kB 2.08 kB ✓
hooks.module.js gzip 370 B 370 B ✓
index.module.js gzip 212 B 212 B ✓
link.module.js gzip 1.48 kB 1.48 kB ✓
routerDirect..dule.js gzip 271 B 271 B ✓
withRouter.m..dule.js gzip 270 B 270 B ✓
Overall change 5.28 kB 5.28 kB ✓
Client Build Manifests
zeit/next.js canary PaulPCIO/next.js patch-4 Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Serverless bundles Overall increase ⚠️
zeit/next.js canary PaulPCIO/next.js patch-4 Change
_error.js gzip 293 kB 294 kB ⚠️ +669 B
404.html gzip 1.32 kB 1.32 kB ✓
hooks.html gzip 958 B 958 B ✓
index.js gzip 294 kB 294 kB -224 B
link.js gzip 301 kB 301 kB ⚠️ +55 B
routerDirect.js gzip 300 kB 300 kB ⚠️ +297 B
withRouter.js gzip 300 kB 300 kB ⚠️ +696 B
Overall change 1.49 MB 1.49 MB ⚠️ +1.49 kB

@timneutkens
Copy link
Member

Looks like linting is failing

@timneutkens timneutkens merged commit 19f41c6 into vercel:canary Apr 6, 2020
@timneutkens
Copy link
Member

Thanks!

This was referenced Apr 17, 2020
Merged
Merged
Closed
oddnavy pushed a commit to oddnavy/next.js that referenced this pull request Apr 20, 2020
update postcss.config.js to fix warnings
96f41a2 
Return empty array if the condition is not met to avoid a null/undefined PostCSS plugin.

Related PR: vercel#11366
@oddnavy oddnavy mentioned this pull request Apr 20, 2020
Merged
oddnavy pushed a commit to oddnavy/next.js that referenced this pull request Apr 21, 2020
update postcss.config.js to fix warnings
97649d4 
Return empty array if the condition is not met to avoid a null/undefined PostCSS plugin.

Related PR: vercel#11366
timneutkens pushed a commit that referenced this pull request Apr 21, 2020
@oddnavy
fix postcss.config.js warnings (#12070)
600b78c 
* update postcss.config.js to fix warnings

Return empty array if the condition is not met to avoid a null/undefined PostCSS plugin.

Related PR: #11366

* style: correct linting error
@paul-vd
Copy link
Contributor Author

paul-vd commented Apr 29, 2020

FYI Update with tailwind built-in purge tailwindlabs/tailwindcss#1639

ryscheng pushed a commit to plasmicapp/nextjs-starter-plv1 that referenced this pull request Jan 6, 2021
@oddnavy
fix postcss.config.js warnings (#12070)
11bb15d 
* update postcss.config.js to fix warnings

Return empty array if the condition is not met to avoid a null/undefined PostCSS plugin.

Related PR: vercel/next.js#11366

* style: correct linting error
@vercel vercel locked as resolved and limited conversation to collaborators Jan 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@timneutkens timneutkens timneutkens approved these changes

@lfades lfades Awaiting requested review from lfades

@Timer Timer Awaiting requested review from Timer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@paul-vd @ijjk @timneutkens