Fix bug where pages refresh periodically for custom server #11418

joeytepp · 2020-03-27T22:56:11Z

Fixes #11243. When rendering a page where the path name doesn't start with a / with a custom server the page will refresh every 5 seconds. This is due to the fact that the entries object in the onDemandEntryHandler checks for keys that start with a /, and when the page is rendered without a / the entry can't be properly found. The solution fo this was to add an error when a user attempts to render a page that doesn't start witha /.

ijjk · 2020-03-27T23:01:40Z

Stats from current PR

Default Server Mode

General Overall increase ⚠️

	zeit/next.js canary	joeytepp/next.js fix-custom-server-ping-bug	Change
buildDuration	9.3s	9.3s	-2ms
nodeModulesSize	52.8 MB	52.8 MB	⚠️ +180 B

Client Bundles (main, webpack, commons)

	zeit/next.js canary	joeytepp/next.js fix-custom-server-ping-bug	Change
main-HASH.js gzip	6.24 kB	6.24 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..c6c1.js gzip	10.1 kB	10.1 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	56.2 kB	56.2 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	joeytepp/next.js fix-custom-server-ping-bug	Change
main-HASH.module.js gzip	4.77 kB	4.77 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	6.71 kB	6.71 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	51.4 kB	51.4 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	joeytepp/next.js fix-custom-server-ping-bug	Change
polyfills-HASH.js gzip	26.3 kB	26.3 kB	✓
Overall change	26.3 kB	26.3 kB	✓

Client Pages

	zeit/next.js canary	joeytepp/next.js fix-custom-server-ping-bug	Change
_app.js gzip	1.24 kB	1.24 kB	✓
_error.js gzip	3.15 kB	3.15 kB	✓
hooks.js gzip	664 B	664 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.03 kB	2.03 kB	✓
routerDirect.js gzip	279 B	279 B	✓
withRouter.js gzip	278 B	278 B	✓
Overall change	7.86 kB	7.86 kB	✓

Client Pages Modern

	zeit/next.js canary	joeytepp/next.js fix-custom-server-ping-bug	Change
_app.module.js gzip	594 B	594 B	✓
_error.module.js gzip	2.08 kB	2.08 kB	✓
hooks.module.js gzip	370 B	370 B	✓
index.module.js gzip	212 B	212 B	✓
link.module.js gzip	1.48 kB	1.48 kB	✓
routerDirect..dule.js gzip	271 B	271 B	✓
withRouter.m..dule.js gzip	270 B	270 B	✓
Overall change	5.28 kB	5.28 kB	✓

Client Build Manifests

	zeit/next.js canary	joeytepp/next.js fix-custom-server-ping-bug	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Rendered Page Sizes

	zeit/next.js canary	joeytepp/next.js fix-custom-server-ping-bug	Change
index.html gzip	917 B	917 B	✓
link.html gzip	925 B	925 B	✓
withRouter.html gzip	915 B	915 B	✓
Overall change	2.76 kB	2.76 kB	✓

Serverless Mode (Increase detected ⚠️)

General Overall increase ⚠️

	zeit/next.js canary	joeytepp/next.js fix-custom-server-ping-bug	Change
buildDuration	10.3s	10s	-284ms
nodeModulesSize	52.8 MB	52.8 MB	⚠️ +180 B

Client Bundles (main, webpack, commons)

	zeit/next.js canary	joeytepp/next.js fix-custom-server-ping-bug	Change
main-HASH.js gzip	6.24 kB	6.24 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..c6c1.js gzip	10.1 kB	10.1 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	56.2 kB	56.2 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	joeytepp/next.js fix-custom-server-ping-bug	Change
main-HASH.module.js gzip	4.77 kB	4.77 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	6.71 kB	6.71 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	51.4 kB	51.4 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	joeytepp/next.js fix-custom-server-ping-bug	Change
polyfills-HASH.js gzip	26.3 kB	26.3 kB	✓
Overall change	26.3 kB	26.3 kB	✓

Client Pages

	zeit/next.js canary	joeytepp/next.js fix-custom-server-ping-bug	Change
_app.js gzip	1.24 kB	1.24 kB	✓
_error.js gzip	3.15 kB	3.15 kB	✓
hooks.js gzip	664 B	664 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.03 kB	2.03 kB	✓
routerDirect.js gzip	279 B	279 B	✓
withRouter.js gzip	278 B	278 B	✓
Overall change	7.86 kB	7.86 kB	✓

Client Pages Modern

	zeit/next.js canary	joeytepp/next.js fix-custom-server-ping-bug	Change
_app.module.js gzip	594 B	594 B	✓
_error.module.js gzip	2.08 kB	2.08 kB	✓
hooks.module.js gzip	370 B	370 B	✓
index.module.js gzip	212 B	212 B	✓
link.module.js gzip	1.48 kB	1.48 kB	✓
routerDirect..dule.js gzip	271 B	271 B	✓
withRouter.m..dule.js gzip	270 B	270 B	✓
Overall change	5.28 kB	5.28 kB	✓

Client Build Manifests

	zeit/next.js canary	joeytepp/next.js fix-custom-server-ping-bug	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Serverless bundles Overall increase ⚠️

	zeit/next.js canary	joeytepp/next.js fix-custom-server-ping-bug	Change
_error.js gzip	294 kB	293 kB	-728 B
404.html gzip	1.32 kB	1.32 kB	✓
hooks.html gzip	958 B	958 B	✓
index.js gzip	294 kB	294 kB	⚠️ +607 B
link.js gzip	302 kB	302 kB	⚠️ +123 B
routerDirect.js gzip	300 kB	300 kB	-297 B
withRouter.js gzip	300 kB	300 kB	⚠️ +918 B
Overall change	1.49 MB	1.49 MB	⚠️ +623 B

ijjk · 2020-03-29T19:51:21Z

Stats from current PR

Default Server Mode

General Overall increase ⚠️

	zeit/next.js canary	joeytepp/next.js fix-custom-server-ping-bug	Change
buildDuration	10.2s	10.7s	⚠️ +452ms
nodeModulesSize	52.8 MB	52.8 MB	⚠️ +180 B

Client Bundles (main, webpack, commons)

	zeit/next.js canary	joeytepp/next.js fix-custom-server-ping-bug	Change
main-HASH.js gzip	6.24 kB	6.24 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..c6c1.js gzip	10.1 kB	10.1 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	56.2 kB	56.2 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	joeytepp/next.js fix-custom-server-ping-bug	Change
main-HASH.module.js gzip	4.77 kB	4.77 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	6.71 kB	6.71 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	51.4 kB	51.4 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	joeytepp/next.js fix-custom-server-ping-bug	Change
polyfills-HASH.js gzip	26.3 kB	26.3 kB	✓
Overall change	26.3 kB	26.3 kB	✓

Client Pages

	zeit/next.js canary	joeytepp/next.js fix-custom-server-ping-bug	Change
_app.js gzip	1.24 kB	1.24 kB	✓
_error.js gzip	3.15 kB	3.15 kB	✓
hooks.js gzip	664 B	664 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.03 kB	2.03 kB	✓
routerDirect.js gzip	279 B	279 B	✓
withRouter.js gzip	278 B	278 B	✓
Overall change	7.86 kB	7.86 kB	✓

Client Pages Modern

	zeit/next.js canary	joeytepp/next.js fix-custom-server-ping-bug	Change
_app.module.js gzip	594 B	594 B	✓
_error.module.js gzip	2.08 kB	2.08 kB	✓
hooks.module.js gzip	370 B	370 B	✓
index.module.js gzip	212 B	212 B	✓
link.module.js gzip	1.48 kB	1.48 kB	✓
routerDirect..dule.js gzip	271 B	271 B	✓
withRouter.m..dule.js gzip	270 B	270 B	✓
Overall change	5.28 kB	5.28 kB	✓

Client Build Manifests

	zeit/next.js canary	joeytepp/next.js fix-custom-server-ping-bug	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Rendered Page Sizes

	zeit/next.js canary	joeytepp/next.js fix-custom-server-ping-bug	Change
index.html gzip	917 B	917 B	✓
link.html gzip	925 B	925 B	✓
withRouter.html gzip	915 B	915 B	✓
Overall change	2.76 kB	2.76 kB	✓

Serverless Mode (Increase detected ⚠️)

General Overall increase ⚠️

	zeit/next.js canary	joeytepp/next.js fix-custom-server-ping-bug	Change
buildDuration	11s	10.9s	-101ms
nodeModulesSize	52.8 MB	52.8 MB	⚠️ +180 B

Client Bundles (main, webpack, commons)

	zeit/next.js canary	joeytepp/next.js fix-custom-server-ping-bug	Change
main-HASH.js gzip	6.24 kB	6.24 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..c6c1.js gzip	10.1 kB	10.1 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	56.2 kB	56.2 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	joeytepp/next.js fix-custom-server-ping-bug	Change
main-HASH.module.js gzip	4.77 kB	4.77 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	6.71 kB	6.71 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	51.4 kB	51.4 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	joeytepp/next.js fix-custom-server-ping-bug	Change
polyfills-HASH.js gzip	26.3 kB	26.3 kB	✓
Overall change	26.3 kB	26.3 kB	✓

Client Pages

	zeit/next.js canary	joeytepp/next.js fix-custom-server-ping-bug	Change
_app.js gzip	1.24 kB	1.24 kB	✓
_error.js gzip	3.15 kB	3.15 kB	✓
hooks.js gzip	664 B	664 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.03 kB	2.03 kB	✓
routerDirect.js gzip	279 B	279 B	✓
withRouter.js gzip	278 B	278 B	✓
Overall change	7.86 kB	7.86 kB	✓

Client Pages Modern

	zeit/next.js canary	joeytepp/next.js fix-custom-server-ping-bug	Change
_app.module.js gzip	594 B	594 B	✓
_error.module.js gzip	2.08 kB	2.08 kB	✓
hooks.module.js gzip	370 B	370 B	✓
index.module.js gzip	212 B	212 B	✓
link.module.js gzip	1.48 kB	1.48 kB	✓
routerDirect..dule.js gzip	271 B	271 B	✓
withRouter.m..dule.js gzip	270 B	270 B	✓
Overall change	5.28 kB	5.28 kB	✓

Client Build Manifests

	zeit/next.js canary	joeytepp/next.js fix-custom-server-ping-bug	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Serverless bundles Overall increase ⚠️

	zeit/next.js canary	joeytepp/next.js fix-custom-server-ping-bug	Change
_error.js gzip	294 kB	294 kB	-191 B
404.html gzip	1.32 kB	1.32 kB	✓
hooks.html gzip	958 B	958 B	✓
index.js gzip	294 kB	294 kB	-240 B
link.js gzip	301 kB	302 kB	⚠️ +597 B
routerDirect.js gzip	300 kB	301 kB	⚠️ +490 B
withRouter.js gzip	300 kB	300 kB	⚠️ +175 B
Overall change	1.49 MB	1.49 MB	⚠️ +831 B

ijjk · 2020-03-29T19:54:08Z

Stats from current PR

Default Server Mode

General Overall increase ⚠️

	zeit/next.js canary	joeytepp/next.js fix-custom-server-ping-bug	Change
buildDuration	10.6s	10.6s	-1ms
nodeModulesSize	52.8 MB	52.8 MB	⚠️ +180 B

Client Bundles (main, webpack, commons)

	zeit/next.js canary	joeytepp/next.js fix-custom-server-ping-bug	Change
main-HASH.js gzip	6.24 kB	6.24 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..c6c1.js gzip	10.1 kB	10.1 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	56.2 kB	56.2 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	joeytepp/next.js fix-custom-server-ping-bug	Change
main-HASH.module.js gzip	4.77 kB	4.77 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	6.71 kB	6.71 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	51.4 kB	51.4 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	joeytepp/next.js fix-custom-server-ping-bug	Change
polyfills-HASH.js gzip	26.3 kB	26.3 kB	✓
Overall change	26.3 kB	26.3 kB	✓

Client Pages

	zeit/next.js canary	joeytepp/next.js fix-custom-server-ping-bug	Change
_app.js gzip	1.24 kB	1.24 kB	✓
_error.js gzip	3.15 kB	3.15 kB	✓
hooks.js gzip	664 B	664 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.03 kB	2.03 kB	✓
routerDirect.js gzip	279 B	279 B	✓
withRouter.js gzip	278 B	278 B	✓
Overall change	7.86 kB	7.86 kB	✓

Client Pages Modern

	zeit/next.js canary	joeytepp/next.js fix-custom-server-ping-bug	Change
_app.module.js gzip	594 B	594 B	✓
_error.module.js gzip	2.08 kB	2.08 kB	✓
hooks.module.js gzip	370 B	370 B	✓
index.module.js gzip	212 B	212 B	✓
link.module.js gzip	1.48 kB	1.48 kB	✓
routerDirect..dule.js gzip	271 B	271 B	✓
withRouter.m..dule.js gzip	270 B	270 B	✓
Overall change	5.28 kB	5.28 kB	✓

Client Build Manifests

	zeit/next.js canary	joeytepp/next.js fix-custom-server-ping-bug	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Rendered Page Sizes

	zeit/next.js canary	joeytepp/next.js fix-custom-server-ping-bug	Change
index.html gzip	917 B	917 B	✓
link.html gzip	925 B	925 B	✓
withRouter.html gzip	915 B	915 B	✓
Overall change	2.76 kB	2.76 kB	✓

Serverless Mode (Increase detected ⚠️)

General Overall increase ⚠️

	zeit/next.js canary	joeytepp/next.js fix-custom-server-ping-bug	Change
buildDuration	11.3s	11.4s	⚠️ +76ms
nodeModulesSize	52.8 MB	52.8 MB	⚠️ +180 B

Client Bundles (main, webpack, commons)

	zeit/next.js canary	joeytepp/next.js fix-custom-server-ping-bug	Change
main-HASH.js gzip	6.24 kB	6.24 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..c6c1.js gzip	10.1 kB	10.1 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	56.2 kB	56.2 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	joeytepp/next.js fix-custom-server-ping-bug	Change
main-HASH.module.js gzip	4.77 kB	4.77 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	6.71 kB	6.71 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	51.4 kB	51.4 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	joeytepp/next.js fix-custom-server-ping-bug	Change
polyfills-HASH.js gzip	26.3 kB	26.3 kB	✓
Overall change	26.3 kB	26.3 kB	✓

Client Pages

	zeit/next.js canary	joeytepp/next.js fix-custom-server-ping-bug	Change
_app.js gzip	1.24 kB	1.24 kB	✓
_error.js gzip	3.15 kB	3.15 kB	✓
hooks.js gzip	664 B	664 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.03 kB	2.03 kB	✓
routerDirect.js gzip	279 B	279 B	✓
withRouter.js gzip	278 B	278 B	✓
Overall change	7.86 kB	7.86 kB	✓

Client Pages Modern

	zeit/next.js canary	joeytepp/next.js fix-custom-server-ping-bug	Change
_app.module.js gzip	594 B	594 B	✓
_error.module.js gzip	2.08 kB	2.08 kB	✓
hooks.module.js gzip	370 B	370 B	✓
index.module.js gzip	212 B	212 B	✓
link.module.js gzip	1.48 kB	1.48 kB	✓
routerDirect..dule.js gzip	271 B	271 B	✓
withRouter.m..dule.js gzip	270 B	270 B	✓
Overall change	5.28 kB	5.28 kB	✓

Client Build Manifests

	zeit/next.js canary	joeytepp/next.js fix-custom-server-ping-bug	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Serverless bundles Overall increase ⚠️

	zeit/next.js canary	joeytepp/next.js fix-custom-server-ping-bug	Change
_error.js gzip	293 kB	293 kB	⚠️ +51 B
404.html gzip	1.32 kB	1.32 kB	✓
hooks.html gzip	958 B	958 B	✓
index.js gzip	294 kB	294 kB	⚠️ +145 B
link.js gzip	301 kB	302 kB	⚠️ +583 B
routerDirect.js gzip	300 kB	300 kB	⚠️ +639 B
withRouter.js gzip	300 kB	300 kB	⚠️ +689 B
Overall change	1.49 MB	1.49 MB	⚠️ +2.11 kB

ijjk · 2020-03-30T01:13:22Z

Stats from current PR

Default Server Mode

General Overall increase ⚠️

	zeit/next.js canary	joeytepp/next.js fix-custom-server-ping-bug	Change
buildDuration	10.5s	10.5s	⚠️ +20ms
nodeModulesSize	52.8 MB	52.8 MB	⚠️ +180 B

Client Bundles (main, webpack, commons)

	zeit/next.js canary	joeytepp/next.js fix-custom-server-ping-bug	Change
main-HASH.js gzip	6.24 kB	6.24 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..c6c1.js gzip	10.1 kB	10.1 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	56.2 kB	56.2 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	joeytepp/next.js fix-custom-server-ping-bug	Change
main-HASH.module.js gzip	4.77 kB	4.77 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	6.71 kB	6.71 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	51.4 kB	51.4 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	joeytepp/next.js fix-custom-server-ping-bug	Change
polyfills-HASH.js gzip	26.3 kB	26.3 kB	✓
Overall change	26.3 kB	26.3 kB	✓

Client Pages

	zeit/next.js canary	joeytepp/next.js fix-custom-server-ping-bug	Change
_app.js gzip	1.24 kB	1.24 kB	✓
_error.js gzip	3.15 kB	3.15 kB	✓
hooks.js gzip	664 B	664 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.03 kB	2.03 kB	✓
routerDirect.js gzip	279 B	279 B	✓
withRouter.js gzip	278 B	278 B	✓
Overall change	7.86 kB	7.86 kB	✓

Client Pages Modern

	zeit/next.js canary	joeytepp/next.js fix-custom-server-ping-bug	Change
_app.module.js gzip	594 B	594 B	✓
_error.module.js gzip	2.08 kB	2.08 kB	✓
hooks.module.js gzip	370 B	370 B	✓
index.module.js gzip	212 B	212 B	✓
link.module.js gzip	1.48 kB	1.48 kB	✓
routerDirect..dule.js gzip	271 B	271 B	✓
withRouter.m..dule.js gzip	270 B	270 B	✓
Overall change	5.28 kB	5.28 kB	✓

Client Build Manifests

	zeit/next.js canary	joeytepp/next.js fix-custom-server-ping-bug	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Rendered Page Sizes

	zeit/next.js canary	joeytepp/next.js fix-custom-server-ping-bug	Change
index.html gzip	917 B	917 B	✓
link.html gzip	925 B	925 B	✓
withRouter.html gzip	915 B	915 B	✓
Overall change	2.76 kB	2.76 kB	✓

Serverless Mode (Decrease detected ✓)

General Overall increase ⚠️

	zeit/next.js canary	joeytepp/next.js fix-custom-server-ping-bug	Change
buildDuration	11.4s	11.2s	-190ms
nodeModulesSize	52.8 MB	52.8 MB	⚠️ +180 B

Client Bundles (main, webpack, commons)

	zeit/next.js canary	joeytepp/next.js fix-custom-server-ping-bug	Change
main-HASH.js gzip	6.24 kB	6.24 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..c6c1.js gzip	10.1 kB	10.1 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	56.2 kB	56.2 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	joeytepp/next.js fix-custom-server-ping-bug	Change
main-HASH.module.js gzip	4.77 kB	4.77 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	6.71 kB	6.71 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	51.4 kB	51.4 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	joeytepp/next.js fix-custom-server-ping-bug	Change
polyfills-HASH.js gzip	26.3 kB	26.3 kB	✓
Overall change	26.3 kB	26.3 kB	✓

Client Pages

	zeit/next.js canary	joeytepp/next.js fix-custom-server-ping-bug	Change
_app.js gzip	1.24 kB	1.24 kB	✓
_error.js gzip	3.15 kB	3.15 kB	✓
hooks.js gzip	664 B	664 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.03 kB	2.03 kB	✓
routerDirect.js gzip	279 B	279 B	✓
withRouter.js gzip	278 B	278 B	✓
Overall change	7.86 kB	7.86 kB	✓

Client Pages Modern

	zeit/next.js canary	joeytepp/next.js fix-custom-server-ping-bug	Change
_app.module.js gzip	594 B	594 B	✓
_error.module.js gzip	2.08 kB	2.08 kB	✓
hooks.module.js gzip	370 B	370 B	✓
index.module.js gzip	212 B	212 B	✓
link.module.js gzip	1.48 kB	1.48 kB	✓
routerDirect..dule.js gzip	271 B	271 B	✓
withRouter.m..dule.js gzip	270 B	270 B	✓
Overall change	5.28 kB	5.28 kB	✓

Client Build Manifests

	zeit/next.js canary	joeytepp/next.js fix-custom-server-ping-bug	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Serverless bundles Overall decrease ✓

	zeit/next.js canary	joeytepp/next.js fix-custom-server-ping-bug	Change
_error.js gzip	294 kB	293 kB	-1.3 kB
404.html gzip	1.32 kB	1.32 kB	✓
hooks.html gzip	958 B	958 B	✓
index.js gzip	294 kB	294 kB	⚠️ +50 B
link.js gzip	302 kB	301 kB	-909 B
routerDirect.js gzip	300 kB	300 kB	-318 B
withRouter.js gzip	300 kB	300 kB	⚠️ +288 B
Overall change	1.49 MB	1.49 MB	-2.19 kB

joeytepp · 2020-03-30T04:10:18Z

Failed tests do not seem to be due to my chagnges (link)

packages/next/server/on-demand-entry-handler.ts

timneutkens

Posted a review

joeytepp · 2020-04-01T00:29:51Z

@timneutkens made changes based on your review.

ijjk · 2020-04-01T00:35:44Z

Stats from current PR

Default Server Mode

General Overall increase ⚠️

	zeit/next.js canary	joeytepp/next.js fix-custom-server-ping-bug	Change
buildDuration	10.9s	10.7s	-202ms
nodeModulesSize	47.7 MB	47.7 MB	⚠️ +314 B

Client Bundles (main, webpack, commons)

	zeit/next.js canary	joeytepp/next.js fix-custom-server-ping-bug	Change
main-HASH.js gzip	6.25 kB	6.25 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..c6c1.js gzip	10.1 kB	10.1 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	56.3 kB	56.3 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	joeytepp/next.js fix-custom-server-ping-bug	Change
main-HASH.module.js gzip	4.78 kB	4.78 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	6.71 kB	6.71 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	51.4 kB	51.4 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	joeytepp/next.js fix-custom-server-ping-bug	Change
polyfills-HASH.js gzip	26.3 kB	26.3 kB	✓
Overall change	26.3 kB	26.3 kB	✓

Client Pages

	zeit/next.js canary	joeytepp/next.js fix-custom-server-ping-bug	Change
_app.js gzip	1.24 kB	1.24 kB	✓
_error.js gzip	3.15 kB	3.15 kB	✓
hooks.js gzip	664 B	664 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.03 kB	2.03 kB	✓
routerDirect.js gzip	279 B	279 B	✓
withRouter.js gzip	278 B	278 B	✓
Overall change	7.86 kB	7.86 kB	✓

Client Pages Modern

	zeit/next.js canary	joeytepp/next.js fix-custom-server-ping-bug	Change
_app.module.js gzip	594 B	594 B	✓
_error.module.js gzip	2.08 kB	2.08 kB	✓
hooks.module.js gzip	370 B	370 B	✓
index.module.js gzip	212 B	212 B	✓
link.module.js gzip	1.48 kB	1.48 kB	✓
routerDirect..dule.js gzip	271 B	271 B	✓
withRouter.m..dule.js gzip	270 B	270 B	✓
Overall change	5.28 kB	5.28 kB	✓

Client Build Manifests

	zeit/next.js canary	joeytepp/next.js fix-custom-server-ping-bug	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Rendered Page Sizes

	zeit/next.js canary	joeytepp/next.js fix-custom-server-ping-bug	Change
index.html gzip	919 B	919 B	✓
link.html gzip	927 B	927 B	✓
withRouter.html gzip	917 B	917 B	✓
Overall change	2.76 kB	2.76 kB	✓

Serverless Mode (Decrease detected ✓)

General Overall increase ⚠️

	zeit/next.js canary	joeytepp/next.js fix-custom-server-ping-bug	Change
buildDuration	11.8s	11.4s	-334ms
nodeModulesSize	47.7 MB	47.7 MB	⚠️ +314 B

Client Bundles (main, webpack, commons)

	zeit/next.js canary	joeytepp/next.js fix-custom-server-ping-bug	Change
main-HASH.js gzip	6.25 kB	6.25 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..c6c1.js gzip	10.1 kB	10.1 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	56.3 kB	56.3 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	joeytepp/next.js fix-custom-server-ping-bug	Change
main-HASH.module.js gzip	4.78 kB	4.78 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	6.71 kB	6.71 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	51.4 kB	51.4 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	joeytepp/next.js fix-custom-server-ping-bug	Change
polyfills-HASH.js gzip	26.3 kB	26.3 kB	✓
Overall change	26.3 kB	26.3 kB	✓

Client Pages

	zeit/next.js canary	joeytepp/next.js fix-custom-server-ping-bug	Change
_app.js gzip	1.24 kB	1.24 kB	✓
_error.js gzip	3.15 kB	3.15 kB	✓
hooks.js gzip	664 B	664 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.03 kB	2.03 kB	✓
routerDirect.js gzip	279 B	279 B	✓
withRouter.js gzip	278 B	278 B	✓
Overall change	7.86 kB	7.86 kB	✓

Client Pages Modern

	zeit/next.js canary	joeytepp/next.js fix-custom-server-ping-bug	Change
_app.module.js gzip	594 B	594 B	✓
_error.module.js gzip	2.08 kB	2.08 kB	✓
hooks.module.js gzip	370 B	370 B	✓
index.module.js gzip	212 B	212 B	✓
link.module.js gzip	1.48 kB	1.48 kB	✓
routerDirect..dule.js gzip	271 B	271 B	✓
withRouter.m..dule.js gzip	270 B	270 B	✓
Overall change	5.28 kB	5.28 kB	✓

Client Build Manifests

	zeit/next.js canary	joeytepp/next.js fix-custom-server-ping-bug	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Serverless bundles Overall decrease ✓

	zeit/next.js canary	joeytepp/next.js fix-custom-server-ping-bug	Change
_error.js gzip	233 kB	232 kB	-121 B
404.html gzip	1.33 kB	1.33 kB	✓
hooks.html gzip	960 B	960 B	✓
index.js gzip	232 kB	232 kB	-19 B
link.js gzip	243 kB	243 kB	⚠️ +191 B
routerDirect.js gzip	241 kB	241 kB	-82 B
withRouter.js gzip	241 kB	241 kB	-10 B
Overall change	1.19 MB	1.19 MB	-41 B

ijjk · 2020-04-01T00:41:31Z

Failing test suites

test/integration/basic/test/index.test.js

Basic Features > Error Recovery > should recover from errors in getInitialProps in client
Basic Features > Error Recovery > should recover after an error reported via SSR

Expand output

● Basic Features › Error Recovery › should recover from errors in getInitialProps in client

TIMED OUT CHECK FOR IFRAME

  379 |     }
  380 |     console.error('TIMED OUT CHECK FOR IFRAME')
> 381 |     throw new Error('TIMED OUT CHECK FOR IFRAME')
      |           ^
  382 |   }, 1000 * 30)
  383 |   while (!found) {
  384 |     try {

  at Timeout._onTimeout (lib/next-test-utils.js:381:11)

● Basic Features › Error Recovery › should recover after an error reported via SSR

TIMED OUT CHECK FOR IFRAME

  379 |     }
  380 |     console.error('TIMED OUT CHECK FOR IFRAME')
> 381 |     throw new Error('TIMED OUT CHECK FOR IFRAME')
      |           ^
  382 |   }, 1000 * 30)
  383 |   while (!found) {
  384 |     try {

  at Timeout._onTimeout (lib/next-test-utils.js:381:11)

packages/next/next-server/server/next-server.ts

Throws an error for development and gives a warning in production

joeytepp · 2020-04-05T18:41:12Z

@timneutkens Updated!

ijjk · 2020-04-05T18:47:23Z

Stats from current PR

Default Server Mode

General Overall increase ⚠️

	zeit/next.js canary	joeytepp/next.js fix-custom-server-ping-bug	Change
buildDuration	11.1s	11s	-55ms
nodeModulesSize	47.7 MB	47.7 MB	⚠️ +725 B

Client Bundles (main, webpack, commons)

	zeit/next.js canary	joeytepp/next.js fix-custom-server-ping-bug	Change
main-HASH.js gzip	6.25 kB	6.25 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..3f64.js gzip	10.2 kB	10.2 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	56.4 kB	56.4 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	joeytepp/next.js fix-custom-server-ping-bug	Change
main-HASH.module.js gzip	4.78 kB	4.78 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	6.82 kB	6.82 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	51.5 kB	51.5 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	joeytepp/next.js fix-custom-server-ping-bug	Change
polyfills-HASH.js gzip	26.3 kB	26.3 kB	✓
Overall change	26.3 kB	26.3 kB	✓

Client Pages

	zeit/next.js canary	joeytepp/next.js fix-custom-server-ping-bug	Change
_app.js gzip	1.24 kB	1.24 kB	✓
_error.js gzip	3.15 kB	3.15 kB	✓
hooks.js gzip	664 B	664 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.03 kB	2.03 kB	✓
routerDirect.js gzip	279 B	279 B	✓
withRouter.js gzip	278 B	278 B	✓
Overall change	7.86 kB	7.86 kB	✓

Client Pages Modern

	zeit/next.js canary	joeytepp/next.js fix-custom-server-ping-bug	Change
_app.module.js gzip	594 B	594 B	✓
_error.module.js gzip	2.08 kB	2.08 kB	✓
hooks.module.js gzip	370 B	370 B	✓
index.module.js gzip	212 B	212 B	✓
link.module.js gzip	1.48 kB	1.48 kB	✓
routerDirect..dule.js gzip	271 B	271 B	✓
withRouter.m..dule.js gzip	270 B	270 B	✓
Overall change	5.28 kB	5.28 kB	✓

Client Build Manifests

	zeit/next.js canary	joeytepp/next.js fix-custom-server-ping-bug	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Rendered Page Sizes

	zeit/next.js canary	joeytepp/next.js fix-custom-server-ping-bug	Change
index.html gzip	918 B	918 B	✓
link.html gzip	927 B	927 B	✓
withRouter.html gzip	914 B	914 B	✓
Overall change	2.76 kB	2.76 kB	✓

Serverless Mode (Decrease detected ✓)

General Overall increase ⚠️

	zeit/next.js canary	joeytepp/next.js fix-custom-server-ping-bug	Change
buildDuration	11.7s	12.4s	⚠️ +706ms
nodeModulesSize	47.7 MB	47.7 MB	⚠️ +725 B

Client Bundles (main, webpack, commons)

	zeit/next.js canary	joeytepp/next.js fix-custom-server-ping-bug	Change
main-HASH.js gzip	6.25 kB	6.25 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..3f64.js gzip	10.2 kB	10.2 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	56.4 kB	56.4 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	joeytepp/next.js fix-custom-server-ping-bug	Change
main-HASH.module.js gzip	4.78 kB	4.78 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	6.82 kB	6.82 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	51.5 kB	51.5 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	joeytepp/next.js fix-custom-server-ping-bug	Change
polyfills-HASH.js gzip	26.3 kB	26.3 kB	✓
Overall change	26.3 kB	26.3 kB	✓

Client Pages

	zeit/next.js canary	joeytepp/next.js fix-custom-server-ping-bug	Change
_app.js gzip	1.24 kB	1.24 kB	✓
_error.js gzip	3.15 kB	3.15 kB	✓
hooks.js gzip	664 B	664 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.03 kB	2.03 kB	✓
routerDirect.js gzip	279 B	279 B	✓
withRouter.js gzip	278 B	278 B	✓
Overall change	7.86 kB	7.86 kB	✓

Client Pages Modern

	zeit/next.js canary	joeytepp/next.js fix-custom-server-ping-bug	Change
_app.module.js gzip	594 B	594 B	✓
_error.module.js gzip	2.08 kB	2.08 kB	✓
hooks.module.js gzip	370 B	370 B	✓
index.module.js gzip	212 B	212 B	✓
link.module.js gzip	1.48 kB	1.48 kB	✓
routerDirect..dule.js gzip	271 B	271 B	✓
withRouter.m..dule.js gzip	270 B	270 B	✓
Overall change	5.28 kB	5.28 kB	✓

Client Build Manifests

	zeit/next.js canary	joeytepp/next.js fix-custom-server-ping-bug	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Serverless bundles Overall decrease ✓

	zeit/next.js canary	joeytepp/next.js fix-custom-server-ping-bug	Change
_error.js gzip	233 kB	233 kB	-385 B
404.html gzip	1.32 kB	1.32 kB	✓
hooks.html gzip	957 B	957 B	✓
index.js gzip	233 kB	233 kB	⚠️ +47 B
link.js gzip	243 kB	243 kB	⚠️ +171 B
routerDirect.js gzip	241 kB	241 kB	-79 B
withRouter.js gzip	241 kB	241 kB	-15 B
Overall change	1.19 MB	1.19 MB	-261 B

…-ping-bug

packages/next/next-server/server/next-server.ts

…-ping-bug

errors/render-no-starting-slash.md

timneutkens · 2020-04-06T17:29:23Z

Awesome work @joeytepp, thank you very much 🙏

joeytepp requested review from ijjk, lfades, Timer and timneutkens as code owners March 27, 2020 22:56

joeytepp force-pushed the fix-custom-server-ping-bug branch 2 times, most recently from cbc3320 to 169ff62 Compare March 29, 2020 19:47

joeytepp force-pushed the fix-custom-server-ping-bug branch from 169ff62 to fcec6ca Compare March 30, 2020 01:07

timneutkens reviewed Mar 30, 2020

View reviewed changes

packages/next/server/on-demand-entry-handler.ts Outdated Show resolved Hide resolved

timneutkens requested changes Mar 30, 2020

View reviewed changes

joeytepp force-pushed the fix-custom-server-ping-bug branch from fcec6ca to 4af93cb Compare April 1, 2020 00:28

timneutkens reviewed Apr 1, 2020

View reviewed changes

packages/next/next-server/server/next-server.ts Outdated Show resolved Hide resolved

Add error/warning when a page is rendered without a /

1c374ed

Throws an error for development and gives a warning in production

joeytepp force-pushed the fix-custom-server-ping-bug branch from 4af93cb to 1c374ed Compare April 5, 2020 18:39

timneutkens added the type: next label Apr 6, 2020

ijjk added 2 commits April 6, 2020 10:58

Merge remote-tracking branch 'upstream/canary' into fix-custom-server…

4385618

…-ping-bug

Add tests for error when rendering without starting slash

a89ecc1

timneutkens reviewed Apr 6, 2020

View reviewed changes

packages/next/next-server/server/next-server.ts Outdated Show resolved Hide resolved

timneutkens reviewed Apr 6, 2020

View reviewed changes

packages/next/next-server/server/next-server.ts Outdated Show resolved Hide resolved

ijjk added 2 commits April 6, 2020 11:22

Update to always warn and add err.sh

9f52116

Merge remote-tracking branch 'upstream/canary' into fix-custom-server…

3c0947e

…-ping-bug

ijjk requested a review from timneutkens April 6, 2020 16:25

ijjk approved these changes Apr 6, 2020

View reviewed changes

timneutkens reviewed Apr 6, 2020

View reviewed changes

errors/render-no-starting-slash.md Outdated Show resolved Hide resolved

Update errors/render-no-starting-slash.md

e80a9c4

timneutkens approved these changes Apr 6, 2020

View reviewed changes

ijjk merged commit cdc7f01 into vercel:canary Apr 6, 2020

joeytepp deleted the fix-custom-server-ping-bug branch April 6, 2020 17:18

This was referenced Apr 17, 2020

[Snyk] Upgrade next from 9.3.4 to 9.3.5 anephenix/ui#4

Merged

[Snyk] Upgrade next from 9.3.4 to 9.3.5 yowainwright/Advanced-React#61

Merged

[Snyk] Upgrade next from 9.3.2 to 9.3.5 tuan231195/sportywide-news#3

Closed

vercel locked as resolved and limited conversation to collaborators Jan 31, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix bug where pages refresh periodically for custom server #11418

Fix bug where pages refresh periodically for custom server #11418

joeytepp commented Mar 27, 2020 •

edited

Loading

ijjk commented Mar 27, 2020

ijjk commented Mar 29, 2020

ijjk commented Mar 29, 2020

ijjk commented Mar 30, 2020

joeytepp commented Mar 30, 2020 •

edited

Loading

timneutkens left a comment

joeytepp commented Apr 1, 2020

ijjk commented Apr 1, 2020

ijjk commented Apr 1, 2020

joeytepp commented Apr 5, 2020

ijjk commented Apr 5, 2020

timneutkens commented Apr 6, 2020

Fix bug where pages refresh periodically for custom server #11418

Fix bug where pages refresh periodically for custom server #11418

Conversation

joeytepp commented Mar 27, 2020 • edited Loading

ijjk commented Mar 27, 2020

Stats from current PR

ijjk commented Mar 29, 2020

Stats from current PR

ijjk commented Mar 29, 2020

Stats from current PR

ijjk commented Mar 30, 2020

Stats from current PR

joeytepp commented Mar 30, 2020 • edited Loading

timneutkens left a comment

Choose a reason for hiding this comment

joeytepp commented Apr 1, 2020

ijjk commented Apr 1, 2020

Stats from current PR

ijjk commented Apr 1, 2020

Failing test suites

joeytepp commented Apr 5, 2020

ijjk commented Apr 5, 2020

Stats from current PR

timneutkens commented Apr 6, 2020

joeytepp commented Mar 27, 2020 •

edited

Loading

joeytepp commented Mar 30, 2020 •

edited

Loading