Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Serverless Note in Docs #11861

Merged
merged 1 commit into from
Apr 13, 2020
Merged

Update Serverless Note in Docs #11861

merged 1 commit into from
Apr 13, 2020

Conversation

Timer
Copy link
Member

@Timer Timer commented Apr 13, 2020

This updates our documentation to discourage users from configuring target: 'serverless' in their projects if deploying to ZEIT Now.

Setting this target can result in confusing local build errors, as ZEIT Now actually uses experimental-serverless-trace (forces it), which is more widely compatible w/ NPM packages than serverless.

Closes #11860

@Timer Timer added this to the 9.3.5 milestone Apr 13, 2020
@Timer Timer requested review from lfades and ijjk April 13, 2020 20:31
ijjk
ijjk reviewed Apr 13, 2020
View reviewed changes
docs/api-reference/next.config.js/build-target.md
@@ -16,7 +16,7 @@ Your application will be built and deployed as a monolith. This is the default t

## `serverless` target

> Deployments to [ZEIT Now](https://zeit.co) will automatically enable this target. You do not need to opt-into it yourself, but you can.
> Deployments to [ZEIT Now](https://zeit.co) will automatically enable this target. You should not opt-into it yourself.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we mention if they want to debug something locally they should use the actual target we use, experimental-serverless-trace?

Copy link
Member Author

@Timer Timer Apr 13, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was hesitant to add something with experimental in the name. I'm pretty confident in its ability such that we don't need to explain how to troubleshoot in the docs, node-file-trace is pretty battle tested.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, experimental-serverless-trace should realistically never fail when run locally (in cases that server would succeed). The actual tracing (which you'd need to troubleshoot) is an implementation detail of our builder.

@ijjk
Copy link
Member

ijjk commented Apr 13, 2020

Stats from current PR

Default Server Mode
General
zeit/next.js canary Timer/next.js docs/adjust-serverless-note Change
buildDuration 10.1s 10.6s ⚠️ +461ms
nodeModulesSize 55.5 MB 55.5 MB ✓
Client Bundles (main, webpack, commons)
zeit/next.js canary Timer/next.js docs/adjust-serverless-note Change
main-HASH.js gzip 6.25 kB 6.25 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..a4ac.js gzip 10.2 kB 10.2 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 56.3 kB 56.3 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary Timer/next.js docs/adjust-serverless-note Change
main-HASH.module.js gzip 4.78 kB 4.78 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.78 kB 6.78 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 51.5 kB 51.5 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary Timer/next.js docs/adjust-serverless-note Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
zeit/next.js canary Timer/next.js docs/adjust-serverless-note Change
_app.js gzip 1.24 kB 1.24 kB ✓
_error.js gzip 3.15 kB 3.15 kB ✓
hooks.js gzip 664 B 664 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.03 kB 2.03 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 7.86 kB 7.86 kB ✓
Client Pages Modern
zeit/next.js canary Timer/next.js docs/adjust-serverless-note Change
_app.module.js gzip 594 B 594 B ✓
_error.module.js gzip 2.08 kB 2.08 kB ✓
hooks.module.js gzip 370 B 370 B ✓
index.module.js gzip 212 B 212 B ✓
link.module.js gzip 1.48 kB 1.48 kB ✓
routerDirect..dule.js gzip 271 B 271 B ✓
withRouter.m..dule.js gzip 270 B 270 B ✓
Overall change 5.28 kB 5.28 kB ✓
Client Build Manifests
zeit/next.js canary Timer/next.js docs/adjust-serverless-note Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Rendered Page Sizes
zeit/next.js canary Timer/next.js docs/adjust-serverless-note Change
index.html gzip 927 B 927 B ✓
link.html gzip 935 B 935 B ✓
withRouter.html gzip 922 B 922 B ✓
Overall change 2.78 kB 2.78 kB ✓
Serverless Mode
General
zeit/next.js canary Timer/next.js docs/adjust-serverless-note Change
buildDuration 11.1s 11.2s ⚠️ +126ms
nodeModulesSize 55.5 MB 55.5 MB ✓
Client Bundles (main, webpack, commons)
zeit/next.js canary Timer/next.js docs/adjust-serverless-note Change
main-HASH.js gzip 6.25 kB 6.25 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..a4ac.js gzip 10.2 kB 10.2 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 56.3 kB 56.3 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary Timer/next.js docs/adjust-serverless-note Change
main-HASH.module.js gzip 4.78 kB 4.78 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.78 kB 6.78 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 51.5 kB 51.5 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary Timer/next.js docs/adjust-serverless-note Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
zeit/next.js canary Timer/next.js docs/adjust-serverless-note Change
_app.js gzip 1.24 kB 1.24 kB ✓
_error.js gzip 3.15 kB 3.15 kB ✓
hooks.js gzip 664 B 664 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.03 kB 2.03 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 7.86 kB 7.86 kB ✓
Client Pages Modern
zeit/next.js canary Timer/next.js docs/adjust-serverless-note Change
_app.module.js gzip 594 B 594 B ✓
_error.module.js gzip 2.08 kB 2.08 kB ✓
hooks.module.js gzip 370 B 370 B ✓
index.module.js gzip 212 B 212 B ✓
link.module.js gzip 1.48 kB 1.48 kB ✓
routerDirect..dule.js gzip 271 B 271 B ✓
withRouter.m..dule.js gzip 270 B 270 B ✓
Overall change 5.28 kB 5.28 kB ✓
Client Build Manifests
zeit/next.js canary Timer/next.js docs/adjust-serverless-note Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Serverless bundles
zeit/next.js canary Timer/next.js docs/adjust-serverless-note Change
_error.js 557 kB 557 kB ✓
404.html 4.18 kB 4.18 kB ✓
hooks.html 3.81 kB 3.81 kB ✓
index.js 557 kB 557 kB ✓
link.js 593 kB 593 kB ✓
routerDirect.js 586 kB 586 kB ✓
withRouter.js 586 kB 586 kB ✓
Overall change 2.89 MB 2.89 MB ✓

@Timer Timer requested a review from ijjk April 13, 2020 21:10
@Timer Timer merged commit 39c068e into vercel:canary Apr 13, 2020
@Timer Timer deleted the docs/adjust-serverless-note branch April 13, 2020 21:11
This was referenced Apr 17, 2020
Merged
Merged
Closed
@iaincollins iaincollins mentioned this pull request Jun 27, 2020
Closed
@vercel vercel locked as resolved and limited conversation to collaborators Jan 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ijjk ijjk ijjk approved these changes

@lfades lfades Awaiting requested review from lfades

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
9.3.5
Development

Successfully merging this pull request may close these issues.

Production serverless build importing Firestore fails while including 'google/protobuf/api.proto'
2 participants
@Timer @ijjk