[Examples] Fix with mobx #11907

Talbot3 · 2020-04-15T05:00:54Z

update with-mobx example for best example #11904

ijjk · 2020-04-15T05:03:16Z

Stats from current PR

Default Server Mode (Decrease detected ✓)

General

	zeit/next.js canary	Talbot3/next.js fix/with-mobx	Change
buildDuration	10.6s	10.6s	-53ms
nodeModulesSize	55.5 MB	55.5 MB	✓

Page Load Tests Overall decrease ⚠️

	zeit/next.js canary	Talbot3/next.js fix/with-mobx	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.203	2.15	-0.05
/ avg req/sec	1135.05	1162.77	⚠️ +27.72
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.171	1.189	⚠️ +0.02
/error-in-render avg req/sec	2134.46	2102.98	-31.48

Client Bundles (main, webpack, commons)

	zeit/next.js canary	Talbot3/next.js fix/with-mobx	Change
main-HASH.js gzip	6.24 kB	6.24 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..93a0.js gzip	10.3 kB	10.3 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	56.4 kB	56.4 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	Talbot3/next.js fix/with-mobx	Change
main-HASH.module.js gzip	4.77 kB	4.77 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	6.84 kB	6.84 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	51.5 kB	51.5 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	Talbot3/next.js fix/with-mobx	Change
polyfills-HASH.js gzip	26.3 kB	26.3 kB	✓
Overall change	26.3 kB	26.3 kB	✓

Client Pages

	zeit/next.js canary	Talbot3/next.js fix/with-mobx	Change
_app.js gzip	1.24 kB	1.24 kB	✓
_error.js gzip	3.15 kB	3.15 kB	✓
hooks.js gzip	664 B	664 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.06 kB	2.06 kB	✓
routerDirect.js gzip	279 B	279 B	✓
withRouter.js gzip	278 B	278 B	✓
Overall change	7.88 kB	7.88 kB	✓

Client Pages Modern

	zeit/next.js canary	Talbot3/next.js fix/with-mobx	Change
_app.module.js gzip	594 B	594 B	✓
_error.module.js gzip	2.08 kB	2.08 kB	✓
hooks.module.js gzip	370 B	370 B	✓
index.module.js gzip	212 B	212 B	✓
link.module.js gzip	1.51 kB	1.51 kB	✓
routerDirect..dule.js gzip	271 B	271 B	✓
withRouter.m..dule.js gzip	270 B	270 B	✓
Overall change	5.3 kB	5.3 kB	✓

Client Build Manifests

	zeit/next.js canary	Talbot3/next.js fix/with-mobx	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Rendered Page Sizes

	zeit/next.js canary	Talbot3/next.js fix/with-mobx	Change
index.html gzip	925 B	925 B	✓
link.html gzip	935 B	935 B	✓
withRouter.html gzip	922 B	922 B	✓
Overall change	2.78 kB	2.78 kB	✓

Serverless Mode

General

	zeit/next.js canary	Talbot3/next.js fix/with-mobx	Change
buildDuration	11.4s	11.4s	-21ms
nodeModulesSize	55.5 MB	55.5 MB	✓

Client Bundles (main, webpack, commons)

	zeit/next.js canary	Talbot3/next.js fix/with-mobx	Change
main-HASH.js gzip	6.24 kB	6.24 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..93a0.js gzip	10.3 kB	10.3 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	56.4 kB	56.4 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	Talbot3/next.js fix/with-mobx	Change
main-HASH.module.js gzip	4.77 kB	4.77 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	6.84 kB	6.84 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	51.5 kB	51.5 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	Talbot3/next.js fix/with-mobx	Change
polyfills-HASH.js gzip	26.3 kB	26.3 kB	✓
Overall change	26.3 kB	26.3 kB	✓

Client Pages

	zeit/next.js canary	Talbot3/next.js fix/with-mobx	Change
_app.js gzip	1.24 kB	1.24 kB	✓
_error.js gzip	3.15 kB	3.15 kB	✓
hooks.js gzip	664 B	664 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.06 kB	2.06 kB	✓
routerDirect.js gzip	279 B	279 B	✓
withRouter.js gzip	278 B	278 B	✓
Overall change	7.88 kB	7.88 kB	✓

Client Pages Modern

	zeit/next.js canary	Talbot3/next.js fix/with-mobx	Change
_app.module.js gzip	594 B	594 B	✓
_error.module.js gzip	2.08 kB	2.08 kB	✓
hooks.module.js gzip	370 B	370 B	✓
index.module.js gzip	212 B	212 B	✓
link.module.js gzip	1.51 kB	1.51 kB	✓
routerDirect..dule.js gzip	271 B	271 B	✓
withRouter.m..dule.js gzip	270 B	270 B	✓
Overall change	5.3 kB	5.3 kB	✓

Client Build Manifests

	zeit/next.js canary	Talbot3/next.js fix/with-mobx	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Serverless bundles

	zeit/next.js canary	Talbot3/next.js fix/with-mobx	Change
_error.js	557 kB	557 kB	✓
404.html	4.18 kB	4.18 kB	✓
hooks.html	3.81 kB	3.81 kB	✓
index.js	557 kB	557 kB	✓
link.js	594 kB	594 kB	✓
routerDirect.js	586 kB	586 kB	✓
withRouter.js	586 kB	586 kB	✓
Overall change	2.89 MB	2.89 MB	✓

ijjk · 2020-04-15T05:07:55Z

Stats from current PR

Default Server Mode (Decrease detected ✓)

General

	zeit/next.js canary	Talbot3/next.js fix/with-mobx	Change
buildDuration	11s	10.9s	-111ms
nodeModulesSize	55.5 MB	55.5 MB	✓

Page Load Tests Overall decrease ⚠️

	zeit/next.js canary	Talbot3/next.js fix/with-mobx	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.147	2.341	⚠️ +0.19
/ avg req/sec	1164.34	1068.12	-96.22
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.245	1.317	⚠️ +0.07
/error-in-render avg req/sec	2008.7	1898.31	-110.39

Client Bundles (main, webpack, commons)

	zeit/next.js canary	Talbot3/next.js fix/with-mobx	Change
main-HASH.js gzip	6.24 kB	6.24 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..93a0.js gzip	10.3 kB	10.3 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	56.4 kB	56.4 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	Talbot3/next.js fix/with-mobx	Change
main-HASH.module.js gzip	4.77 kB	4.77 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	6.84 kB	6.84 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	51.5 kB	51.5 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	Talbot3/next.js fix/with-mobx	Change
polyfills-HASH.js gzip	26.3 kB	26.3 kB	✓
Overall change	26.3 kB	26.3 kB	✓

Client Pages

	zeit/next.js canary	Talbot3/next.js fix/with-mobx	Change
_app.js gzip	1.24 kB	1.24 kB	✓
_error.js gzip	3.15 kB	3.15 kB	✓
hooks.js gzip	664 B	664 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.06 kB	2.06 kB	✓
routerDirect.js gzip	279 B	279 B	✓
withRouter.js gzip	278 B	278 B	✓
Overall change	7.88 kB	7.88 kB	✓

Client Pages Modern

	zeit/next.js canary	Talbot3/next.js fix/with-mobx	Change
_app.module.js gzip	594 B	594 B	✓
_error.module.js gzip	2.08 kB	2.08 kB	✓
hooks.module.js gzip	370 B	370 B	✓
index.module.js gzip	212 B	212 B	✓
link.module.js gzip	1.51 kB	1.51 kB	✓
routerDirect..dule.js gzip	271 B	271 B	✓
withRouter.m..dule.js gzip	270 B	270 B	✓
Overall change	5.3 kB	5.3 kB	✓

Client Build Manifests

	zeit/next.js canary	Talbot3/next.js fix/with-mobx	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Rendered Page Sizes

	zeit/next.js canary	Talbot3/next.js fix/with-mobx	Change
index.html gzip	925 B	925 B	✓
link.html gzip	935 B	935 B	✓
withRouter.html gzip	922 B	922 B	✓
Overall change	2.78 kB	2.78 kB	✓

Serverless Mode

General

	zeit/next.js canary	Talbot3/next.js fix/with-mobx	Change
buildDuration	12.4s	12.5s	⚠️ +110ms
nodeModulesSize	55.5 MB	55.5 MB	✓

Client Bundles (main, webpack, commons)

	zeit/next.js canary	Talbot3/next.js fix/with-mobx	Change
main-HASH.js gzip	6.24 kB	6.24 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..93a0.js gzip	10.3 kB	10.3 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	56.4 kB	56.4 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	Talbot3/next.js fix/with-mobx	Change
main-HASH.module.js gzip	4.77 kB	4.77 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	6.84 kB	6.84 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	51.5 kB	51.5 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	Talbot3/next.js fix/with-mobx	Change
polyfills-HASH.js gzip	26.3 kB	26.3 kB	✓
Overall change	26.3 kB	26.3 kB	✓

Client Pages

	zeit/next.js canary	Talbot3/next.js fix/with-mobx	Change
_app.js gzip	1.24 kB	1.24 kB	✓
_error.js gzip	3.15 kB	3.15 kB	✓
hooks.js gzip	664 B	664 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.06 kB	2.06 kB	✓
routerDirect.js gzip	279 B	279 B	✓
withRouter.js gzip	278 B	278 B	✓
Overall change	7.88 kB	7.88 kB	✓

Client Pages Modern

	zeit/next.js canary	Talbot3/next.js fix/with-mobx	Change
_app.module.js gzip	594 B	594 B	✓
_error.module.js gzip	2.08 kB	2.08 kB	✓
hooks.module.js gzip	370 B	370 B	✓
index.module.js gzip	212 B	212 B	✓
link.module.js gzip	1.51 kB	1.51 kB	✓
routerDirect..dule.js gzip	271 B	271 B	✓
withRouter.m..dule.js gzip	270 B	270 B	✓
Overall change	5.3 kB	5.3 kB	✓

Client Build Manifests

	zeit/next.js canary	Talbot3/next.js fix/with-mobx	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Serverless bundles

	zeit/next.js canary	Talbot3/next.js fix/with-mobx	Change
_error.js	557 kB	557 kB	✓
404.html	4.18 kB	4.18 kB	✓
hooks.html	3.81 kB	3.81 kB	✓
index.js	557 kB	557 kB	✓
link.js	594 kB	594 kB	✓
routerDirect.js	586 kB	586 kB	✓
withRouter.js	586 kB	586 kB	✓
Overall change	2.89 MB	2.89 MB	✓

ijjk · 2020-04-15T05:12:19Z

Stats from current PR

Default Server Mode (Decrease detected ✓)

General

	zeit/next.js canary	Talbot3/next.js fix/with-mobx	Change
buildDuration	11.6s	11.9s	⚠️ +278ms
nodeModulesSize	55.5 MB	55.5 MB	✓

Page Load Tests Overall decrease ⚠️

	zeit/next.js canary	Talbot3/next.js fix/with-mobx	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.286	2.341	⚠️ +0.06
/ avg req/sec	1093.82	1067.7	-26.12
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.275	1.279	0
/error-in-render avg req/sec	1961.05	1954.28	-6.77

Client Bundles (main, webpack, commons)

	zeit/next.js canary	Talbot3/next.js fix/with-mobx	Change
main-HASH.js gzip	6.24 kB	6.24 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..93a0.js gzip	10.3 kB	10.3 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	56.4 kB	56.4 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	Talbot3/next.js fix/with-mobx	Change
main-HASH.module.js gzip	4.77 kB	4.77 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	6.84 kB	6.84 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	51.5 kB	51.5 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	Talbot3/next.js fix/with-mobx	Change
polyfills-HASH.js gzip	26.3 kB	26.3 kB	✓
Overall change	26.3 kB	26.3 kB	✓

Client Pages

	zeit/next.js canary	Talbot3/next.js fix/with-mobx	Change
_app.js gzip	1.24 kB	1.24 kB	✓
_error.js gzip	3.15 kB	3.15 kB	✓
hooks.js gzip	664 B	664 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.06 kB	2.06 kB	✓
routerDirect.js gzip	279 B	279 B	✓
withRouter.js gzip	278 B	278 B	✓
Overall change	7.88 kB	7.88 kB	✓

Client Pages Modern

	zeit/next.js canary	Talbot3/next.js fix/with-mobx	Change
_app.module.js gzip	594 B	594 B	✓
_error.module.js gzip	2.08 kB	2.08 kB	✓
hooks.module.js gzip	370 B	370 B	✓
index.module.js gzip	212 B	212 B	✓
link.module.js gzip	1.51 kB	1.51 kB	✓
routerDirect..dule.js gzip	271 B	271 B	✓
withRouter.m..dule.js gzip	270 B	270 B	✓
Overall change	5.3 kB	5.3 kB	✓

Client Build Manifests

	zeit/next.js canary	Talbot3/next.js fix/with-mobx	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Rendered Page Sizes

	zeit/next.js canary	Talbot3/next.js fix/with-mobx	Change
index.html gzip	925 B	925 B	✓
link.html gzip	935 B	935 B	✓
withRouter.html gzip	922 B	922 B	✓
Overall change	2.78 kB	2.78 kB	✓

Serverless Mode

General

	zeit/next.js canary	Talbot3/next.js fix/with-mobx	Change
buildDuration	11.8s	12.1s	⚠️ +303ms
nodeModulesSize	55.5 MB	55.5 MB	✓

Client Bundles (main, webpack, commons)

	zeit/next.js canary	Talbot3/next.js fix/with-mobx	Change
main-HASH.js gzip	6.24 kB	6.24 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..93a0.js gzip	10.3 kB	10.3 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	56.4 kB	56.4 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	Talbot3/next.js fix/with-mobx	Change
main-HASH.module.js gzip	4.77 kB	4.77 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	6.84 kB	6.84 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	51.5 kB	51.5 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	Talbot3/next.js fix/with-mobx	Change
polyfills-HASH.js gzip	26.3 kB	26.3 kB	✓
Overall change	26.3 kB	26.3 kB	✓

Client Pages

	zeit/next.js canary	Talbot3/next.js fix/with-mobx	Change
_app.js gzip	1.24 kB	1.24 kB	✓
_error.js gzip	3.15 kB	3.15 kB	✓
hooks.js gzip	664 B	664 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.06 kB	2.06 kB	✓
routerDirect.js gzip	279 B	279 B	✓
withRouter.js gzip	278 B	278 B	✓
Overall change	7.88 kB	7.88 kB	✓

Client Pages Modern

	zeit/next.js canary	Talbot3/next.js fix/with-mobx	Change
_app.module.js gzip	594 B	594 B	✓
_error.module.js gzip	2.08 kB	2.08 kB	✓
hooks.module.js gzip	370 B	370 B	✓
index.module.js gzip	212 B	212 B	✓
link.module.js gzip	1.51 kB	1.51 kB	✓
routerDirect..dule.js gzip	271 B	271 B	✓
withRouter.m..dule.js gzip	270 B	270 B	✓
Overall change	5.3 kB	5.3 kB	✓

Client Build Manifests

	zeit/next.js canary	Talbot3/next.js fix/with-mobx	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Serverless bundles

	zeit/next.js canary	Talbot3/next.js fix/with-mobx	Change
_error.js	557 kB	557 kB	✓
404.html	4.18 kB	4.18 kB	✓
hooks.html	3.81 kB	3.81 kB	✓
index.js	557 kB	557 kB	✓
link.js	594 kB	594 kB	✓
routerDirect.js	586 kB	586 kB	✓
withRouter.js	586 kB	586 kB	✓
Overall change	2.89 MB	2.89 MB	✓

lfades · 2020-04-15T21:25:57Z

Hi @Talbot3 thank you for the contribution. What are you trying to accomplish with this PR?

Talbot3 · 2020-04-16T00:59:27Z

Hi @Talbot3 thank you for the contribution. What are you trying to accomplish with this PR?
hi, I push PR for fix like this #9219. details on #11904 @lfades

lfades

@Talbot3 The changes in this PR are not ideal as all pages would become serverless functions.

Instead please do something similar to what with-mobx-state-tree currently has. Updated in #11736 . with-mobx-state-tree works with static pages, and you can optionally use getServerSideProps.

Talbot3 · 2020-04-20T04:06:57Z

getServerSideProps

@ Talbot3此PR中的更改并不理想，因为所有页面都将变为无服务器功能。

相反，请执行与with-mobx-state-tree当前相似的操作。已在＃11736中更新。with-mobx-state-tree适用于静态页面，您可以选择使用getServerSideProps。

had refactor for server side render

ijjk · 2020-04-20T04:13:38Z

Stats from current PR

Default Server Mode (Decrease detected ✓)

General

	zeit/next.js canary	Talbot3/next.js fix/with-mobx	Change
buildDuration	12.6s	12.7s	⚠️ +142ms
nodeModulesSize	55.6 MB	55.6 MB	✓

Page Load Tests Overall decrease ⚠️

	zeit/next.js canary	Talbot3/next.js fix/with-mobx	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.293	2.284	-0.01
/ avg req/sec	1090.28	1094.47	⚠️ +4.19
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.337	1.351	⚠️ +0.01
/error-in-render avg req/sec	1869.41	1849.96	-19.45

Client Bundles (main, webpack, commons)

	zeit/next.js canary	Talbot3/next.js fix/with-mobx	Change
main-HASH.js gzip	6.25 kB	6.25 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..5e5e.js gzip	10.3 kB	10.3 kB	✓
framework.a1..NSE.txt gzip	220 B	220 B	✓
framework.a1..NSE.txt gzip	220 B	220 B	✓
framework.HASH.js gzip	39 kB	39 kB	✓
Overall change	56.7 kB	56.7 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	Talbot3/next.js fix/with-mobx	Change
main-HASH.module.js gzip	4.79 kB	4.79 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	6.85 kB	6.85 kB	✓
framework.HA..dule.js gzip	39 kB	39 kB	✓
Overall change	51.4 kB	51.4 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	Talbot3/next.js fix/with-mobx	Change
polyfills-HASH.js gzip	26.2 kB	26.2 kB	✓
Overall change	26.2 kB	26.2 kB	✓

Client Pages

	zeit/next.js canary	Talbot3/next.js fix/with-mobx	Change
_app.js gzip	1.23 kB	1.23 kB	✓
_error.js gzip	3.12 kB	3.12 kB	✓
hooks.js gzip	663 B	663 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.06 kB	2.06 kB	✓
routerDirect.js gzip	280 B	280 B	✓
withRouter.js gzip	278 B	278 B	✓
Overall change	7.85 kB	7.85 kB	✓

Client Pages Modern

	zeit/next.js canary	Talbot3/next.js fix/with-mobx	Change
_app.module.js gzip	598 B	598 B	✓
_error.module.js gzip	2.09 kB	2.09 kB	✓
hooks.module.js gzip	383 B	383 B	✓
index.module.js gzip	223 B	223 B	✓
link.module.js gzip	1.52 kB	1.52 kB	✓
routerDirect..dule.js gzip	279 B	279 B	✓
withRouter.m..dule.js gzip	278 B	278 B	✓
Overall change	5.37 kB	5.37 kB	✓

Client Build Manifests

	zeit/next.js canary	Talbot3/next.js fix/with-mobx	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Rendered Page Sizes

	zeit/next.js canary	Talbot3/next.js fix/with-mobx	Change
index.html gzip	928 B	928 B	✓
link.html gzip	938 B	938 B	✓
withRouter.html gzip	926 B	926 B	✓
Overall change	2.79 kB	2.79 kB	✓

Serverless Mode

General

	zeit/next.js canary	Talbot3/next.js fix/with-mobx	Change
buildDuration	13.8s	13.7s	-63ms
nodeModulesSize	55.6 MB	55.6 MB	✓

Client Bundles (main, webpack, commons)

	zeit/next.js canary	Talbot3/next.js fix/with-mobx	Change
main-HASH.js gzip	6.25 kB	6.25 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..5e5e.js gzip	10.3 kB	10.3 kB	✓
framework.a1..NSE.txt gzip	220 B	220 B	✓
framework.a1..NSE.txt gzip	220 B	220 B	✓
framework.HASH.js gzip	39 kB	39 kB	✓
Overall change	56.7 kB	56.7 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	Talbot3/next.js fix/with-mobx	Change
main-HASH.module.js gzip	4.79 kB	4.79 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	6.85 kB	6.85 kB	✓
framework.HA..dule.js gzip	39 kB	39 kB	✓
Overall change	51.4 kB	51.4 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	Talbot3/next.js fix/with-mobx	Change
polyfills-HASH.js gzip	26.2 kB	26.2 kB	✓
Overall change	26.2 kB	26.2 kB	✓

Client Pages

	zeit/next.js canary	Talbot3/next.js fix/with-mobx	Change
_app.js gzip	1.23 kB	1.23 kB	✓
_error.js gzip	3.12 kB	3.12 kB	✓
hooks.js gzip	663 B	663 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.06 kB	2.06 kB	✓
routerDirect.js gzip	280 B	280 B	✓
withRouter.js gzip	278 B	278 B	✓
Overall change	7.85 kB	7.85 kB	✓

Client Pages Modern

	zeit/next.js canary	Talbot3/next.js fix/with-mobx	Change
_app.module.js gzip	598 B	598 B	✓
_error.module.js gzip	2.09 kB	2.09 kB	✓
hooks.module.js gzip	383 B	383 B	✓
index.module.js gzip	223 B	223 B	✓
link.module.js gzip	1.52 kB	1.52 kB	✓
routerDirect..dule.js gzip	279 B	279 B	✓
withRouter.m..dule.js gzip	278 B	278 B	✓
Overall change	5.37 kB	5.37 kB	✓

Client Build Manifests

	zeit/next.js canary	Talbot3/next.js fix/with-mobx	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Serverless bundles

	zeit/next.js canary	Talbot3/next.js fix/with-mobx	Change
_error.js	558 kB	558 kB	✓
404.html	4.18 kB	4.18 kB	✓
hooks.html	3.81 kB	3.81 kB	✓
index.js	558 kB	558 kB	✓
link.js	595 kB	595 kB	✓
routerDirect.js	587 kB	587 kB	✓
withRouter.js	587 kB	587 kB	✓
Overall change	2.89 MB	2.89 MB	✓

ijjk · 2020-04-20T04:14:06Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General

	zeit/next.js canary	Talbot3/next.js fix/with-mobx	Change
buildDuration	12.6s	12.9s	⚠️ +323ms
nodeModulesSize	55.6 MB	55.6 MB	✓

Page Load Tests Overall increase ✓

	zeit/next.js canary	Talbot3/next.js fix/with-mobx	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.326	2.372	⚠️ +0.05
/ avg req/sec	1074.86	1053.8	-21.06
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.49	1.428	-0.06
/error-in-render avg req/sec	1677.61	1750.27	⚠️ +72.66

Client Bundles (main, webpack, commons)

	zeit/next.js canary	Talbot3/next.js fix/with-mobx	Change
main-HASH.js gzip	6.25 kB	6.25 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..5e5e.js gzip	10.3 kB	10.3 kB	✓
framework.a1..NSE.txt gzip	220 B	220 B	✓
framework.a1..NSE.txt gzip	220 B	220 B	✓
framework.HASH.js gzip	39 kB	39 kB	✓
Overall change	56.7 kB	56.7 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	Talbot3/next.js fix/with-mobx	Change
main-HASH.module.js gzip	4.79 kB	4.79 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	6.85 kB	6.85 kB	✓
framework.HA..dule.js gzip	39 kB	39 kB	✓
Overall change	51.4 kB	51.4 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	Talbot3/next.js fix/with-mobx	Change
polyfills-HASH.js gzip	26.2 kB	26.2 kB	✓
Overall change	26.2 kB	26.2 kB	✓

Client Pages

	zeit/next.js canary	Talbot3/next.js fix/with-mobx	Change
_app.js gzip	1.23 kB	1.23 kB	✓
_error.js gzip	3.12 kB	3.12 kB	✓
hooks.js gzip	663 B	663 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.06 kB	2.06 kB	✓
routerDirect.js gzip	280 B	280 B	✓
withRouter.js gzip	278 B	278 B	✓
Overall change	7.85 kB	7.85 kB	✓

Client Pages Modern

	zeit/next.js canary	Talbot3/next.js fix/with-mobx	Change
_app.module.js gzip	598 B	598 B	✓
_error.module.js gzip	2.09 kB	2.09 kB	✓
hooks.module.js gzip	383 B	383 B	✓
index.module.js gzip	223 B	223 B	✓
link.module.js gzip	1.52 kB	1.52 kB	✓
routerDirect..dule.js gzip	279 B	279 B	✓
withRouter.m..dule.js gzip	278 B	278 B	✓
Overall change	5.37 kB	5.37 kB	✓

Client Build Manifests

	zeit/next.js canary	Talbot3/next.js fix/with-mobx	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Rendered Page Sizes

	zeit/next.js canary	Talbot3/next.js fix/with-mobx	Change
index.html gzip	928 B	928 B	✓
link.html gzip	938 B	938 B	✓
withRouter.html gzip	926 B	926 B	✓
Overall change	2.79 kB	2.79 kB	✓

Serverless Mode

General

	zeit/next.js canary	Talbot3/next.js fix/with-mobx	Change
buildDuration	13.3s	13.1s	-173ms
nodeModulesSize	55.6 MB	55.6 MB	✓

Client Bundles (main, webpack, commons)

	zeit/next.js canary	Talbot3/next.js fix/with-mobx	Change
main-HASH.js gzip	6.25 kB	6.25 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..5e5e.js gzip	10.3 kB	10.3 kB	✓
framework.a1..NSE.txt gzip	220 B	220 B	✓
framework.a1..NSE.txt gzip	220 B	220 B	✓
framework.HASH.js gzip	39 kB	39 kB	✓
Overall change	56.7 kB	56.7 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	Talbot3/next.js fix/with-mobx	Change
main-HASH.module.js gzip	4.79 kB	4.79 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	6.85 kB	6.85 kB	✓
framework.HA..dule.js gzip	39 kB	39 kB	✓
Overall change	51.4 kB	51.4 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	Talbot3/next.js fix/with-mobx	Change
polyfills-HASH.js gzip	26.2 kB	26.2 kB	✓
Overall change	26.2 kB	26.2 kB	✓

Client Pages

	zeit/next.js canary	Talbot3/next.js fix/with-mobx	Change
_app.js gzip	1.23 kB	1.23 kB	✓
_error.js gzip	3.12 kB	3.12 kB	✓
hooks.js gzip	663 B	663 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.06 kB	2.06 kB	✓
routerDirect.js gzip	280 B	280 B	✓
withRouter.js gzip	278 B	278 B	✓
Overall change	7.85 kB	7.85 kB	✓

Client Pages Modern

	zeit/next.js canary	Talbot3/next.js fix/with-mobx	Change
_app.module.js gzip	598 B	598 B	✓
_error.module.js gzip	2.09 kB	2.09 kB	✓
hooks.module.js gzip	383 B	383 B	✓
index.module.js gzip	223 B	223 B	✓
link.module.js gzip	1.52 kB	1.52 kB	✓
routerDirect..dule.js gzip	279 B	279 B	✓
withRouter.m..dule.js gzip	278 B	278 B	✓
Overall change	5.37 kB	5.37 kB	✓

Client Build Manifests

	zeit/next.js canary	Talbot3/next.js fix/with-mobx	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Serverless bundles

	zeit/next.js canary	Talbot3/next.js fix/with-mobx	Change
_error.js	558 kB	558 kB	✓
404.html	4.18 kB	4.18 kB	✓
hooks.html	3.81 kB	3.81 kB	✓
index.js	558 kB	558 kB	✓
link.js	595 kB	595 kB	✓
routerDirect.js	587 kB	587 kB	✓
withRouter.js	587 kB	587 kB	✓
Overall change	2.89 MB	2.89 MB	✓

lfades

Hi @Talbot3 Thank you for the PR!. I've made some changes to make it more consistent with the other mobx examples and it's now looking great!

wangcheng added 3 commits April 15, 2020 12:22

fix: with-mobx

62c1c37

refactor: up link

27d53e0

refactor: npm run prettier-fix

0b162d6

Talbot3 requested review from lfades and Timer as code owners April 15, 2020 05:00

Merge branch 'canary' into fix/with-mobx

5fe8965

Timer added the examples Issue was opened via the examples template. label Apr 15, 2020

lfades requested changes Apr 17, 2020

View reviewed changes

wangcheng and others added 2 commits April 20, 2020 12:05

refactor: server side render

c0cf05f

Merge branch 'canary' into fix/with-mobx

af1bf77

Talbot3 requested a review from lfades April 20, 2020 04:07

Luis Alvarez added 2 commits April 20, 2020 11:58

Updated store implementation and pages

f40188a

Updated readme

437a1f0

lfades approved these changes Apr 20, 2020

View reviewed changes

lfades merged commit 5592e64 into vercel:canary Apr 20, 2020

lfades changed the title ~~Fix with mobx~~ [Examples] Fix with mobx Apr 20, 2020

This was referenced May 1, 2020

[Snyk] Upgrade next from 9.3.5 to 9.3.6 anephenix/ui#7

Closed

[Snyk] Upgrade next from 9.3.5 to 9.3.6 nrako/nrako.com#72

Closed

vercel locked as resolved and limited conversation to collaborators Jan 31, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Examples] Fix with mobx #11907

[Examples] Fix with mobx #11907

Talbot3 commented Apr 15, 2020 •

edited

Loading

ijjk commented Apr 15, 2020

ijjk commented Apr 15, 2020

ijjk commented Apr 15, 2020

lfades commented Apr 15, 2020 •

edited

Loading

Talbot3 commented Apr 16, 2020 •

edited

Loading

lfades left a comment

Talbot3 commented Apr 20, 2020

ijjk commented Apr 20, 2020

ijjk commented Apr 20, 2020

lfades left a comment

[Examples] Fix with mobx #11907

[Examples] Fix with mobx #11907

Conversation

Talbot3 commented Apr 15, 2020 • edited Loading

ijjk commented Apr 15, 2020

Stats from current PR

ijjk commented Apr 15, 2020

Stats from current PR

ijjk commented Apr 15, 2020

Stats from current PR

lfades commented Apr 15, 2020 • edited Loading

Talbot3 commented Apr 16, 2020 • edited Loading

lfades left a comment

Choose a reason for hiding this comment

Talbot3 commented Apr 20, 2020

ijjk commented Apr 20, 2020

Stats from current PR

ijjk commented Apr 20, 2020

Stats from current PR

lfades left a comment

Choose a reason for hiding this comment

Talbot3 commented Apr 15, 2020 •

edited

Loading

lfades commented Apr 15, 2020 •

edited

Loading

Talbot3 commented Apr 16, 2020 •

edited

Loading