Add initial configuration changes for webpack 5 #11917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: Zack Jackson <zackary.l.jackson@gmail.com>
Co-Authored-By: Zack Jackson <zackary.l.jackson@gmail.com>
Co-Authored-By: Zack Jackson <zackary.l.jackson@gmail.com>
Co-Authored-By: Zack Jackson <zackary.l.jackson@gmail.com>
Co-Authored-By: Zack Jackson <zackary.l.jackson@gmail.com>
Co-Authored-By: Zack Jackson <zackary.l.jackson@gmail.com>
Co-Authored-By: Zack Jackson <zackary.l.jackson@gmail.com>
Co-Authored-By: Zack Jackson <zackary.l.jackson@gmail.com>
Timer
approved these changes
Apr 15, 2020
ijjk
reviewed
Apr 15, 2020
| if (isWebpack5 && !isServer) { | ||
| webpackConfig.output!.library = webpackConfig.output?.library | ||
| ? webpackConfig.output.library | ||
| : 'INTERNAL_NEXT_APP' |
This was referenced May 1, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've pulled out a bunch of the changes from https://github.com/zeit/next.js/pull/10885/files in order to land them early.
This helps with avoiding merge conflicts further down the road. Also managed to optimize a few bits like the IgnorePlugin.
Thanks to @ScriptedAlchemy, I've done all the commits marking you as co-authored-by 👍