Update HMR Client Runtime #11977

Timer · 2020-04-17T17:11:01Z

This pull request:

Pulls in the latest changes from Create React App's HMR client
Updates the typeChecked event handling for improved reliability (should make the TypeScript HMR tests stop failing)

Let's see if all of our HMR tests pass 🤞!

ijjk · 2020-04-17T17:17:15Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General Overall increase ⚠️

	zeit/next.js canary	Timer/next.js update/hot-dev-client	Change
buildDuration	10.8s	10.5s	-226ms
nodeModulesSize	55.5 MB	55.5 MB	⚠️ +351 B

Page Load Tests Overall increase ✓

	zeit/next.js canary	Timer/next.js update/hot-dev-client	Change
/ failed reqs	0	0	✓
/ total time (seconds)	1.851	1.798	-0.05
/ avg req/sec	1350.94	1390.47	⚠️ +39.53
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	0.943	0.946	0
/error-in-render avg req/sec	2650	2643.2	-6.8

Client Bundles (main, webpack, commons)

	zeit/next.js canary	Timer/next.js update/hot-dev-client	Change
main-HASH.js gzip	6.25 kB	6.25 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..5e5e.js gzip	10.3 kB	10.3 kB	✓
framework.a1..NSE.txt gzip	220 B	220 B	✓
framework.a1..NSE.txt gzip	220 B	220 B	✓
framework.HASH.js gzip	39 kB	39 kB	✓
Overall change	56.7 kB	56.7 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	Timer/next.js update/hot-dev-client	Change
main-HASH.module.js gzip	4.79 kB	4.79 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	6.85 kB	6.85 kB	✓
framework.HA..dule.js gzip	39 kB	39 kB	✓
Overall change	51.4 kB	51.4 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	Timer/next.js update/hot-dev-client	Change
polyfills-HASH.js gzip	26.2 kB	26.2 kB	✓
Overall change	26.2 kB	26.2 kB	✓

Client Pages

	zeit/next.js canary	Timer/next.js update/hot-dev-client	Change
_app.js gzip	1.24 kB	1.24 kB	✓
_error.js gzip	3.12 kB	3.12 kB	✓
hooks.js gzip	664 B	664 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.06 kB	2.06 kB	✓
routerDirect.js gzip	279 B	279 B	✓
withRouter.js gzip	278 B	278 B	✓
Overall change	7.86 kB	7.86 kB	✓

Client Pages Modern

	zeit/next.js canary	Timer/next.js update/hot-dev-client	Change
_app.module.js gzip	602 B	602 B	✓
_error.module.js gzip	2.09 kB	2.09 kB	✓
hooks.module.js gzip	383 B	383 B	✓
index.module.js gzip	223 B	223 B	✓
link.module.js gzip	1.52 kB	1.52 kB	✓
routerDirect..dule.js gzip	281 B	281 B	✓
withRouter.m..dule.js gzip	278 B	278 B	✓
Overall change	5.38 kB	5.38 kB	✓

Client Build Manifests

	zeit/next.js canary	Timer/next.js update/hot-dev-client	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Rendered Page Sizes

	zeit/next.js canary	Timer/next.js update/hot-dev-client	Change
index.html gzip	929 B	929 B	✓
link.html gzip	938 B	938 B	✓
withRouter.html gzip	927 B	927 B	✓
Overall change	2.79 kB	2.79 kB	✓

Serverless Mode

General Overall increase ⚠️

	zeit/next.js canary	Timer/next.js update/hot-dev-client	Change
buildDuration	12s	12s	-19ms
nodeModulesSize	55.5 MB	55.5 MB	⚠️ +351 B

Client Bundles (main, webpack, commons)

	zeit/next.js canary	Timer/next.js update/hot-dev-client	Change
main-HASH.js gzip	6.25 kB	6.25 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..5e5e.js gzip	10.3 kB	10.3 kB	✓
framework.a1..NSE.txt gzip	220 B	220 B	✓
framework.a1..NSE.txt gzip	220 B	220 B	✓
framework.HASH.js gzip	39 kB	39 kB	✓
Overall change	56.7 kB	56.7 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	Timer/next.js update/hot-dev-client	Change
main-HASH.module.js gzip	4.79 kB	4.79 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	6.85 kB	6.85 kB	✓
framework.HA..dule.js gzip	39 kB	39 kB	✓
Overall change	51.4 kB	51.4 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	Timer/next.js update/hot-dev-client	Change
polyfills-HASH.js gzip	26.2 kB	26.2 kB	✓
Overall change	26.2 kB	26.2 kB	✓

Client Pages

	zeit/next.js canary	Timer/next.js update/hot-dev-client	Change
_app.js gzip	1.24 kB	1.24 kB	✓
_error.js gzip	3.12 kB	3.12 kB	✓
hooks.js gzip	664 B	664 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.06 kB	2.06 kB	✓
routerDirect.js gzip	279 B	279 B	✓
withRouter.js gzip	278 B	278 B	✓
Overall change	7.86 kB	7.86 kB	✓

Client Pages Modern

	zeit/next.js canary	Timer/next.js update/hot-dev-client	Change
_app.module.js gzip	602 B	602 B	✓
_error.module.js gzip	2.09 kB	2.09 kB	✓
hooks.module.js gzip	383 B	383 B	✓
index.module.js gzip	223 B	223 B	✓
link.module.js gzip	1.52 kB	1.52 kB	✓
routerDirect..dule.js gzip	281 B	281 B	✓
withRouter.m..dule.js gzip	278 B	278 B	✓
Overall change	5.38 kB	5.38 kB	✓

Client Build Manifests

	zeit/next.js canary	Timer/next.js update/hot-dev-client	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Serverless bundles

	zeit/next.js canary	Timer/next.js update/hot-dev-client	Change
_error.js	558 kB	558 kB	✓
404.html	4.18 kB	4.18 kB	✓
hooks.html	3.81 kB	3.81 kB	✓
index.js	558 kB	558 kB	✓
link.js	594 kB	594 kB	✓
routerDirect.js	587 kB	587 kB	✓
withRouter.js	587 kB	587 kB	✓
Overall change	2.89 MB	2.89 MB	✓

ijjk · 2020-04-17T17:23:33Z

Failing test suites

test/integration/typescript-hmr/test/index.test.js

TypeScript HMR > should recover from a type error

Expand output

● TypeScript HMR › should recover from a type error

TIMED OUT: /success/

fail

  336 |     }
  337 |     console.error('TIMED OUT CHECK: ', { regex, content })
> 338 |     throw new Error('TIMED OUT: ' + regex + '\n\n' + content)
      |           ^
  339 |   }, 1000 * 30)
  340 |   while (!found) {
  341 |     try {

  at Timeout._onTimeout (lib/next-test-utils.js:338:11)

ijjk · 2020-04-17T18:54:46Z

Stats from current PR

Default Server Mode (Decrease detected ✓)

General Overall increase ⚠️

	zeit/next.js canary	Timer/next.js update/hot-dev-client	Change
buildDuration	10.2s	10.4s	⚠️ +239ms
nodeModulesSize	55.5 MB	55.5 MB	⚠️ +626 B

Page Load Tests Overall decrease ⚠️

	zeit/next.js canary	Timer/next.js update/hot-dev-client	Change
/ failed reqs	0	0	✓
/ total time (seconds)	1.7	1.755	⚠️ +0.05
/ avg req/sec	1470.51	1424.45	-46.06
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	0.893	0.91	⚠️ +0.02
/error-in-render avg req/sec	2799.39	2745.77	-53.62

Client Bundles (main, webpack, commons)

	zeit/next.js canary	Timer/next.js update/hot-dev-client	Change
main-HASH.js gzip	6.25 kB	6.25 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..5e5e.js gzip	10.3 kB	10.3 kB	✓
framework.a1..NSE.txt gzip	220 B	220 B	✓
framework.a1..NSE.txt gzip	220 B	220 B	✓
framework.HASH.js gzip	39 kB	39 kB	✓
Overall change	56.7 kB	56.7 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	Timer/next.js update/hot-dev-client	Change
main-HASH.module.js gzip	4.79 kB	4.79 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	6.85 kB	6.85 kB	✓
framework.HA..dule.js gzip	39 kB	39 kB	✓
Overall change	51.4 kB	51.4 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	Timer/next.js update/hot-dev-client	Change
polyfills-HASH.js gzip	26.2 kB	26.2 kB	✓
Overall change	26.2 kB	26.2 kB	✓

Client Pages

	zeit/next.js canary	Timer/next.js update/hot-dev-client	Change
_app.js gzip	1.24 kB	1.24 kB	✓
_error.js gzip	3.12 kB	3.12 kB	✓
hooks.js gzip	664 B	664 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.06 kB	2.06 kB	✓
routerDirect.js gzip	279 B	279 B	✓
withRouter.js gzip	278 B	278 B	✓
Overall change	7.86 kB	7.86 kB	✓

Client Pages Modern

	zeit/next.js canary	Timer/next.js update/hot-dev-client	Change
_app.module.js gzip	602 B	602 B	✓
_error.module.js gzip	2.09 kB	2.09 kB	✓
hooks.module.js gzip	383 B	383 B	✓
index.module.js gzip	223 B	223 B	✓
link.module.js gzip	1.52 kB	1.52 kB	✓
routerDirect..dule.js gzip	281 B	281 B	✓
withRouter.m..dule.js gzip	278 B	278 B	✓
Overall change	5.38 kB	5.38 kB	✓

Client Build Manifests

	zeit/next.js canary	Timer/next.js update/hot-dev-client	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Rendered Page Sizes

	zeit/next.js canary	Timer/next.js update/hot-dev-client	Change
index.html gzip	929 B	929 B	✓
link.html gzip	938 B	938 B	✓
withRouter.html gzip	927 B	927 B	✓
Overall change	2.79 kB	2.79 kB	✓

Serverless Mode

General Overall increase ⚠️

	zeit/next.js canary	Timer/next.js update/hot-dev-client	Change
buildDuration	11s	11.4s	⚠️ +401ms
nodeModulesSize	55.5 MB	55.5 MB	⚠️ +626 B

Client Bundles (main, webpack, commons)

	zeit/next.js canary	Timer/next.js update/hot-dev-client	Change
main-HASH.js gzip	6.25 kB	6.25 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..5e5e.js gzip	10.3 kB	10.3 kB	✓
framework.a1..NSE.txt gzip	220 B	220 B	✓
framework.a1..NSE.txt gzip	220 B	220 B	✓
framework.HASH.js gzip	39 kB	39 kB	✓
Overall change	56.7 kB	56.7 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	Timer/next.js update/hot-dev-client	Change
main-HASH.module.js gzip	4.79 kB	4.79 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	6.85 kB	6.85 kB	✓
framework.HA..dule.js gzip	39 kB	39 kB	✓
Overall change	51.4 kB	51.4 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	Timer/next.js update/hot-dev-client	Change
polyfills-HASH.js gzip	26.2 kB	26.2 kB	✓
Overall change	26.2 kB	26.2 kB	✓

Client Pages

	zeit/next.js canary	Timer/next.js update/hot-dev-client	Change
_app.js gzip	1.24 kB	1.24 kB	✓
_error.js gzip	3.12 kB	3.12 kB	✓
hooks.js gzip	664 B	664 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.06 kB	2.06 kB	✓
routerDirect.js gzip	279 B	279 B	✓
withRouter.js gzip	278 B	278 B	✓
Overall change	7.86 kB	7.86 kB	✓

Client Pages Modern

	zeit/next.js canary	Timer/next.js update/hot-dev-client	Change
_app.module.js gzip	602 B	602 B	✓
_error.module.js gzip	2.09 kB	2.09 kB	✓
hooks.module.js gzip	383 B	383 B	✓
index.module.js gzip	223 B	223 B	✓
link.module.js gzip	1.52 kB	1.52 kB	✓
routerDirect..dule.js gzip	281 B	281 B	✓
withRouter.m..dule.js gzip	278 B	278 B	✓
Overall change	5.38 kB	5.38 kB	✓

Client Build Manifests

	zeit/next.js canary	Timer/next.js update/hot-dev-client	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Serverless bundles

	zeit/next.js canary	Timer/next.js update/hot-dev-client	Change
_error.js	558 kB	558 kB	✓
404.html	4.18 kB	4.18 kB	✓
hooks.html	3.81 kB	3.81 kB	✓
index.js	558 kB	558 kB	✓
link.js	594 kB	594 kB	✓
routerDirect.js	587 kB	587 kB	✓
withRouter.js	587 kB	587 kB	✓
Overall change	2.89 MB	2.89 MB	✓

ijjk · 2020-04-17T18:55:40Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General Overall increase ⚠️

	zeit/next.js canary	Timer/next.js update/hot-dev-client	Change
buildDuration	12.7s	13.1s	⚠️ +405ms
nodeModulesSize	55.5 MB	55.5 MB	⚠️ +626 B

Page Load Tests Overall increase ✓

	zeit/next.js canary	Timer/next.js update/hot-dev-client	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.209	2.229	⚠️ +0.02
/ avg req/sec	1131.56	1121.79	-9.77
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.292	1.27	-0.02
/error-in-render avg req/sec	1934.74	1968.65	⚠️ +33.91

Client Bundles (main, webpack, commons)

	zeit/next.js canary	Timer/next.js update/hot-dev-client	Change
main-HASH.js gzip	6.25 kB	6.25 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..5e5e.js gzip	10.3 kB	10.3 kB	✓
framework.a1..NSE.txt gzip	220 B	220 B	✓
framework.a1..NSE.txt gzip	220 B	220 B	✓
framework.HASH.js gzip	39 kB	39 kB	✓
Overall change	56.7 kB	56.7 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	Timer/next.js update/hot-dev-client	Change
main-HASH.module.js gzip	4.79 kB	4.79 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	6.85 kB	6.85 kB	✓
framework.HA..dule.js gzip	39 kB	39 kB	✓
Overall change	51.4 kB	51.4 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	Timer/next.js update/hot-dev-client	Change
polyfills-HASH.js gzip	26.2 kB	26.2 kB	✓
Overall change	26.2 kB	26.2 kB	✓

Client Pages

	zeit/next.js canary	Timer/next.js update/hot-dev-client	Change
_app.js gzip	1.24 kB	1.24 kB	✓
_error.js gzip	3.12 kB	3.12 kB	✓
hooks.js gzip	664 B	664 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.06 kB	2.06 kB	✓
routerDirect.js gzip	279 B	279 B	✓
withRouter.js gzip	278 B	278 B	✓
Overall change	7.86 kB	7.86 kB	✓

Client Pages Modern

	zeit/next.js canary	Timer/next.js update/hot-dev-client	Change
_app.module.js gzip	602 B	602 B	✓
_error.module.js gzip	2.09 kB	2.09 kB	✓
hooks.module.js gzip	383 B	383 B	✓
index.module.js gzip	223 B	223 B	✓
link.module.js gzip	1.52 kB	1.52 kB	✓
routerDirect..dule.js gzip	281 B	281 B	✓
withRouter.m..dule.js gzip	278 B	278 B	✓
Overall change	5.38 kB	5.38 kB	✓

Client Build Manifests

	zeit/next.js canary	Timer/next.js update/hot-dev-client	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Rendered Page Sizes

	zeit/next.js canary	Timer/next.js update/hot-dev-client	Change
index.html gzip	929 B	929 B	✓
link.html gzip	938 B	938 B	✓
withRouter.html gzip	927 B	927 B	✓
Overall change	2.79 kB	2.79 kB	✓

Serverless Mode

General Overall increase ⚠️

	zeit/next.js canary	Timer/next.js update/hot-dev-client	Change
buildDuration	13.8s	13.7s	-31ms
nodeModulesSize	55.5 MB	55.5 MB	⚠️ +626 B

Client Bundles (main, webpack, commons)

	zeit/next.js canary	Timer/next.js update/hot-dev-client	Change
main-HASH.js gzip	6.25 kB	6.25 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..5e5e.js gzip	10.3 kB	10.3 kB	✓
framework.a1..NSE.txt gzip	220 B	220 B	✓
framework.a1..NSE.txt gzip	220 B	220 B	✓
framework.HASH.js gzip	39 kB	39 kB	✓
Overall change	56.7 kB	56.7 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	Timer/next.js update/hot-dev-client	Change
main-HASH.module.js gzip	4.79 kB	4.79 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	6.85 kB	6.85 kB	✓
framework.HA..dule.js gzip	39 kB	39 kB	✓
Overall change	51.4 kB	51.4 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	Timer/next.js update/hot-dev-client	Change
polyfills-HASH.js gzip	26.2 kB	26.2 kB	✓
Overall change	26.2 kB	26.2 kB	✓

Client Pages

	zeit/next.js canary	Timer/next.js update/hot-dev-client	Change
_app.js gzip	1.24 kB	1.24 kB	✓
_error.js gzip	3.12 kB	3.12 kB	✓
hooks.js gzip	664 B	664 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.06 kB	2.06 kB	✓
routerDirect.js gzip	279 B	279 B	✓
withRouter.js gzip	278 B	278 B	✓
Overall change	7.86 kB	7.86 kB	✓

Client Pages Modern

	zeit/next.js canary	Timer/next.js update/hot-dev-client	Change
_app.module.js gzip	602 B	602 B	✓
_error.module.js gzip	2.09 kB	2.09 kB	✓
hooks.module.js gzip	383 B	383 B	✓
index.module.js gzip	223 B	223 B	✓
link.module.js gzip	1.52 kB	1.52 kB	✓
routerDirect..dule.js gzip	281 B	281 B	✓
withRouter.m..dule.js gzip	278 B	278 B	✓
Overall change	5.38 kB	5.38 kB	✓

Client Build Manifests

	zeit/next.js canary	Timer/next.js update/hot-dev-client	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Serverless bundles

	zeit/next.js canary	Timer/next.js update/hot-dev-client	Change
_error.js	558 kB	558 kB	✓
404.html	4.18 kB	4.18 kB	✓
hooks.html	3.81 kB	3.81 kB	✓
index.js	558 kB	558 kB	✓
link.js	594 kB	594 kB	✓
routerDirect.js	587 kB	587 kB	✓
withRouter.js	587 kB	587 kB	✓
Overall change	2.89 MB	2.89 MB	✓

ijjk · 2020-04-17T19:00:53Z

packages/next/client/dev/error-overlay/hot-dev-client.js

-      }
-    )
-    if (updatedModules) {
+  module.hot.check(/* autoApply */ true).then(


Should we update the above link with latest https://webpack.js.org/api/hot-module-replacement/#check current one redirects to home page of webpack.js.org after 3 seconds

packages/next/client/dev/error-overlay/hot-dev-client.js

Timer added the Type: Enhancement label Apr 17, 2020

Timer added this to the 9.3.6 milestone Apr 17, 2020

Timer requested review from ijjk, lfades and timneutkens as code owners April 17, 2020 17:11

Timer added 3 commits April 17, 2020 14:48

Update HMR Client Runtime

2c19281

Increment event when building or different state

166f039

Dismiss Old Type-Only Overlay

bdb75f4

Timer force-pushed the update/hot-dev-client branch from cbe59d1 to bdb75f4 Compare April 17, 2020 18:48

ijjk reviewed Apr 17, 2020

View reviewed changes

Timer commented Apr 17, 2020

View reviewed changes

packages/next/client/dev/error-overlay/hot-dev-client.js Outdated Show resolved Hide resolved

ijjk approved these changes Apr 17, 2020

View reviewed changes

Update packages/next/client/dev/error-overlay/hot-dev-client.js

11a2233

Timer merged commit 09e3884 into vercel:canary Apr 17, 2020

Timer deleted the update/hot-dev-client branch April 17, 2020 19:24

This was referenced May 1, 2020

[Snyk] Upgrade next from 9.3.5 to 9.3.6 anephenix/ui#7

Closed

[Snyk] Upgrade next from 9.3.5 to 9.3.6 nrako/nrako.com#72

Closed

vercel locked as resolved and limited conversation to collaborators Jan 31, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update HMR Client Runtime #11977

Update HMR Client Runtime #11977

Timer commented Apr 17, 2020 •

edited

Loading

ijjk commented Apr 17, 2020

ijjk commented Apr 17, 2020

ijjk commented Apr 17, 2020

ijjk commented Apr 17, 2020

ijjk Apr 17, 2020

Update HMR Client Runtime #11977

Update HMR Client Runtime #11977

Conversation

Timer commented Apr 17, 2020 • edited Loading

ijjk commented Apr 17, 2020

Stats from current PR

ijjk commented Apr 17, 2020

Failing test suites

ijjk commented Apr 17, 2020

Stats from current PR

ijjk commented Apr 17, 2020

Stats from current PR

ijjk Apr 17, 2020

Choose a reason for hiding this comment

Timer commented Apr 17, 2020 •

edited

Loading