Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: move current pane to new tab #196

Closed
imsnif opened this issue Feb 19, 2021 · 9 comments
Closed

Feature: move current pane to new tab #196

imsnif opened this issue Feb 19, 2021 · 9 comments
Labels
action Issues related to actions help wanted Extra attention is needed

Comments

@imsnif
Copy link
Member

imsnif commented Feb 19, 2021

Similar to the tmux break-pane command.

@imsnif imsnif added the help wanted Extra attention is needed label Feb 19, 2021
@a-kenji a-kenji added the action Issues related to actions label Apr 22, 2021
@a-kenji a-kenji mentioned this issue Apr 23, 2021
21 tasks
@Monkeyanator
Copy link

Anybody working on this one? If not I'd like to give it a try :)

@a-kenji
Copy link
Contributor

a-kenji commented Apr 25, 2021

@Monkeyanator Awesome!
Afaik, noone is working on it, so you should be free to to tackle it.
Please feel free to ask any Questions you have!

@imsnif
Copy link
Member Author

imsnif commented Jun 25, 2021

I just want to mention that I really miss this feature in my day-to-day usage of Zellij. I unfortunately don't have time to devote to it myself right now, but @Monkeyanator - if you still have time for this and I can do anything to guide or help you, I'd be happy to.

@prscoelho
Copy link
Contributor

Taking a look at this, seems like we can reuse the Tab::close_pane function by having it return the Pane, and it's good because that takes care of the shifting around of space that should happen when a pane is removed from the tab.

However I'm unsure how to go about creating a new tab with a specific Pane. We want to create a new tab with the provided layout but without any terminal panes, right?

@imsnif
Copy link
Member Author

imsnif commented Oct 4, 2021

I haven't looked deeply at the code, but to give you a direction, I'd try to create an additional constructor for Tab that would allow this (or use the builder method as something like Tab::new(..).with_pane(pane)` if you want to be more rusty).

Getting the pane from close_tab sounds promising, but I'd be a little worried about doing this every time even when we don't need it. Perhaps we can duplicate the logic somehow?

@wviana
Copy link

wviana commented Apr 14, 2023

Started using Zellij in my flow. Just missed this feature. Move a panel into its own tab.
Any updates on that?

@imsnif
Copy link
Member Author

imsnif commented Aug 2, 2023

Implemented finally! Will be released in the next version.

@imsnif imsnif closed this as completed Aug 2, 2023
@imsnif
Copy link
Member Author

imsnif commented Aug 2, 2023

Incidentally, thanks @tlinford for laying down the groundwork for this.

@utkarshgupta137
Copy link

This is not visible in the documentation, had to search github to find it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
action Issues related to actions help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

6 participants