feat(apps:update): add ability to use ZENDESK_APP_ID env var during apps:update #254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Someones we want to have seperate apps for staging and production. In these cases they will have a seperate app_id. In this change we will allow users to set the `ZENDESK_APP_ID` environment variable to specify which app_id to use. This will allow developers to set this in their CICD pipelines. Fixes: #173
anushkafka
reviewed
Aug 28, 2024
|
updated @anushkafka |
|
@yoshdog Thanks for the update, this is looking good. Have u been able to verify your use case? I can do a highlevel QA from my side to verify nothing is breaking 👍 |
anushkafka
approved these changes
Aug 29, 2024
|
all good on my side @anushkafka |
zFlabmonsta
approved these changes
Sep 2, 2024
|
General QA Approved ✅ 
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Someones we want to have seperate apps for staging and production. In these cases they will have a seperate app_id.
In this change we will allow users to set the
ZENDESK_APP_IDenvironment variable to specify which app_id to use. This will allow developers to set this in their CICD pipelines.bb2f886feat: add ability to use ZENDESK_APP_ID env var during apps:updateSomeones we want to have seperate apps for staging and production. In these cases they will have a seperate app_id.
In this change we will allow users to set the
ZENDESK_APP_IDenvironment variable to specify which app_id to use. This will allow developers to set this in their CICD pipelines.Fixes: #173
ebae091fix: type checke478264fix: remove generated code6e4e699fix: lints363ef0achore: add new unit test8f115adchore: update unit testa049683fix: lints5a412b3chore: reset mockDetail
closes: #173
Checklist