Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RACK LIVERELOAD SCHEME/ Theme reload issue #411

Closed
ashwinkshenoy opened this issue Sep 6, 2023 · 0 comments · Fixed by #412
Closed

RACK LIVERELOAD SCHEME/ Theme reload issue #411

ashwinkshenoy opened this issue Sep 6, 2023 · 0 comments · Fixed by #412

Comments

@ashwinkshenoy
Copy link

ashwinkshenoy commented Sep 6, 2023

Hello team,

Rack livereload gem has been updated and new variable called RACK_LIVERELOAD_SCHEMA has been added to v0.5.1
Link and difference here (search for this.scheme in difference link).

Either we add the variable in file: lib/zendesk_apps_tools/theme.rb after line number 107, something like:

<script type="text/javascript">
RACK_LIVERELOAD_PORT = 4567;
RACK_LIVERELOAD_SCHEME = 'ws';
...
...

OR

we stick to version 0.3.17 as this variable is not present and ws is in the gem code file and we specify the version in zendesk_apps_tools.gemspec file.

Any new installations /upgrades to ZAT will cause this issue of theme server auto-reload breaking, when we do zat theme preview.

Hopefully we can get a fix for this!

image

@ashwinkshenoy ashwinkshenoy changed the title RACK LIVERELOAD SCHEME/ Theme reload issue issue RACK LIVERELOAD SCHEME/ Theme reload issue Sep 6, 2023
@etanxing etanxing linked a pull request Sep 7, 2023 that will close this issue
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant