Problem connecting to surgemq

[chessweb01]

I'm running an MQTT client that is able to connect to the public MQTT brokers at broker.mqtt-dashboard.com and iot.eclipse.org, but when I try to connect the client to a stand-alone surgemq broker running on my own machine it fails.

The broker runs without error messages, so I guess it is listening for connections. My client however, cannot connect.

Does anyone have an idea what might be wrong with my setup?

[chessweb01]

Figured it out:
I checked the CONNACK return code from the broker and found that it was 0x02 which means the broker rejects the client ID. The rejection is due to the regular expression against which the client ID is checked (see file surgemq/message/connect.go). It is ^[0-9a-zA-Z _]*$ which means that a client ID containing hyphens (-) will not be accepted.

Once I picked a client ID without hyphens the client connected without further issues. I wonder if there is a reason for rejecting hyphens as part of a client ID.

[wbtvc]

You can fix it like this:
message/connect.go：

clientIdRegexp = regexp.MustCompile("^[0-9a-zA-Z _\\-|]*$")