Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

samples/subsys/shell/shell_module doesn't work on qemu_x86_64 #23507

Closed
andrewboie opened this issue Mar 16, 2020 · 6 comments
Closed

samples/subsys/shell/shell_module doesn't work on qemu_x86_64 #23507

andrewboie opened this issue Mar 16, 2020 · 6 comments
Assignees
Labels
area: Shell Shell subsystem area: SMP Symmetric multiprocessing bug The issue is a bug, or the PR is fixing a bug priority: medium Medium impact/importance bug

Comments

@andrewboie
Copy link
Contributor

Describe the bug
When I run this sample under qemu_x86_64 I do not get a shell prompt.

Expected behavior
An interactive shell prompt should be available that accepts commands.

Impact
Not sure if this is a sample issue or the shell subsystem is broken in some way. Could be an issue with the x86_64 arch, or an SMP problem.

@andrewboie andrewboie added the bug The issue is a bug, or the PR is fixing a bug label Mar 16, 2020
@andrewboie
Copy link
Contributor Author

I think this is an SMP problem, the sample works fine if I set CONFIG_MP_NUM_CPUS=1

@andrewboie andrewboie added priority: medium Medium impact/importance bug area: Shell Shell subsystem area: SMP Symmetric multiprocessing labels Mar 16, 2020
@andrewboie andrewboie assigned jenmwms and unassigned jenmwms Apr 9, 2020
@jenmwms
Copy link
Collaborator

jenmwms commented Apr 13, 2020

the sample works fine if I set CONFIG_MP_NUM_CPUS=1

@andrewboie Thanks for this! Can you please help me reproduce this? I added CONFIG_MP_NUM_CPUS=1 to the prj.conf file in samples/subsys/shell/shell_module but it still hangs for me.

@jenmwms
Copy link
Collaborator

jenmwms commented Apr 16, 2020

CONFIG_MP_NUM_CPUS=1 to the prj.conf file in samples/subsys/shell/shell_module but it still hangs for me.

nvm - this works to reproduce the passing case. Not sure what happened earlier. Anyway, this issue is still on my radar.

@jenmwms
Copy link
Collaborator

jenmwms commented Apr 16, 2020

btw - I see this same behavior for qemu_x86_64 tests/drivers/uart/uart_basic_api/. The test_uart_fifo_fill fails, but works fine if I set CONFIG_MP_NUM_CPUS=1

@jenmwms
Copy link
Collaborator

jenmwms commented May 7, 2020

update here - I rebased today and this issue still occurs. However, this issue appears to be resolved with cherry-pick of #23325. Tested with west build -p -b qemu_x86_64 samples/subsys/shell/shell_module and unmodified shell_module/prj.conf.

@jenmwms
Copy link
Collaborator

jenmwms commented May 11, 2020

update here - I rebased today and this issue is resolved. Above referenced #23325 fixed it, from what I can tell.

I tested today on master 7201c1d - No modification or cherry-pick.
west build -p -b qemu_x86_64 samples/subsys/shell/shell_module

[jennife2@jennife2-desk1 zephyr]$ west build -t run
-- west build: running target run
[3/4] To exit from QEMU enter: 'CTRL+a, x'[QEMU] CPU: qemu64,+x2apic
qemu-system-x86_64: warning: TCG doesn't support requested feature: CPUID.01H:ECX.x2apic [bit 21]
qemu-system-x86_64: warning: TCG doesn't support requested feature: CPUID.01H:ECX.x2apic [bit 21]
SeaBIOS (version rel-1.12.1-0-ga5cab58-dirty-20200214_052440-f7294c49af13-zephyr
)
Booting from ROM..Optimal CONFIG_X86_MMU_PAGE_POOL_PAGES 8


uart:~$

@jenmwms jenmwms closed this as completed May 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: Shell Shell subsystem area: SMP Symmetric multiprocessing bug The issue is a bug, or the PR is fixing a bug priority: medium Medium impact/importance bug
Projects
None yet
Development

No branches or pull requests

2 participants