Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Coverity CID :208927] Dereference after null check in tests/net/icmpv4/src/main.c #23573

Closed
zephyrbot opened this issue Mar 18, 2020 · 1 comment
Assignees
Labels
area: Networking bug The issue is a bug, or the PR is fixing a bug Coverity A Coverity detected issue or its fix priority: low Low impact/importance bug

Comments

@zephyrbot
Copy link
Collaborator

Static code scan issues found in file:

https://github.com/zephyrproject-rtos/zephyr/tree/master/tests/net/icmpv4/src/main.c#L442

Category: Null pointer dereferences
Function: test_icmpv4_send_echo_req
Component: Tests
CID: 208927

Details:

436    
437         pkt = prepare_echo_request(iface);
438         if (!pkt) {
439             zassert_true(false, "EchoRequest packet prep failed");
440         }
441    
>>>     CID 208927:  Null pointer dereferences  (FORWARD_NULL)
>>>     Passing null pointer "pkt" to "net_ipv4_input", which dereferences it.
442         if (net_ipv4_input(pkt)) {
443             net_pkt_unref(pkt);
444             zassert_true(false, "Failed to send");
445         }
446     }
447    

Please fix or provide comments in coverity using the link:

https://scan9.coverity.com/reports.htm#v32951/p12996.

Note: This issue was created automatically. Priority was set based on classification
of the file affected and the impact field in coverity. Assignees were set using the CODEOWNERS file.

@zephyrbot zephyrbot added bug The issue is a bug, or the PR is fixing a bug Coverity A Coverity detected issue or its fix priority: low Low impact/importance bug labels Mar 18, 2020
@jukkar jukkar assigned rveerama1 and unassigned pfalcon, jukkar and tbursztyka Mar 18, 2020
@jukkar
Copy link
Member

jukkar commented Mar 19, 2020

false positive

@jukkar jukkar closed this as completed Mar 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: Networking bug The issue is a bug, or the PR is fixing a bug Coverity A Coverity detected issue or its fix priority: low Low impact/importance bug
Projects
None yet
Development

No branches or pull requests

5 participants