Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

driver: gpio: mchp: GPIO initialization value doesn't get reflected when using new flags #25101

Closed
albertofloyd opened this issue May 7, 2020 · 1 comment · Fixed by #25103
Assignees
Labels
area: GPIO bug The issue is a bug, or the PR is fixing a bug platform: Microchip MEC Microchip MEC Platform

Comments

@albertofloyd
Copy link
Collaborator

If GPIO is configure to have an initial value HIGH using new GPIO flags, the value doesn't reflect for mec15 boards.
This gets masked because on subsequent steps of test cases gpio_pin_set_raw() is used.

To Reproduce
Steps to reproduce the behavior:
Modify code so no calls to gpio_pin_set_raw() are done

  1. cd test/drivers/gpio
  2. west build -c -b mec15xxevb_assy6853
  3. west flash
    Check GPIO output with multimeter, it's LOW

Expected behavior
INitialization value passed as flag to GPIO, needs to reflect in physical pin after configure() operation

Impact
MEC15 board initialization may have pins erroneously configured, before they are been used and pins that only get initialized once.

@maksimmasalski
Copy link
Collaborator

maksimmasalski commented Jul 13, 2020

@albertofloyd folder tests/drivers/gpio has 2 tests folders: gpio_api_1pin and gpio_basic_api
Which one you used?
What does mean "modify code so no calls to gpio_pin_set_raw() are done", just comment out? Could you share you branch with modified test by you?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: GPIO bug The issue is a bug, or the PR is fixing a bug platform: Microchip MEC Microchip MEC Platform
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants