Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

samples: subsys: canbus: canopen: objdict: CO_OD.h is not normally made. #26363

Closed
ghost opened this issue Jun 23, 2020 · 7 comments
Closed

samples: subsys: canbus: canopen: objdict: CO_OD.h is not normally made. #26363

ghost opened this issue Jun 23, 2020 · 7 comments
Assignees
Labels
area: CAN bug The issue is a bug, or the PR is fixing a bug

Comments

@ghost
Copy link

ghost commented Jun 23, 2020

Describe the bug
The CO_OD.h file is not created normally in the Object Dictionary Editor v0.8-0-gb60f4b version. (CO_OD.h: #define CO_NO_TS 1)

To Reproduce
Steps to reproduce the behavior:

  1. Run the Object Dictionary Editor v0.8-0-gb60f4b program.
  2. Open the eds file provided by the canopen sample.
  3. Create a CO_OD.c , CO_OD.h, xml file without any further changes, and save the eds file.
  4. Place the generated CO_OD.c , CO_OD.h, and xml files in the canopen/objdict folder.
  5. cmake -DBOARD=stm32l433 .. (canopen/build)
  6. west flash

Expected behavior

(Unbuilt header files created by the editor program)
CO_OD.h: #define CO_NO_TS     1

(Header file for normal build)
CO_OD.h: #define CO_NO_TIME     1

Screenshots or console output
editor1

Environment (please complete the following information):

  • OS: Linux(Ubuntu 18.04)
  • Toolchain: Zephyr SDK 0.11.1

Additional context
I wanted to create CO_OD.c, CO_OD.h, xml files directly by opening the eds file provided by the zipper canopen sample with object logic editor.
Download the editor program from (https://github.com/robincornelius/libedssharp/releases.)
We opened the editor program to create CO_OD.c, CO_OD.h, and xml files without any additional changes.
However, an error occurred during the build because CO_NO_TIME was not defined in the CO_OD.h file.
Looking in the header file,I suspected that the

#define CO_NO_TS      1

was created incorrectly due to the difference in the version of the editor.

I wonder if there is anything else that needs to be set up in the editor program in order to be normally generated from CO_OD.h to #define CO_NO_TIME 1 or if it is due to version differences.

@ghost ghost added the bug The issue is a bug, or the PR is fixing a bug label Jun 23, 2020
@henrikbrixandersen
Copy link
Member

@wngur300 You need to use a version of libedssharp, that matches the version of CANopenNode used. This is not specific to Zephyr.

@ghost
Copy link
Author

ghost commented Jun 23, 2020

@wngur300 You need to use a version of libedssharp, that matches the version of CANopenNode used. This is not specific to Zephyr.

v0.8-7-g2e53bbc is not found at https://github.com/robincornelius/libedssharp/releases and appears to be downloadable until version v0.8-0-gb60f4. Can you tell me where I can download the version of v0.8-7-g2e53bbc? Can't I get it for free?

@henrikbrixandersen
Copy link
Member

v0.8-7-g2e53bbc is not found at https://github.com/robincornelius/libedssharp/releases and appears to be downloadable until version v0.8-0-gb60f4. Can you tell me where I can download the version of v0.8-7-g2e53bbc? Can't I get it for free?

To resolve the above issue, you will need at least robincornelius/libedssharp@07ac819 (or just manually edit the generated file to use CO_NO_TIME.

@ghost
Copy link
Author

ghost commented Jun 24, 2020

v0.8-7-g2e53bbc is not found at https://github.com/robincornelius/libedssharp/releases and appears to be downloadable until version v0.8-0-gb60f4. Can you tell me where I can download the version of v0.8-7-g2e53bbc? Can't I get it for free?

To resolve the above issue, you will need at least robincornelius/libedssharp@07ac819 (or just manually edit the generated file to use CO_NO_TIME.

Thank you!

@carlescufi
Copy link
Member

Closing as resolved.

@Qbicz
Copy link
Collaborator

Qbicz commented Mar 8, 2021

For reference (and Linux users), the latest auto-build that has this problem fixed can be downloaded from: https://github.com/robincornelius/libedssharp/raw/gh-pages/build/OpenEDSEditor-latest.zip

@Qbicz
Copy link
Collaborator

Qbicz commented Mar 8, 2021

Actually the latest version of OpenEDSEditor is also not compatible, so I opened #33149 to clarify and find a solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: CAN bug The issue is a bug, or the PR is fixing a bug
Projects
None yet
Development

No branches or pull requests

3 participants