Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capture and store values from CIS established event #31180

Closed
Thalley opened this issue Jan 8, 2021 · 1 comment · Fixed by #39586
Closed

Capture and store values from CIS established event #31180

Thalley opened this issue Jan 8, 2021 · 1 comment · Fixed by #39586
Assignees
Labels
area: Bluetooth Host area: Bluetooth ISO Bluetooth LE Isochronous Channels area: Bluetooth Enhancement Changes/Updates/Additions to existing features

Comments

@Thalley
Copy link
Collaborator

Thalley commented Jan 8, 2021

Is your enhancement proposal related to a problem? Please describe.
When the CIS established event is received from the controller, we don't use any of the value. For the Master that's okay as it set the values in the first place, but the slave need to store this in order to be able to send data (as otherwise things like the SDU size will be 0).

Describe the solution you'd like
The values should be stored in the ISO channel (perhaps only the necessary ones and perhaps only for the slave).

Describe alternatives you've considered
None

Additional context
None

See also #31179

@Thalley Thalley added the Enhancement Changes/Updates/Additions to existing features label Jan 8, 2021
@Thalley
Copy link
Collaborator Author

Thalley commented Apr 9, 2021

The parameters set in the struct bt_iso_chan_io_qos of the peripheral should probably be validated based on the parameters of this event, and trigger an automated rejection of the CIS if they are not satisfied.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: Bluetooth Host area: Bluetooth ISO Bluetooth LE Isochronous Channels area: Bluetooth Enhancement Changes/Updates/Additions to existing features
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants