Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Coverity CID :219540] Side effect in assertion in subsys/bluetooth/controller/ll_sw/ull_sched.c #32909

Closed
zephyrbot opened this issue Mar 5, 2021 · 0 comments · Fixed by #33420
Assignees
Labels
bug The issue is a bug, or the PR is fixing a bug Coverity A Coverity detected issue or its fix priority: low Low impact/importance bug

Comments

@zephyrbot
Copy link
Collaborator

Static code scan issues found in file:

https://github.com/zephyrproject-rtos/zephyr/tree/bd97359a5338b2542d19011b6d6aa1d8d1b9cc3f/subsys/bluetooth/controller/ll_sw/ull_sched.c#L366

Category: Incorrect expression
Function: win_offset_calc
Component: Bluetooth
CID: 219540

Details:

LL_ASSERT(ret_cb == TICKER_STATUS_SUCCESS);

360                 while (ret_cb == TICKER_STATUS_BUSY) {
361                     ticker_job_sched(TICKER_INSTANCE_ID_CTLR,
362                              TICKER_USER_ID_ULL_LOW);
363                 }
364             }
365    
>>>     CID 219540:  Incorrect expression  (ASSERT_SIDE_EFFECT)
>>>     Argument "ret_cb" of LL_ASSERT() has a side effect because the variable is volatile.  The containing function might work differently in a non-debug build.
366             LL_ASSERT(ret_cb == TICKER_STATUS_SUCCESS);
367    
368             if (ticker_id == 0xff) {
369                 break;
370             }
371    

Please fix or provide comments in coverity using the link:

https://scan9.coverity.com/reports.htm#v32951/p12996.

Note: This issue was created automatically. Priority was set based on classification
of the file affected and the impact field in coverity. Assignees were set using the CODEOWNERS file.

@zephyrbot zephyrbot added bug The issue is a bug, or the PR is fixing a bug Coverity A Coverity detected issue or its fix priority: low Low impact/importance bug labels Mar 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug The issue is a bug, or the PR is fixing a bug Coverity A Coverity detected issue or its fix priority: low Low impact/importance bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants