Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Coverity CID :219538] Illegal address computation in subsys/bluetooth/controller/ll_sw/nordic/lll/lll_adv_aux.c #32910

Closed
zephyrbot opened this issue Mar 5, 2021 · 2 comments
Assignees
Labels
bug The issue is a bug, or the PR is fixing a bug Coverity A Coverity detected issue or its fix priority: medium Medium impact/importance bug

Comments

@zephyrbot
Copy link
Collaborator

Static code scan issues found in file:

https://github.com/zephyrproject-rtos/zephyr/tree/bd97359a5338b2542d19011b6d6aa1d8d1b9cc3f/subsys/bluetooth/controller/ll_sw/nordic/lll/lll_adv_aux.c#L92

Category: Memory - corruptions
Function: init_connect_rsp_pdu
Component: Bluetooth
CID: 219538

Details:

86    
87         /* Note: AdvA and InitA are updated before transmitting PDU */
88    
89         /* AdvA */
90         dptr += BDADDR_SIZE;
91         /* InitA */
>>>     CID 219538:  Memory - corruptions  (OVERRUN)
>>>     "dptr" evaluates to an address that is at byte offset 7 of an array of 1 bytes.
92         dptr += BDADDR_SIZE;
93    
94         ext_hdr_len = dptr - (uint8_t *)&com_hdr->ext_hdr;
95    
96         /* Finish Common ExtAdv Payload header */
97         com_hdr->adv_mode = 0;

Please fix or provide comments in coverity using the link:

https://scan9.coverity.com/reports.htm#v32951/p12996.

Note: This issue was created automatically. Priority was set based on classification
of the file affected and the impact field in coverity. Assignees were set using the CODEOWNERS file.

@zephyrbot zephyrbot added bug The issue is a bug, or the PR is fixing a bug Coverity A Coverity detected issue or its fix priority: medium Medium impact/importance bug labels Mar 5, 2021
@cvinayak
Copy link
Contributor

cvinayak commented Apr 7, 2021

These are false issues, the dptr is an offset into a static PDU buffer memory in the same file with sufficient size.

@carlescufi
Copy link
Member

Marked as false positive in Coverity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug The issue is a bug, or the PR is fixing a bug Coverity A Coverity detected issue or its fix priority: medium Medium impact/importance bug
Projects
None yet
Development

No branches or pull requests

5 participants