Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Where should a few include/ headers live #32975

Closed
galak opened this issue Mar 5, 2021 · 6 comments
Closed

Where should a few include/ headers live #32975

galak opened this issue Mar 5, 2021 · 6 comments
Assignees
@nashif @jukkar @sjg20 @carlescufi
Labels
RFC Request For Comments: want input from the community

Comments

@galak
Copy link
Collaborator

galak commented Mar 5, 2021

There are a few headers in include/ that seem like they shouldn't be at the top level:

include/ec_host_cmd.h
include/emul.h
include/ptp_clock.h

Should these files still live here are be moved under some sub-dir.
@galak galak added the RFC Request For Comments: want input from the community label Mar 5, 2021
@galak
Copy link
Collaborator Author

galak commented Mar 5, 2021

@jukkar should ptp_clock.h be include/net/ptp_clock.h?

@galak
Copy link
Collaborator Author

galak commented Mar 5, 2021

@sjg20 should emul.h be include/drivers/emul.h?

@galak
Copy link
Collaborator Author

galak commented Mar 5, 2021

@sjg20 should ec_host_cmd.h be include/mgmt/ec_host_cmd.h?

@galak galak added the dev-review To be discussed in dev-review meeting label Mar 5, 2021
@jukkar
Copy link
Member

jukkar commented Mar 5, 2021

should ptp_clock.h be include/net/ptp_clock.h?

I would put that to include/drivers/ directory

@sjg20
Copy link
Collaborator

sjg20 commented Mar 5, 2021

@sjg20 should emul.h be include/drivers/emul.h?

Yes that seems fine

@sjg20
Copy link
Collaborator

sjg20 commented Mar 5, 2021

@sjg20 should ec_host_cmd.h be include/mgmt/ec_host_cmd.h?

Yes OK

@galak galak removed the dev-review To be discussed in dev-review meeting label Mar 11, 2021
@galak galak closed this as completed Mar 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nashif nashif

@jukkar jukkar

@sjg20 sjg20

@carlescufi carlescufi

Labels
RFC Request For Comments: want input from the community
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@nashif @jukkar @sjg20 @carlescufi @galak