[Coverity CID: 219729] Logically dead code in lib/os/cbprintf_packaged.c

[zephyrbot]

Static code scan issues found in file:

https://github.com/zephyrproject-rtos/zephyr/tree/b4f5b9e23770f2c9cddf95fef7b9af32da309f7f/lib/os/cbprintf_packaged.c#L379

Category: Control flow issues
Function: cbvprintf_package
Component: Other
CID: 219729

Details:

zephyr/lib/os/cbprintf_packaged.c

Line 379 in b4f5b9e

return -EFAULT;

373    
374             /* align destination buffer location */
375             buf = (void *) ROUND_UP(buf, align);
376    
377             /* Check if buffer is properly aligned. */
378             if ((uintptr_t)buf0 & (align - 1)) {
>>>     CID 219729:  Control flow issues  (DEADCODE)
>>>     Execution cannot reach this statement: "return -14;".
379                 return -EFAULT;
380             }
381    
382             /* make sure the data fits */
383             if (buf0 && buf - buf0 + size > len) {
384                 return -ENOSPC;

Please fix or provide comments in coverity using the link:

https://scan9.coverity.com/reports.htm#v29271/p12996

Note: This issue was created automatically. Priority was set based on classification
of the file affected and the impact field in coverity. Assignees were set using the CODEOWNERS file.

[npitre]

This report should be ignored.

The coverity link also gives me a 401.

Here the dead code is dead only on some architectures like x86 where the
alignment is hardcoded to 1. In this case the compiler should rightfully
optimize the dead code away. With other configurations, that code has its
purpose.