[Coverity CID: 220432] Out-of-bounds access in subsys/net/l2/ethernet/ethernet.c

[zephyrbot]

Static code scan issues found in file:

https://github.com/zephyrproject-rtos/zephyr/tree/169144afa1826511ee6ec3f53d590b2c0d39d3d4/subsys/net/l2/ethernet/ethernet.c#L1039

Category: Memory - corruptions
Function: net_eth_carrier_on
Component: Networking
CID: 220432

Details:

zephyr/subsys/net/l2/ethernet/ethernet.c

Line 1039 in 169144a

if (!atomic_test_and_set_bit(&ctx->flags, ETH_CARRIER_UP)) {

1033     }
1034    
1035     void net_eth_carrier_on(struct net_if *iface)
1036     {
1037         struct ethernet_context *ctx = net_if_l2_data(iface);
1038    
>>>     CID 220432:  Memory - corruptions  (ARRAY_VS_SINGLETON)
>>>     Passing "&ctx->flags" to function "atomic_test_and_set_bit" which uses it as an array. This might corrupt or misinterpret adjacent memory locations.
1039         if (!atomic_test_and_set_bit(&ctx->flags, ETH_CARRIER_UP)) {
1040             k_work_submit(&ctx->carrier_work);
1041         }
1042     }
1043    
1044     void net_eth_carrier_off(struct net_if *iface)

Please fix or provide comments in coverity using the link:

https://scan9.coverity.com/reports.htm#v29271/p12996

Note: This issue was created automatically. Priority was set based on classification
of the file affected and the impact field in coverity. Assignees were set using the CODEOWNERS file.

[galak]

False positive, not an issue with atomic_test_and_set