Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Coverity CID: 236015] Out-of-bounds access in tests/subsys/logging/log_api/src/mock_backend.c #35148

Closed
zephyrbot opened this issue May 11, 2021 · 0 comments · Fixed by #35201
Assignees
Labels
bug The issue is a bug, or the PR is fixing a bug Coverity A Coverity detected issue or its fix priority: low Low impact/importance bug
Milestone

Comments

@zephyrbot
Copy link
Collaborator

Static code scan issues found in file:

https://github.com/zephyrproject-rtos/zephyr/tree/0622bde3bf22926544c1aaef4c01dfa23d79f26e/tests/subsys/logging/log_api/src/mock_backend.c#L372

Category: Memory - corruptions
Function: sync_hexdump
Component: Tests
CID: 236015

Details:

zassert_equal(memcmp(data, exp->data, length), 0, NULL);

366      zassert_equal(src_level.source_id, exp->source_id, NULL);
367      zassert_equal(src_level.domain_id, exp->domain_id, NULL);
368     
369      zassert_equal(0, strcmp(metadata, exp->str), NULL);
370      zassert_equal(length, exp->data_len, NULL);
371      if (length > sizeof(exp->data)) {
>>>     CID 236015:  Memory - corruptions  (OVERRUN)
>>>     Overrunning array "exp->data" of 32 bytes by passing it to a function which accesses it at byte offset 32 using argument "length" (which evaluates to 33). [Note: The source code implementation of the function has been overridden by a builtin model.]
372              zassert_equal(memcmp(data, exp->data, length), 0, NULL);
373      }
374     }
375     
376     const struct log_backend_api mock_log_backend_api = {
377      .process = IS_ENABLED(CONFIG_LOG2) ? process : NULL,

Please fix or provide comments in coverity using the link:

https://scan9.coverity.com/reports.htm#v29271/p12996

Note: This issue was created automatically. Priority was set based on classification
of the file affected and the impact field in coverity. Assignees were set using the CODEOWNERS file.

@zephyrbot zephyrbot added bug The issue is a bug, or the PR is fixing a bug Coverity A Coverity detected issue or its fix priority: low Low impact/importance bug labels May 11, 2021
@galak galak added this to the v2.6.0 milestone May 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug The issue is a bug, or the PR is fixing a bug Coverity A Coverity detected issue or its fix priority: low Low impact/importance bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants