Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This is a fantastic plugin #67

Open
buggedcom opened this issue Nov 29, 2022 · 1 comment
Open

This is a fantastic plugin #67

buggedcom opened this issue Nov 29, 2022 · 1 comment

Comments

@buggedcom
Copy link

This has really change the way my team will develop in storybook. Honestly, it's a god-send.

I have a few feature suggestions though to improve the usability based on my experience setting it up.

  • We run storybook on a custom port, took us ages to work out why the plugin was not working. Anything other than port 6006, it seems, does not work with the zeplin API due to CORS. Therefore I suggest if it is detected that the storybook port is not 6006 and error message is show in the zeplin panel that tells the user as such.
  • The zeplin previews when overlayed in the canvas area are ever slow slightly misaligned with the canvas components, for me it is off by 6px top and 10px left. To get the previews to align properly by default would be amazing.
  • It would be amazing to see some of the code previews of the components that zeplin generates in another panel. They should be updated according to the controls in the controls panel.
  • We noticed that the short zeplin story links are not recognised but the full expanded ones are. Pattern matching could be updated to match the short links too.
  • It would be amazing to see an internal service to this to include some kind of designer sign-off functionality here, when a stage in the deployment pipelines could be added so the designers can review updates of particular branches and then somehow record that they have signed off the design. I have ideas for this but will not mention them now as there is no need unless you think it might be something you could implement.

Anyway. Fantastic plugin. Thank you.

@mertkahyaoglu
Copy link
Contributor

This issue made my day ❤️ Glad to hear that the plugin is useful for you.
Thanks for the suggestions as well. We'll definitely consider them and hopefully add them to the plugin soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants