Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exposing the parseBinary as a static method for 3rd party integrations? #99

Open
darwin403 opened this issue May 9, 2023 · 3 comments

Comments

@darwin403
Copy link

darwin403 commented May 9, 2023

Context:

The ticker.ts lib has a rather elaborate and tedious way of handling the connection which may not suite for all use cases. For starters, you cannot set/change the access_token once a connection has been estabished since the package blocks the main thread. Therefore, although it might be useful for some cases, for any serious solution we should be able to handle the connection in a more customizable fashion.

Question

Most of the library is straight forward and we've used all the necessary variables that we require from the class but apart from the parseBinary method that follows a elaborate packet convention. It would immesenly help us out if we you can expose to this function as a static method.

Happy to make a PR, once you approve @vividvilla

Thanks!
Sai

@AbhishekCS3459
Copy link

hey @darwin403, I've found the solution for this, and I plan to address it correctly by submitting a PR soon.

@AbhishekCS3459
Copy link

hey @darwin403 I am unable to generate the profile.json file when I am trying to test the code can you suggest how should I proceed?

@Jatkingmodern
Copy link

go ahead with vitest end to end testing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants