New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Identify_Frame function possible bug #57

Open

JarekC-DIY opened this issue Aug 20, 2024 · 0 comments

JarekC-DIY commented Aug 20, 2024

serum_decode.cpp
function Identify_Frame line 919
if (first_match || ti != lastfound || mask < 255)

Condition is met for each frame with a mask.
And what about the sequence:
Ex. lastfound = ID5

Hashc == hashcodes[ti]
Frame 1 ID = 99 , Crc=0XAA55AA55 frame with mask no. 7, full CRC = 0x12341234

So ti != lastfound
Now last_found = ID99 lastframe_full_crc= 0x12341234
ti != lastfound function return ti

Frame 2. same as Frame 1
so ti == lastfound but mask< 255
function return ti
and in this case the function should return IDENTIFY_SAME_FRAME

Am I interpreting this wrong?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment