[rebber] Missing dependencies in package.json

[thomasdondorf]

Just tried to give rebber a try. Looks like it is missing two dependencies in the package.json file:

• clone
• trim-lines

After manually installing them I was able to get it to run. Used version was 5.0.0.

[StaloneLab]

Hello there,

Thanks for reporting the issue, it will be solved in the next release of rebber coming soon. Feel free to ask if you have any questions about rebber or it's plugins.

[StaloneLab]

Released today: rebber@5.1.0

[thomasdondorf]

Nice, thanks for the fast feedback. Just to let you know: In the end, I didn't end up using rebber, mainly because of the missing TypeScript support. Also, I needed something to work directly on the AST.

Looks like a cool project, though :)

[artragis]

Do you know how we could support typescript?

[StaloneLab]

We need to provide typings I suppose.

[thomasdondorf]

@artragis You could either put the type definition files into your project (like Unified did it) or provide them via DefinitelyTyped. Or you switch from JavaScript to TypeScript, but I guess that's not an option ;)

[LukeCarrier]

@artragis, @TitiAlone would you accept a PR adding TypeScript declarations for remark-abbr?

[StaloneLab]

Please do; adding them to only some packages in the repo doesn't really make sense IMO, but I'm interested in seeing how typing declarations work. Do you think adding them to DefinitelyTyped would make sense, instead of adding them to this repository?

[LukeCarrier]

Awesome, I'll raise a PR for just one package for now and we can go from there. Thanks!