Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase gas limit used by ZetaClient to handle outbound revert #3143

Closed
lumtis opened this issue Nov 12, 2024 · 0 comments · Fixed by #3144
Closed

Increase gas limit used by ZetaClient to handle outbound revert #3143

lumtis opened this issue Nov 12, 2024 · 0 comments · Fixed by #3144
Assignees
@lumtis
Labels
zetaclient Issues related to ZetaClient
Milestone
Solana Integratio...

Comments

@lumtis
Copy link
Member

lumtis commented Nov 12, 2024

Describe the Issue

We use a gas limit of 4M

node/zetaclient/zetacore/constant.go

Line 50 in 467d691

PostVoteOutboundRevertGasLimit = 4_000_000

This limit should be increased because gateway upgrade add workflow where custom smart contract implement onRevert processing, that can take some amount of gas

We should use at least the same number as outbound, which is 7M
@lumtis lumtis added the zetaclient Issues related to ZetaClient label Nov 12, 2024
@lumtis lumtis self-assigned this Nov 12, 2024
@lumtis lumtis linked a pull request Nov 12, 2024 that will close this issue
fix: out of gas on ZetaClient during onRevert #3144
Merged
@coderabbitai coderabbitai bot mentioned this issue Nov 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lumtis lumtis

Labels
zetaclient Issues related to ZetaClient
Projects
None yet
Milestone
Solana Integration (planned v23)
Development

Successfully merging a pull request may close this issue.

fix: out of gas on ZetaClient during onRevert zeta-chain/node
1 participant
@lumtis