Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish a temporary @zetachain/protocol-contracts@athens3 package #38

Closed
Tracked by #37
fadeev opened this issue Jun 16, 2023 · 1 comment · Fixed by #49
Closed
Tracked by #37

Publish a temporary @zetachain/protocol-contracts@athens3 package #38

fadeev opened this issue Jun 16, 2023 · 1 comment · Fixed by #49

Comments

@fadeev
Copy link
Member

fadeev commented Jun 16, 2023

@andresaiello as there are multiple packages depending on @zetachain/protocol-contracts being ready for Athens 3, I propose the following.

Let's publish this package under an athens3 tag on npm.

This could be as simple as adding the following workflow:

https://github.com/zeta-chain/networks/blob/8613fa8406a5a739dc3318a0f98306a6b408d05d/.github/workflows/publish-npm.yaml

After this workflow is added, to publish under an athens3 tag:

  1. Create a new release
  2. Select "Create a new tag on publish" and type v1.0.0-athens3 (note the v)
  3. Click "Publish release"

Users can install this package with yarn add @zetachain/protocol-contracts@athens3.

To release a new athens3 version repeat the process above with an incremented minor or patch version, for example, v1.0.1-athens3.

To release a new stable version repeat the process above using a version without a tag, for example, v1.0.0.

Users can install this package with yarn add @zetachain/protocol-contracts.

I propose we release under athen3 as often as possible, so that other tasks can be unblocked. Right now I have to rely on a locally linked protocol-contracts package, which is much less convenient than a tagged version on npm.

@fadeev
Copy link
Member Author

fadeev commented Jun 16, 2023

Related to this, we also need to publish typechain-types and abi of contracts.

@fadeev fadeev linked a pull request Jun 25, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant