Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip extract audio when processed result existed #60

Closed
MaleicAcid opened this issue Nov 9, 2024 · 2 comments
Closed

Skip extract audio when processed result existed #60

MaleicAcid opened this issue Nov 9, 2024 · 2 comments

Comments

@MaleicAcid
Copy link
Contributor

MaleicAcid commented Nov 9, 2024

The current code will still repeat to extract audio:

class Preprocessor:
    def pre_process(self, paths, noise_suppress=False):
        for i, path in enumerate(paths):
             ...
            paths[i] = extract_audio(path)

        ...
        preprocessor = Preprocessor(paths, options=self.preprocess_options)
        paths = preprocessor.run(noise_suppress)
@MaleicAcid MaleicAcid changed the title Allow fully reuse preprocess result(include loundness normalization) Allow fully reuse preprocess result(not extract audio when processed result existed) Nov 11, 2024
@MaleicAcid MaleicAcid reopened this Nov 11, 2024
@MaleicAcid MaleicAcid changed the title Allow fully reuse preprocess result(not extract audio when processed result existed) Allow fully reuse preprocess result(skip extract audio when processed result existed) Nov 11, 2024
@MaleicAcid MaleicAcid changed the title Allow fully reuse preprocess result(skip extract audio when processed result existed) Skip extract audio when processed result existed Nov 11, 2024
@zh-plus
Copy link
Owner

zh-plus commented Nov 14, 2024

Will be fixed in the next minor release.

@zh-plus
Copy link
Owner

zh-plus commented Dec 9, 2024

Fixed in v1.6.0

@zh-plus zh-plus closed this as completed Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants