Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make logging in end2end tests more consistent #859

Open
andy-maier opened this issue Jan 9, 2024 · 0 comments
Open

Make logging in end2end tests more consistent #859

andy-maier opened this issue Jan 9, 2024 · 0 comments

Comments

@andy-maier
Copy link
Member

andy-maier commented Jan 9, 2024

The logging control knob for end2end tests is to set the TESTLOGFILE env var.

Using that variable causes some amount of logging (mainly zhmcclient) to end up in the specified log file, but there are the following issues:

  • Most end2end tests have their own LOG_FILE and DEBUG variables. LOG_FILE is passed as the 'log_file' parameter to the tested Ansible module. DEBUG causes additional messages to be printed in the test functions.
  • Most Ansible modules log to a specific module-specific Python logger (using the LOGGER variable). These log entries do not show up in the TESTLOGFILE. Probably they would show up in the LOG_FILE.

This should be made more consistent so that TESTLOGFILE enables all logging.

In addition, there is no log entry that marks the begin and end of a testcase, so it is hard to associate the log entries in the file to testcases.

@andy-maier andy-maier changed the title Fix logging in end2end tests Make logging in end2end tests more consistent Jan 9, 2024
@andy-maier andy-maier added this to the 1.9.0 milestone Jan 13, 2024
@andy-maier andy-maier modified the milestones: 1.9.0, 1.10.0 Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant