Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Assetic #2685

Closed
Guite opened this issue Dec 17, 2015 · 5 comments
Closed

Drop Assetic #2685

Guite opened this issue Dec 17, 2015 · 5 comments
Milestone

Comments

@Guite
Copy link
Member

Guite commented Dec 17, 2015

Since we use zasset (which is built above the Symfony Asset component) we should remove Assetic from the core.

@Guite Guite added the Task label Dec 17, 2015
@Guite Guite added this to the 1.4.2 milestone Dec 17, 2015
@craigh
Copy link
Member

craigh commented Dec 17, 2015

since it is currently included since 1.4.0 we should perhaps schedule removal for 2.0.0?

@Guite
Copy link
Member Author

Guite commented Dec 17, 2015

Wouldn't this lead to more people starting using it? I think at the moment nobody is using Assetic (yet), so it could be advantageous getting rid of it before it becomes adopted?

@craigh
Copy link
Member

craigh commented Dec 17, 2015

yes, that would be a concern, but we have much tech in the Core that is @deprecated. We leave it for BC. Of course there is no way to know that "nobody is using it" (until we remove and someone complains 😉 ).

@Guite Guite modified the milestones: 2.0.0, 1.4.2 Dec 17, 2015
@Guite
Copy link
Member Author

Guite commented Dec 17, 2015

Postponed issue to 2.0.0.

@craigh
Copy link
Member

craigh commented Dec 17, 2015

here is a conversation about removing ascetic from symfony-standard (which is not the same as 'symfony', apparently). just FTR

@craigh craigh modified the milestones: 1.4.3, 2.0.0-beta1 Jul 20, 2016
@craigh craigh closed this as completed Jul 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants