-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
replace component installer #4558
Conversation
remove RequireJs config generator (ping @Kaik) remove forced use of composer 1 and allow composer 2 in travis build and github actions
Did you also consider https://github.com/fxpio/foxy ? (see "Alternatives" section at #4032 ...) |
yes, I looked into it. oomphinc/composer-installers-extender is a smaller change and easier for the moment. Foxy could be used later maybe. |
Hard to say now why RequireJs was required by component installer, or why it generated config for it. AFAIR it wasn't even configured properly. |
ah ok so, it was an alternative way to handle component js/css we used the simple way (we just hardcoded all assets). These were also "bundled" via requireJS. So instead of many hardcoded tags you use one tag the same everywhere and in your js code you can just call required "module" (JQuery etc...) and requireJS will provide it. |
Yes, requireJS is not needed. |
symlink jqueryui to jquery-ui for BC. refs #4558
replace component installer with oomphinc/composer-installers-extender
remove RequireJs config generator (ping @Kaik)
remove forced use of composer 1 and allow composer 2 in travis build and github actions