Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] IVF GetVectorByIds interface has concurrence problem #132

Closed
foxspy opened this issue Oct 7, 2023 · 2 comments
Closed

[BUG] IVF GetVectorByIds interface has concurrence problem #132

foxspy opened this issue Oct 7, 2023 · 2 comments

Comments

@foxspy
Copy link
Collaborator

foxspy commented Oct 7, 2023 •
edited
Loading

IVF index constructs the id->offset map during getvectors stage : https://github.com/zilliztech/knowhere/blob/main/src/index/ivf/ivf.cc#L580. This design will cause write/write concurrence when user calls the interface concurrently because the idmap is shared and not thread-safe.

related milvus issue: #milvus-io/milvus#27390
This was referenced Oct 7, 2023
Merged
Merged
@liliu-z
Copy link
Collaborator

liliu-z commented Oct 13, 2023

@elstic Fixed

@elstic
Copy link

elstic commented Oct 13, 2023

@elstic Fixed

Yes, it was fixed.
I'm not getting search failures on the milvus side of the continuous concurrency test

@elstic elstic closed this as completed Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@foxspy @elstic @liliu-z