Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GetVectorById for Faiss_HNSW #778

Closed
liliu-z opened this issue Aug 23, 2024 · 3 comments
Closed

Fix GetVectorById for Faiss_HNSW #778

liliu-z opened this issue Aug 23, 2024 · 3 comments
Assignees

Comments

@liliu-z
Copy link
Collaborator

liliu-z commented Aug 23, 2024

          `GetVectorById` need to return an error code if there is no raw data available (If the data type is FP16, then the raw data need to be FP16).

So we need a raw data existence check there.

Originally posted by @liliu-z in #746 (comment)

@liliu-z
Copy link
Collaborator Author

liliu-z commented Aug 23, 2024

/assign
/assign @alexanderguzhva

@alexanderguzhva
Copy link
Collaborator

@alexanderguzhva Isn't it handled by ::HasRawData() method?

@liliu-z
Copy link
Collaborator Author

liliu-z commented Aug 26, 2024

@alexanderguzhva Isn't it handled by ::HasRawData() method?

Good question. Sorry the API definition isn't clear. The assumption is that HasRawData & GetVectorById are two individual function, meaning ppl are allow to call GetVectorById without calling HasRawData before. Although we hope users to call them in order, there are no hard limit to guarantee this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants