Update RBRCIT command with V1.1.0 may lead to non working RBRCIT.EXE if the cmd is run before updating the carList.ini file (the prev version had empty rbrcit_url option value)

[mika-n]

Thx for the updated version of RBRCIT available (with a fix to 0/1 enableFMOD option bug and status of sndbanks).

However, the latest V1.1.1 version has one nasty bug. The previous carList.ini file had an empty string in rbrcit_url option. Now if users try to run "Update RBRCIT" command with the previous V1.1.0 version BEFORE they explicitly run "Update carList.ini" command they get an error about empty URL value. No big deal, but after that RBRCIT no longer worked at all.

For a few secs I was like whaat. Took a closer look at the code and I realized that RBRCIT DownloadRBRCIT method renames the existing RBRCIT.EXE file as RBRCIT.bak before checking the download URL validity. Therefore I no longer had RBRCIT.EXE file. Well, I renamed the RBRCIT.bak back to RBRCIT.EXE and run "Update carList.ini" command before doing the new "Update RBRCIT" command. This time it worked just fine.

Anyway. Maybe there should be "URL validity check" before the RBRCIT.EXE is renamed or showing a dialog proposing to run "Update carList.ini" cmd first. The thing between V1.1.0 and V1.1.1 is a "one time incident" if Update RBRCIT cmd is accidentaly run before updating carList.ini file. But, maybe something like this could happen in the future also where RBRCIT downloading fails for whatever reason, so RBRCIT.EXE should be renamed only when the new version has been successfully downloaded.

[zissakos]

thanks for the feedback!
Sounds good, I will definitely look into that!
Thanks!

[zissakos]

fixed in 1.2.0. Now RBRCIT will display a message about the missing url and point to updating carList.ini before doing the download&update.