Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use GitHub Actions for building the project #421

Closed
3 tasks done
jurica opened this issue Jun 4, 2024 · 4 comments · Fixed by #469 or zk-org/zk-xcompile#6
Closed
3 tasks done

Use GitHub Actions for building the project #421

jurica opened this issue Jun 4, 2024 · 4 comments · Fixed by #469 or zk-org/zk-xcompile#6
Assignees
Labels
enhancement New feature or request

Comments

@jurica
Copy link
Member

jurica commented Jun 4, 2024

See the discussion here: #405 (reply in thread)

It would be nice to use GitHub Actions for building and releasing zk.

Goals

  • build linux binaries on actions
  • build macOS binaries on actions
  • build Windows binaries on actions
@jurica jurica self-assigned this Jun 4, 2024
@tjex tjex added the enhancement New feature or request label Jun 8, 2024
@jurica
Copy link
Member Author

jurica commented Aug 8, 2024

Just a short update: I didn't forget about this, but apart from some research and local tests haven't done anything more yet. I think that during summer I unfortunately will not find a lot of spare time to spend for doing serious work here. But definitively want to tackle it once the evenings start getting longer and the weather starts getting worse. ;)

@tjex
Copy link
Member

tjex commented Aug 9, 2024

Not a prob. Thanks for the update.

@jurica
Copy link
Member Author

jurica commented Nov 22, 2024

Wohoo, I build the container images for building (linux) zk binaries and a set of binaries on actions.
I'll still need some time to clean up everything and sort out a few minor issues but at least I finally made some progress...

@jurica
Copy link
Member Author

jurica commented Nov 23, 2024

I filed two PRs (here and on the xcompile repo) that provides workflows for building the Docker build containers as well as binaries for linux, macOS and Windows.

Sample executions of the workflows can be found on my forks:

Looking forward for feedback!

@tjex tjex closed this as completed in #469 Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
2 participants