Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI For rejected transactions in the "History" tab #80

Closed
maikReal opened this issue Oct 21, 2022 · 7 comments
Closed

UI For rejected transactions in the "History" tab #80

maikReal opened this issue Oct 21, 2022 · 7 comments
Assignees
@EvgenKor
Labels
UI

Comments

@maikReal
Copy link

Relates to:
@maikReal maikReal changed the title UI For rejected transactions for History UI For rejected transactions in the "History" tab Oct 21, 2022
@maikReal
Copy link
Author

maikReal commented Nov 4, 2022

@tgladilina Increased priority to high

@maikReal
Copy link
Author

maikReal commented Nov 4, 2022

image

@tgladilina We also need to add a description for the error as a subtitle
@maxaleks Do we know the error when a tx was rejected?

@tgladilina
Copy link
Collaborator

@maikReal case has been added
@maxaleks need error text

https://www.figma.com/file/VgEAclPmc6tghBwaSfTWAn/zkBob-App?node-id=1969%3A21606

Image
Image

@tgladilina tgladilina assigned maxaleks and unassigned tgladilina Nov 8, 2022
@ulyanas
Copy link
Collaborator

ulyanas commented Nov 22, 2022

Estimate - 1d
Retry - separate feature - @maikReal

@r0wdy1
Copy link
Contributor

r0wdy1 commented Dec 5, 2022

It would also be useful to handle separately tx rejected by relayer and reverted at contract level.
At least it's not good to show polygonscan link to a tx, that didn't make it to the mempool. Right now it just shows a link like /tx/0

@maxaleks maxaleks assigned vadimnikonov1 and unassigned maxaleks Dec 22, 2022
@maxaleks maxaleks mentioned this issue Jan 2, 2023
Merged
@vadimnikonov1
Copy link

Is this the correct behaviour for the app?

Image

@vadimnikonov1
Copy link

Image

@r0wdy1 r0wdy1 assigned EvgenKor and unassigned maxaleks Jan 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@EvgenKor EvgenKor

Labels
UI
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@EvgenKor @ulyanas @maxaleks @maikReal @vadimnikonov1 @tgladilina @r0wdy1