Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch out atty for is-terminal #229

Merged
merged 3 commits into from
Mar 14, 2023
Merged

Switch out atty for is-terminal #229

merged 3 commits into from
Mar 14, 2023

Conversation

Porges
Copy link
Contributor

@Porges Porges commented Dec 20, 2022

Draft for now, switching out atty for is-terminal per #228

@matthiasbeyer
Copy link
Contributor

I stumbled across this due to a cargo-deny notification for atty on one of my crates... So let me ask: What's the status here? 😆

@zkat
Copy link
Owner

zkat commented Mar 10, 2023

I'll totally take a non-draft version of this PR (with concrete dep versions, yes)

@matthiasbeyer
Copy link
Contributor

Are you fine with the git dependencies?
If not, zkat/supports-unicode#4 and zkat/supports-hyperlinks#3 should probably be merged first and of course also released... 🤔

@zkat
Copy link
Owner

zkat commented Mar 13, 2023

right, those others will need to be merged first, thanks for the links. No git deps, please :)

@Porges Porges marked this pull request as ready for review March 13, 2023 21:17
@Porges Porges changed the title [Demo] Switch out atty for is-terminal Switch out atty for is-terminal Mar 13, 2023
@Porges
Copy link
Contributor Author

Porges commented Mar 13, 2023

Updated this PR to match updated versions of the zkat/supports-unicode#4 and zkat/supports-hyperlinks#3 PRs. Once those are merged this can change to point to the released crates.

@zkat
Copy link
Owner

zkat commented Mar 14, 2023

@Porges Just released supports-hyperlinks@2.0.0 and supports-unicode@2.0.0 with the is_terminal changes.

@Porges
Copy link
Contributor Author

Porges commented Mar 14, 2023

@zkat and updated to match 🙂

@zkat zkat merged commit 443d240 into zkat:main Mar 14, 2023
@zkat
Copy link
Owner

zkat commented Mar 14, 2023

This is released as part of miette@5.6.0 :)

@Porges
Copy link
Contributor Author

Porges commented Mar 14, 2023

@zkat thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants