feat(derive): enable more boxed types to be #[diagnostic_source] #338
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello again! Nice and small change this time :)
The
#[diagnostic_source]
attribute already worked forBox<dyn Diagnostic>
, but not for the highly-relatedBox<dyn Diagnostic + Send>
andBox<dyn Diagnostic + Send + Sync>
types!It looks like someone already solved this issue for
std::error:Error
with amacro_rules!
implementation, so I've done the same here to let those new cases compile! Without thoseBorrow<dyn Diagnostic>
impls, you end up with compiler errors coming from inside of the derive macro:Let me know if you have any questions! I'll separately try to sort out those failing tests (unrelated to this change) in another PR :)