New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation in impl PartialEq for $projective seems incorrect #96

Open

PlasmaPower opened this issue Sep 16, 2018 · 1 comment

PlasmaPower commented Sep 16, 2018

A comment in the impl says:

pairing/src/bls12_381/ec.rs

Lines 55 to 57 in 183a64b

    
           // The points (X, Y, Z) and (X', Y', Z') 
        
           // are equal when (X * Z^2) = (X' * Z'^2) 
        
           // and (Y * Z^3) = (Y' * Z'^3).

However, the impl seems to actually check this:

                // The points (X, Y, Z) and (X', Y', Z')
                // are equal when (X * Z'^2) = (X' * Z^2)
                // and (Y * Z'^3) = (Y' * Z^3).

I think the comment is wrong and the implementation is correct. Either way, this should be fixed.

burdges commented Sep 16, 2018

#93 fixes this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment