Fix broken getOwnPropertySymbols in Mobile Chrome 38 and 39 #539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a workaround for this chrome issue https://bugs.chromium.org/p/v8/issues/detail?id=3443 Without this fix, the object spread operator is broken for these versions of chrome when transpiling and shimming with babel and core-js@3. See babel/babel#8721
|
Could you also update |
zloirock
reviewed
Apr 26, 2019
packages/core-js/internals/object-get-own-property-symbols-external.js
Outdated
Show resolved
Hide resolved
switch toIndexedObject to toObject
|
Does this look good now? Do you want me to rebase it? |
|
Yep, LGTM. Only one (mainly stylistic) moment - I'd prefer to have only one export of |
zloirock
added a commit
that referenced
this pull request
May 10, 2019
zloirock
added a commit
that referenced
this pull request
May 18, 2019
This was referenced Sep 4, 2019
This was referenced Sep 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a workaround for this chrome issue
https://bugs.chromium.org/p/v8/issues/detail?id=3443
Without this fix, the object spread operator is broken for these
versions of chrome when transpiling and shimming with babel and
core-js@3.
See babel/babel#8721