diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md new file mode 100644 index 000000000..9607483f4 --- /dev/null +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -0,0 +1,26 @@ +# Description +Update maxmind api key. + +Fixes [DUNLOP-1234](google.com) + +# Changes +* Update maxmind api key + +# How Has This Been Tested? +* Dunlop compiles and starts up + +# Checklist: +Please complete the following qualitative checks and tick the checklists when complete. + +Standard qualitative check list + +- [ ] I have performed a self-review of my code +- [ ] I have tested my changes work locally +- [ ] I have made appropriate documentation changes +- [ ] I have a plan to monitor after merging + + +Sandboxes (select 1) + +- [ ] The changes do not affect sandboxes +- [ ] I have tested my changes work as expected in a sandbox \ No newline at end of file diff --git a/.github/workflows/ci-checklist.yml b/.github/workflows/ci-checklist.yml new file mode 100644 index 000000000..9c04e4437 --- /dev/null +++ b/.github/workflows/ci-checklist.yml @@ -0,0 +1,26 @@ +on: + pull_request: + types: [edited, opened, reopened, synchronize] + issue_comment: + +# cancel old edit events being processed +concurrency: + group: ${{ github.workflow }}-${{ github.ref }} + cancel-in-progress: true + +name: Checkmate +jobs: + validate-checklists: + runs-on: ubuntu-latest + steps: + - uses: actions/checkout@v3 + - name: Validate Checklists + uses: roryq/checkmate@master + with: + github_token: ${{ secrets.GITHUB_TOKEN }} + paths: | + docs/*.md: + - + - Strong Consistency + - Availability + - Partition Tolerance diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml new file mode 100644 index 000000000..6d1ca9e90 --- /dev/null +++ b/.github/workflows/ci.yaml @@ -0,0 +1,35 @@ +name: checkbox-test +on: + pull_request: + types: [edited, opened, reopened, synchronize] + branches: [master] + issue_comment: + types: + - edited + +concurrency: + group: ${{ github.workflow }}-${{ github.ref }} + cancel-in-progress: true + +jobs: + validate: + name: checkbox validation + runs-on: ubuntu-latest + steps: + - name: Get PR branch + uses: xt0rted/pull-request-comment-branch@v2 + id: comment-branch + - uses: actions/checkout@v3 + with: + ref: ${{ steps.comment-branch.outputs.head_ref }} + token: ${{ secrets.GITHUB_TOKEN }} + - name: Validate Checklists + uses: roryq/checkmate@master + with: + github_token: ${{ secrets.GITHUB_TOKEN }} + paths: | + v3/sql/*.sql: + - I have benchmarked the SQL changes +# - +# - Partition Tolerance + diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 07e1c5248..5f2b47a69 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -6,7 +6,7 @@ requests (PR), each of which contain a single lint or a small handful of lints, over a single large PR. This allows for better code review, faster turnaround times on comments and merging, as well as for contributors to learn from any requested changes in the initial round of review. We are happy to wait to cut -new a version of ZLint until a set of PRs have been approved and merged. +new a version of ZLint until a set of PRs have been approved and merged. to merge. Adding New Lints ---------------- diff --git a/docs/test.md b/docs/test.md new file mode 100644 index 000000000..c82257509 --- /dev/null +++ b/docs/test.md @@ -0,0 +1 @@ +first test file diff --git a/v3/sql/test.sql b/v3/sql/test.sql new file mode 100644 index 000000000..21d8fed91 --- /dev/null +++ b/v3/sql/test.sql @@ -0,0 +1 @@ +select * from driver; diff --git a/v3/util/gtld_map.go b/v3/util/gtld_map.go index 202248868..e1e90e751 100644 --- a/v3/util/gtld_map.go +++ b/v3/util/gtld_map.go @@ -5341,7 +5341,7 @@ var tldMap = map[string]GTLDPeriod{ "rmit": { GTLD: "rmit", DelegationDate: "2016-11-24", - RemovalDate: "", + RemovalDate: "2021-09-27", }, "ro": { GTLD: "ro",