From ab3db29c7021b478b339e9a442db48d37ea58cbe Mon Sep 17 00:00:00 2001 From: GitHub Date: Tue, 28 Sep 2021 01:29:27 +0000 Subject: [PATCH 01/38] util: gtld_map autopull updates for 2021-09-28T01:28:51 UTC --- v3/util/gtld_map.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/v3/util/gtld_map.go b/v3/util/gtld_map.go index 202248868..e1e90e751 100644 --- a/v3/util/gtld_map.go +++ b/v3/util/gtld_map.go @@ -5341,7 +5341,7 @@ var tldMap = map[string]GTLDPeriod{ "rmit": { GTLD: "rmit", DelegationDate: "2016-11-24", - RemovalDate: "", + RemovalDate: "2021-09-27", }, "ro": { GTLD: "ro", From b4482ed89c8692715793791d9bfd394068a57420 Mon Sep 17 00:00:00 2001 From: Stefano Chang Date: Sun, 12 May 2024 16:20:14 +0000 Subject: [PATCH 02/38] feat: test push --- .github/workflows/PULL_REQUEST_TEMPLATE.md | 20 +++++++++++++++ .github/workflows/ci.yaml | 29 ++++++++++++++++++++++ 2 files changed, 49 insertions(+) create mode 100644 .github/workflows/PULL_REQUEST_TEMPLATE.md create mode 100644 .github/workflows/ci.yaml diff --git a/.github/workflows/PULL_REQUEST_TEMPLATE.md b/.github/workflows/PULL_REQUEST_TEMPLATE.md new file mode 100644 index 000000000..b81b6d998 --- /dev/null +++ b/.github/workflows/PULL_REQUEST_TEMPLATE.md @@ -0,0 +1,20 @@ +# Description +Update maxmind api key. + +Fixes [DUNLOP-1234](google.com) + +# Changes +* Update maxmind api key + +# How Has This Been Tested? +* Dunlop compiles and starts up + +# Checklist: + + +- [ ] I have performed a self-review of my code + + +- [ ] The changes do not affect sandboxes +- [ ] I have tested my changes work as expected in a sandbox + diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml new file mode 100644 index 000000000..1b707be4d --- /dev/null +++ b/.github/workflows/ci.yaml @@ -0,0 +1,29 @@ +name: checkbox-test +on: + pull_request: + types: [edited, opened, reopened, synchronize] + branches: [main] + +jobs: + validate: + name: checkbox validation + runs-on: ubuntu-latest + steps: + - uses: actions/checkout@v3 + - name: Validate Checklists + uses: roryq/checkmate@master +# - name: Validate Checklists +# uses: roryq/checkmate@master +# with: +# github_token: ${{ secrets.GITHUB_TOKEN }} +# paths: | +# docs/**/*.md: +# - I have got the grammar police to proofread my changes. +# schema/migrations/*.sql: +# - There are no breaking changes in these migrations +# - I have notified X team of the new schema changes +# database/*.go: +# - +# - Strong Consistency +# - Availability +# - Partition Tolerance From 60c5038510ebb8d5237606c61ce8f67e56d9035a Mon Sep 17 00:00:00 2001 From: Stefano Chang Date: Sun, 12 May 2024 16:23:35 +0000 Subject: [PATCH 03/38] feat: changing stuff --- CONTRIBUTING.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 07e1c5248..de6969eef 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -7,6 +7,7 @@ over a single large PR. This allows for better code review, faster turnaround times on comments and merging, as well as for contributors to learn from any requested changes in the initial round of review. We are happy to wait to cut new a version of ZLint until a set of PRs have been approved and merged. +new line Adding New Lints ---------------- From d96721e37bbe844d1c3b0aabbf67e20ff5ed4c38 Mon Sep 17 00:00:00 2001 From: Stefano Chang Date: Sun, 12 May 2024 16:24:32 +0000 Subject: [PATCH 04/38] feat: refactor pull request template location --- .github/{workflows => }/PULL_REQUEST_TEMPLATE.md | 0 1 file changed, 0 insertions(+), 0 deletions(-) rename .github/{workflows => }/PULL_REQUEST_TEMPLATE.md (100%) diff --git a/.github/workflows/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md similarity index 100% rename from .github/workflows/PULL_REQUEST_TEMPLATE.md rename to .github/PULL_REQUEST_TEMPLATE.md From 17d24fa3067cd35db463e54b9207c0bf5967bba8 Mon Sep 17 00:00:00 2001 From: Stefano Chang Date: Sun, 12 May 2024 16:25:13 +0000 Subject: [PATCH 05/38] feat: made a change --- CONTRIBUTING.md | 1 - 1 file changed, 1 deletion(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index de6969eef..07e1c5248 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -7,7 +7,6 @@ over a single large PR. This allows for better code review, faster turnaround times on comments and merging, as well as for contributors to learn from any requested changes in the initial round of review. We are happy to wait to cut new a version of ZLint until a set of PRs have been approved and merged. -new line Adding New Lints ---------------- From 41ae4715bf64c64fe3462cca11059820aa317a90 Mon Sep 17 00:00:00 2001 From: Stefano Chang Date: Mon, 13 May 2024 03:28:56 +0000 Subject: [PATCH 06/38] fix: ci script to watch master branch --- .github/workflows/ci.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml index 1b707be4d..b7eaf889d 100644 --- a/.github/workflows/ci.yaml +++ b/.github/workflows/ci.yaml @@ -2,7 +2,7 @@ name: checkbox-test on: pull_request: types: [edited, opened, reopened, synchronize] - branches: [main] + branches: [master] jobs: validate: From 7749ab9387ffe915eaf5290b8c04866e2d94688f Mon Sep 17 00:00:00 2001 From: Stefano Chang Date: Mon, 13 May 2024 03:31:04 +0000 Subject: [PATCH 07/38] feat: demo pr --- CONTRIBUTING.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 07e1c5248..3f4e4b6e6 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -6,7 +6,7 @@ requests (PR), each of which contain a single lint or a small handful of lints, over a single large PR. This allows for better code review, faster turnaround times on comments and merging, as well as for contributors to learn from any requested changes in the initial round of review. We are happy to wait to cut -new a version of ZLint until a set of PRs have been approved and merged. +new a version of ZLint until a set of PRs have been approved and merged. To remove. Adding New Lints ---------------- From 6d986fc988d988a91bbbce78317d41323f6d2509 Mon Sep 17 00:00:00 2001 From: Stefano Chang Date: Mon, 13 May 2024 03:35:31 +0000 Subject: [PATCH 08/38] feat: add label to checkboxes --- .github/PULL_REQUEST_TEMPLATE.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index b81b6d998..5d52ff959 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -10,10 +10,11 @@ Fixes [DUNLOP-1234](google.com) * Dunlop compiles and starts up # Checklist: - +Standard qualitative check list - [ ] I have performed a self-review of my code +Sandboxes - [ ] The changes do not affect sandboxes - [ ] I have tested my changes work as expected in a sandbox From a43ce579dbf8345a6913c8394529ed288578e39d Mon Sep 17 00:00:00 2001 From: Stefano Chang Date: Mon, 13 May 2024 03:31:04 +0000 Subject: [PATCH 09/38] feat: demo pr --- CONTRIBUTING.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 07e1c5248..3f4e4b6e6 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -6,7 +6,7 @@ requests (PR), each of which contain a single lint or a small handful of lints, over a single large PR. This allows for better code review, faster turnaround times on comments and merging, as well as for contributors to learn from any requested changes in the initial round of review. We are happy to wait to cut -new a version of ZLint until a set of PRs have been approved and merged. +new a version of ZLint until a set of PRs have been approved and merged. To remove. Adding New Lints ---------------- From 5747fc958f4332cb36cc574fb02968677f97b570 Mon Sep 17 00:00:00 2001 From: Stefano Chang Date: Mon, 13 May 2024 03:35:31 +0000 Subject: [PATCH 10/38] feat: add label to checkboxes --- .github/PULL_REQUEST_TEMPLATE.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index b81b6d998..5d52ff959 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -10,10 +10,11 @@ Fixes [DUNLOP-1234](google.com) * Dunlop compiles and starts up # Checklist: - +Standard qualitative check list - [ ] I have performed a self-review of my code +Sandboxes - [ ] The changes do not affect sandboxes - [ ] I have tested my changes work as expected in a sandbox From ed1d92c1be6f55674f14170af50ba125df695ba3 Mon Sep 17 00:00:00 2001 From: Stefano Chang Date: Mon, 13 May 2024 03:36:51 +0000 Subject: [PATCH 11/38] feat: add more demo checkboxes --- .github/PULL_REQUEST_TEMPLATE.md | 6 +++++- CONTRIBUTING.md | 2 +- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 5d52ff959..303fc99a2 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -13,8 +13,12 @@ Fixes [DUNLOP-1234](google.com) Standard qualitative check list - [ ] I have performed a self-review of my code +- [ ] I have tested my changes work locally +- [ ] I have made appropriate documentation changes +- [ ] I have a plan to monitor after merging -Sandboxes + +Sandboxes (select 1) - [ ] The changes do not affect sandboxes - [ ] I have tested my changes work as expected in a sandbox diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 3f4e4b6e6..07e1c5248 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -6,7 +6,7 @@ requests (PR), each of which contain a single lint or a small handful of lints, over a single large PR. This allows for better code review, faster turnaround times on comments and merging, as well as for contributors to learn from any requested changes in the initial round of review. We are happy to wait to cut -new a version of ZLint until a set of PRs have been approved and merged. To remove. +new a version of ZLint until a set of PRs have been approved and merged. Adding New Lints ---------------- From 35b10064c24122a9d5cd55b434c5b8c4fd3224fd Mon Sep 17 00:00:00 2001 From: Stefano Chang Date: Mon, 13 May 2024 03:42:42 +0000 Subject: [PATCH 12/38] feat: demo pr --- CONTRIBUTING.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 3f4e4b6e6..07e1c5248 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -6,7 +6,7 @@ requests (PR), each of which contain a single lint or a small handful of lints, over a single large PR. This allows for better code review, faster turnaround times on comments and merging, as well as for contributors to learn from any requested changes in the initial round of review. We are happy to wait to cut -new a version of ZLint until a set of PRs have been approved and merged. To remove. +new a version of ZLint until a set of PRs have been approved and merged. Adding New Lints ---------------- From ae57a8e1e3f63e540dc95383b32b366a810f647d Mon Sep 17 00:00:00 2001 From: Stefano Chang Date: Mon, 13 May 2024 03:49:26 +0000 Subject: [PATCH 13/38] feat: add sql files --- .github/PULL_REQUEST_TEMPLATE.md | 3 +++ v3/sql/test.sql | 1 + 2 files changed, 4 insertions(+) create mode 100644 v3/sql/test.sql diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 303fc99a2..4c998a393 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -23,3 +23,6 @@ Sandboxes (select 1) - [ ] The changes do not affect sandboxes - [ ] I have tested my changes work as expected in a sandbox +SQL changes + +- [ ] I have benchmarked the SQL changes \ No newline at end of file diff --git a/v3/sql/test.sql b/v3/sql/test.sql new file mode 100644 index 000000000..565fb74d1 --- /dev/null +++ b/v3/sql/test.sql @@ -0,0 +1 @@ +select * from driver; \ No newline at end of file From ce65e5cb1fffe79303e0eeecf6b4dec6db7f2516 Mon Sep 17 00:00:00 2001 From: Stefano Chang Date: Mon, 13 May 2024 03:50:32 +0000 Subject: [PATCH 14/38] feat: demo pr --- CONTRIBUTING.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 07e1c5248..5f2b47a69 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -6,7 +6,7 @@ requests (PR), each of which contain a single lint or a small handful of lints, over a single large PR. This allows for better code review, faster turnaround times on comments and merging, as well as for contributors to learn from any requested changes in the initial round of review. We are happy to wait to cut -new a version of ZLint until a set of PRs have been approved and merged. +new a version of ZLint until a set of PRs have been approved and merged. to merge. Adding New Lints ---------------- From 51e3800af33d1679e60973c00fc05baef5c4b605 Mon Sep 17 00:00:00 2001 From: Stefano Chang Date: Mon, 13 May 2024 04:02:31 +0000 Subject: [PATCH 15/38] feat: merge --- .github/PULL_REQUEST_TEMPLATE.md | 8 +++----- .github/workflows/ci.yaml | 19 ++++++------------- 2 files changed, 9 insertions(+), 18 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 4c998a393..9607483f4 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -10,6 +10,8 @@ Fixes [DUNLOP-1234](google.com) * Dunlop compiles and starts up # Checklist: +Please complete the following qualitative checks and tick the checklists when complete. + Standard qualitative check list - [ ] I have performed a self-review of my code @@ -21,8 +23,4 @@ Standard qualitative check list Sandboxes (select 1) - [ ] The changes do not affect sandboxes -- [ ] I have tested my changes work as expected in a sandbox - -SQL changes - -- [ ] I have benchmarked the SQL changes \ No newline at end of file +- [ ] I have tested my changes work as expected in a sandbox \ No newline at end of file diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml index b7eaf889d..2a02a5d91 100644 --- a/.github/workflows/ci.yaml +++ b/.github/workflows/ci.yaml @@ -12,18 +12,11 @@ jobs: - uses: actions/checkout@v3 - name: Validate Checklists uses: roryq/checkmate@master -# - name: Validate Checklists -# uses: roryq/checkmate@master -# with: -# github_token: ${{ secrets.GITHUB_TOKEN }} -# paths: | -# docs/**/*.md: -# - I have got the grammar police to proofread my changes. -# schema/migrations/*.sql: -# - There are no breaking changes in these migrations -# - I have notified X team of the new schema changes -# database/*.go: + with: + github_token: ${{ secrets.GITHUB_TOKEN }} + paths: | + v3/sql/*.sql: + - I have benchmarked the SQL changes # - -# - Strong Consistency -# - Availability # - Partition Tolerance + From 2a1a62f0b39e5622a8052bc9ba93edcf38009e4d Mon Sep 17 00:00:00 2001 From: Stefano Chang Date: Mon, 13 May 2024 03:50:32 +0000 Subject: [PATCH 16/38] feat: demo pr --- CONTRIBUTING.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 07e1c5248..5f2b47a69 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -6,7 +6,7 @@ requests (PR), each of which contain a single lint or a small handful of lints, over a single large PR. This allows for better code review, faster turnaround times on comments and merging, as well as for contributors to learn from any requested changes in the initial round of review. We are happy to wait to cut -new a version of ZLint until a set of PRs have been approved and merged. +new a version of ZLint until a set of PRs have been approved and merged. to merge. Adding New Lints ---------------- From 3705cb65a538105d33fe2b0d2ab7bb1087bea86c Mon Sep 17 00:00:00 2001 From: Stefano Chang Date: Mon, 13 May 2024 04:02:31 +0000 Subject: [PATCH 17/38] feat: merge --- .github/PULL_REQUEST_TEMPLATE.md | 8 +++----- .github/workflows/ci.yaml | 19 ++++++------------- 2 files changed, 9 insertions(+), 18 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 4c998a393..9607483f4 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -10,6 +10,8 @@ Fixes [DUNLOP-1234](google.com) * Dunlop compiles and starts up # Checklist: +Please complete the following qualitative checks and tick the checklists when complete. + Standard qualitative check list - [ ] I have performed a self-review of my code @@ -21,8 +23,4 @@ Standard qualitative check list Sandboxes (select 1) - [ ] The changes do not affect sandboxes -- [ ] I have tested my changes work as expected in a sandbox - -SQL changes - -- [ ] I have benchmarked the SQL changes \ No newline at end of file +- [ ] I have tested my changes work as expected in a sandbox \ No newline at end of file diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml index b7eaf889d..2a02a5d91 100644 --- a/.github/workflows/ci.yaml +++ b/.github/workflows/ci.yaml @@ -12,18 +12,11 @@ jobs: - uses: actions/checkout@v3 - name: Validate Checklists uses: roryq/checkmate@master -# - name: Validate Checklists -# uses: roryq/checkmate@master -# with: -# github_token: ${{ secrets.GITHUB_TOKEN }} -# paths: | -# docs/**/*.md: -# - I have got the grammar police to proofread my changes. -# schema/migrations/*.sql: -# - There are no breaking changes in these migrations -# - I have notified X team of the new schema changes -# database/*.go: + with: + github_token: ${{ secrets.GITHUB_TOKEN }} + paths: | + v3/sql/*.sql: + - I have benchmarked the SQL changes # - -# - Strong Consistency -# - Availability # - Partition Tolerance + From 17d826d66d4d1b3dad06a5565f97a449f3c9317c Mon Sep 17 00:00:00 2001 From: Stefano Chang Date: Mon, 13 May 2024 04:03:40 +0000 Subject: [PATCH 18/38] feat: dmeo pr --- CONTRIBUTING.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 5f2b47a69..07e1c5248 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -6,7 +6,7 @@ requests (PR), each of which contain a single lint or a small handful of lints, over a single large PR. This allows for better code review, faster turnaround times on comments and merging, as well as for contributors to learn from any requested changes in the initial round of review. We are happy to wait to cut -new a version of ZLint until a set of PRs have been approved and merged. to merge. +new a version of ZLint until a set of PRs have been approved and merged. Adding New Lints ---------------- From 93bccccaa25067e06ee2d797ba4bb0f35b6ab615 Mon Sep 17 00:00:00 2001 From: Stefano Chang Date: Mon, 13 May 2024 04:16:03 +0000 Subject: [PATCH 19/38] feat: demo sql changes --- v3/sql/test.sql | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/v3/sql/test.sql b/v3/sql/test.sql index 565fb74d1..5edfe50ef 100644 --- a/v3/sql/test.sql +++ b/v3/sql/test.sql @@ -1 +1 @@ -select * from driver; \ No newline at end of file +select * from driver limit 100; From 53cfea742f1f23e46ca8cb9a9ce281965f29688c Mon Sep 17 00:00:00 2001 From: Stefano Chang Date: Mon, 13 May 2024 04:21:17 +0000 Subject: [PATCH 20/38] feat: add edit comment tigger --- .github/workflows/ci.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml index 2a02a5d91..1ced1cf19 100644 --- a/.github/workflows/ci.yaml +++ b/.github/workflows/ci.yaml @@ -3,6 +3,7 @@ on: pull_request: types: [edited, opened, reopened, synchronize] branches: [master] + issue_comment: jobs: validate: From 7787c102911743e7cd1c81224c97022bc33480e8 Mon Sep 17 00:00:00 2001 From: Stefano Chang Date: Sun, 12 May 2024 16:23:35 +0000 Subject: [PATCH 21/38] feat: changing stuff --- CONTRIBUTING.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 07e1c5248..de6969eef 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -7,6 +7,7 @@ over a single large PR. This allows for better code review, faster turnaround times on comments and merging, as well as for contributors to learn from any requested changes in the initial round of review. We are happy to wait to cut new a version of ZLint until a set of PRs have been approved and merged. +new line Adding New Lints ---------------- From b5c927da7bf76b12dda0ed757e7b82936fc6a8a8 Mon Sep 17 00:00:00 2001 From: Stefano Chang Date: Sun, 12 May 2024 16:24:32 +0000 Subject: [PATCH 22/38] feat: refactor pull request template location --- .github/{workflows => }/PULL_REQUEST_TEMPLATE.md | 0 1 file changed, 0 insertions(+), 0 deletions(-) rename .github/{workflows => }/PULL_REQUEST_TEMPLATE.md (100%) diff --git a/.github/workflows/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md similarity index 100% rename from .github/workflows/PULL_REQUEST_TEMPLATE.md rename to .github/PULL_REQUEST_TEMPLATE.md From 0c7e9358c38ff00c7b13f3d24813e4549b81b911 Mon Sep 17 00:00:00 2001 From: Stefano Chang Date: Sun, 12 May 2024 16:25:13 +0000 Subject: [PATCH 23/38] feat: made a change --- CONTRIBUTING.md | 1 - 1 file changed, 1 deletion(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index de6969eef..07e1c5248 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -7,7 +7,6 @@ over a single large PR. This allows for better code review, faster turnaround times on comments and merging, as well as for contributors to learn from any requested changes in the initial round of review. We are happy to wait to cut new a version of ZLint until a set of PRs have been approved and merged. -new line Adding New Lints ---------------- From 6c4bc8f874a19da0ecd68643c1c7ed6063a84596 Mon Sep 17 00:00:00 2001 From: Stefano Chang Date: Mon, 13 May 2024 03:28:56 +0000 Subject: [PATCH 24/38] fix: ci script to watch master branch --- .github/workflows/ci.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml index 1b707be4d..b7eaf889d 100644 --- a/.github/workflows/ci.yaml +++ b/.github/workflows/ci.yaml @@ -2,7 +2,7 @@ name: checkbox-test on: pull_request: types: [edited, opened, reopened, synchronize] - branches: [main] + branches: [master] jobs: validate: From 68d0448991da21206c5297d946a36140206b1658 Mon Sep 17 00:00:00 2001 From: Stefano Chang Date: Mon, 13 May 2024 03:31:04 +0000 Subject: [PATCH 25/38] feat: demo pr --- CONTRIBUTING.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 07e1c5248..3f4e4b6e6 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -6,7 +6,7 @@ requests (PR), each of which contain a single lint or a small handful of lints, over a single large PR. This allows for better code review, faster turnaround times on comments and merging, as well as for contributors to learn from any requested changes in the initial round of review. We are happy to wait to cut -new a version of ZLint until a set of PRs have been approved and merged. +new a version of ZLint until a set of PRs have been approved and merged. To remove. Adding New Lints ---------------- From d87bdc34eb88bffc5a2d4ca0a942658b380305df Mon Sep 17 00:00:00 2001 From: Stefano Chang Date: Mon, 13 May 2024 03:35:31 +0000 Subject: [PATCH 26/38] feat: add label to checkboxes --- .github/PULL_REQUEST_TEMPLATE.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index b81b6d998..5d52ff959 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -10,10 +10,11 @@ Fixes [DUNLOP-1234](google.com) * Dunlop compiles and starts up # Checklist: - +Standard qualitative check list - [ ] I have performed a self-review of my code +Sandboxes - [ ] The changes do not affect sandboxes - [ ] I have tested my changes work as expected in a sandbox From ecb1ab54569ab167f24d87b22f1d7c614d136172 Mon Sep 17 00:00:00 2001 From: Stefano Chang Date: Mon, 13 May 2024 03:36:51 +0000 Subject: [PATCH 27/38] feat: add more demo checkboxes --- .github/PULL_REQUEST_TEMPLATE.md | 6 +++++- CONTRIBUTING.md | 2 +- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 5d52ff959..303fc99a2 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -13,8 +13,12 @@ Fixes [DUNLOP-1234](google.com) Standard qualitative check list - [ ] I have performed a self-review of my code +- [ ] I have tested my changes work locally +- [ ] I have made appropriate documentation changes +- [ ] I have a plan to monitor after merging -Sandboxes + +Sandboxes (select 1) - [ ] The changes do not affect sandboxes - [ ] I have tested my changes work as expected in a sandbox diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 3f4e4b6e6..07e1c5248 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -6,7 +6,7 @@ requests (PR), each of which contain a single lint or a small handful of lints, over a single large PR. This allows for better code review, faster turnaround times on comments and merging, as well as for contributors to learn from any requested changes in the initial round of review. We are happy to wait to cut -new a version of ZLint until a set of PRs have been approved and merged. To remove. +new a version of ZLint until a set of PRs have been approved and merged. Adding New Lints ---------------- From e37fbbac6140cfdb959e8eb74ebda8a2ae1f00ff Mon Sep 17 00:00:00 2001 From: Stefano Chang Date: Mon, 13 May 2024 03:31:04 +0000 Subject: [PATCH 28/38] feat: demo pr --- CONTRIBUTING.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 07e1c5248..3f4e4b6e6 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -6,7 +6,7 @@ requests (PR), each of which contain a single lint or a small handful of lints, over a single large PR. This allows for better code review, faster turnaround times on comments and merging, as well as for contributors to learn from any requested changes in the initial round of review. We are happy to wait to cut -new a version of ZLint until a set of PRs have been approved and merged. +new a version of ZLint until a set of PRs have been approved and merged. To remove. Adding New Lints ---------------- From 7ff289f83d7337b6058438e96a8ea67287f73f45 Mon Sep 17 00:00:00 2001 From: Stefano Chang Date: Mon, 13 May 2024 03:42:42 +0000 Subject: [PATCH 29/38] feat: demo pr --- CONTRIBUTING.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 3f4e4b6e6..07e1c5248 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -6,7 +6,7 @@ requests (PR), each of which contain a single lint or a small handful of lints, over a single large PR. This allows for better code review, faster turnaround times on comments and merging, as well as for contributors to learn from any requested changes in the initial round of review. We are happy to wait to cut -new a version of ZLint until a set of PRs have been approved and merged. To remove. +new a version of ZLint until a set of PRs have been approved and merged. Adding New Lints ---------------- From 1cd363391a33ccf2a469235086cd04c566f1f562 Mon Sep 17 00:00:00 2001 From: Stefano Chang Date: Mon, 13 May 2024 03:49:26 +0000 Subject: [PATCH 30/38] feat: add sql files --- .github/PULL_REQUEST_TEMPLATE.md | 3 +++ v3/sql/test.sql | 1 + 2 files changed, 4 insertions(+) create mode 100644 v3/sql/test.sql diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 303fc99a2..4c998a393 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -23,3 +23,6 @@ Sandboxes (select 1) - [ ] The changes do not affect sandboxes - [ ] I have tested my changes work as expected in a sandbox +SQL changes + +- [ ] I have benchmarked the SQL changes \ No newline at end of file diff --git a/v3/sql/test.sql b/v3/sql/test.sql new file mode 100644 index 000000000..565fb74d1 --- /dev/null +++ b/v3/sql/test.sql @@ -0,0 +1 @@ +select * from driver; \ No newline at end of file From a1a6cbf025478d3f2d55332f210f40373b7d622d Mon Sep 17 00:00:00 2001 From: Stefano Chang Date: Mon, 13 May 2024 03:50:32 +0000 Subject: [PATCH 31/38] feat: demo pr --- CONTRIBUTING.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 07e1c5248..5f2b47a69 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -6,7 +6,7 @@ requests (PR), each of which contain a single lint or a small handful of lints, over a single large PR. This allows for better code review, faster turnaround times on comments and merging, as well as for contributors to learn from any requested changes in the initial round of review. We are happy to wait to cut -new a version of ZLint until a set of PRs have been approved and merged. +new a version of ZLint until a set of PRs have been approved and merged. to merge. Adding New Lints ---------------- From d1771de6646426d6249fab622c2d951b79ba99f7 Mon Sep 17 00:00:00 2001 From: Stefano Chang Date: Mon, 13 May 2024 04:02:31 +0000 Subject: [PATCH 32/38] feat: merge --- .github/PULL_REQUEST_TEMPLATE.md | 8 +++----- .github/workflows/ci.yaml | 19 ++++++------------- 2 files changed, 9 insertions(+), 18 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 4c998a393..9607483f4 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -10,6 +10,8 @@ Fixes [DUNLOP-1234](google.com) * Dunlop compiles and starts up # Checklist: +Please complete the following qualitative checks and tick the checklists when complete. + Standard qualitative check list - [ ] I have performed a self-review of my code @@ -21,8 +23,4 @@ Standard qualitative check list Sandboxes (select 1) - [ ] The changes do not affect sandboxes -- [ ] I have tested my changes work as expected in a sandbox - -SQL changes - -- [ ] I have benchmarked the SQL changes \ No newline at end of file +- [ ] I have tested my changes work as expected in a sandbox \ No newline at end of file diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml index b7eaf889d..2a02a5d91 100644 --- a/.github/workflows/ci.yaml +++ b/.github/workflows/ci.yaml @@ -12,18 +12,11 @@ jobs: - uses: actions/checkout@v3 - name: Validate Checklists uses: roryq/checkmate@master -# - name: Validate Checklists -# uses: roryq/checkmate@master -# with: -# github_token: ${{ secrets.GITHUB_TOKEN }} -# paths: | -# docs/**/*.md: -# - I have got the grammar police to proofread my changes. -# schema/migrations/*.sql: -# - There are no breaking changes in these migrations -# - I have notified X team of the new schema changes -# database/*.go: + with: + github_token: ${{ secrets.GITHUB_TOKEN }} + paths: | + v3/sql/*.sql: + - I have benchmarked the SQL changes # - -# - Strong Consistency -# - Availability # - Partition Tolerance + From ed95a3929b0b0de1b84e066789eb9768fc677eed Mon Sep 17 00:00:00 2001 From: Stefano Chang Date: Mon, 13 May 2024 04:03:40 +0000 Subject: [PATCH 33/38] feat: dmeo pr --- CONTRIBUTING.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 5f2b47a69..07e1c5248 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -6,7 +6,7 @@ requests (PR), each of which contain a single lint or a small handful of lints, over a single large PR. This allows for better code review, faster turnaround times on comments and merging, as well as for contributors to learn from any requested changes in the initial round of review. We are happy to wait to cut -new a version of ZLint until a set of PRs have been approved and merged. to merge. +new a version of ZLint until a set of PRs have been approved and merged. Adding New Lints ---------------- From 86ffaebd205251289474b584a70b5eb3df10172a Mon Sep 17 00:00:00 2001 From: Stefano Chang Date: Mon, 13 May 2024 04:16:03 +0000 Subject: [PATCH 34/38] feat: demo sql changes --- v3/sql/test.sql | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/v3/sql/test.sql b/v3/sql/test.sql index 565fb74d1..5edfe50ef 100644 --- a/v3/sql/test.sql +++ b/v3/sql/test.sql @@ -1 +1 @@ -select * from driver; \ No newline at end of file +select * from driver limit 100; From 5d69aee4e6982f12cc607b5570036686ed57b49f Mon Sep 17 00:00:00 2001 From: Stefano Chang Date: Mon, 13 May 2024 04:21:17 +0000 Subject: [PATCH 35/38] feat: add edit comment tigger --- .github/workflows/ci.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml index 2a02a5d91..1ced1cf19 100644 --- a/.github/workflows/ci.yaml +++ b/.github/workflows/ci.yaml @@ -3,6 +3,7 @@ on: pull_request: types: [edited, opened, reopened, synchronize] branches: [master] + issue_comment: jobs: validate: From f036f016f6c13cbefe61f0a7828ec08474aa2f81 Mon Sep 17 00:00:00 2001 From: Stefano Chang Date: Mon, 13 May 2024 04:31:25 +0000 Subject: [PATCH 36/38] feat: demo pr --- .github/workflows/ci.yaml | 12 ++++++++++++ v3/sql/test.sql | 2 +- 2 files changed, 13 insertions(+), 1 deletion(-) diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml index 1ced1cf19..6d1ca9e90 100644 --- a/.github/workflows/ci.yaml +++ b/.github/workflows/ci.yaml @@ -4,13 +4,25 @@ on: types: [edited, opened, reopened, synchronize] branches: [master] issue_comment: + types: + - edited + +concurrency: + group: ${{ github.workflow }}-${{ github.ref }} + cancel-in-progress: true jobs: validate: name: checkbox validation runs-on: ubuntu-latest steps: + - name: Get PR branch + uses: xt0rted/pull-request-comment-branch@v2 + id: comment-branch - uses: actions/checkout@v3 + with: + ref: ${{ steps.comment-branch.outputs.head_ref }} + token: ${{ secrets.GITHUB_TOKEN }} - name: Validate Checklists uses: roryq/checkmate@master with: diff --git a/v3/sql/test.sql b/v3/sql/test.sql index 5edfe50ef..21d8fed91 100644 --- a/v3/sql/test.sql +++ b/v3/sql/test.sql @@ -1 +1 @@ -select * from driver limit 100; +select * from driver; From ea5e820374252276bc305b4fc212aa3c04bb0d30 Mon Sep 17 00:00:00 2001 From: Stefano Chang Date: Fri, 16 Aug 2024 06:12:14 +0000 Subject: [PATCH 37/38] feat: add checkbox wf --- .github/workflows/ci-checklist.yml | 26 ++++++++++++++++++++++++++ 1 file changed, 26 insertions(+) create mode 100644 .github/workflows/ci-checklist.yml diff --git a/.github/workflows/ci-checklist.yml b/.github/workflows/ci-checklist.yml new file mode 100644 index 000000000..9c04e4437 --- /dev/null +++ b/.github/workflows/ci-checklist.yml @@ -0,0 +1,26 @@ +on: + pull_request: + types: [edited, opened, reopened, synchronize] + issue_comment: + +# cancel old edit events being processed +concurrency: + group: ${{ github.workflow }}-${{ github.ref }} + cancel-in-progress: true + +name: Checkmate +jobs: + validate-checklists: + runs-on: ubuntu-latest + steps: + - uses: actions/checkout@v3 + - name: Validate Checklists + uses: roryq/checkmate@master + with: + github_token: ${{ secrets.GITHUB_TOKEN }} + paths: | + docs/*.md: + - + - Strong Consistency + - Availability + - Partition Tolerance From 7cb29d166f7515dd33b5d4f5b3e9a79af7b94f73 Mon Sep 17 00:00:00 2001 From: Stefano Chang Date: Fri, 16 Aug 2024 06:13:20 +0000 Subject: [PATCH 38/38] feat: add doc to test checkbox --- docs/test.md | 1 + 1 file changed, 1 insertion(+) create mode 100644 docs/test.md diff --git a/docs/test.md b/docs/test.md new file mode 100644 index 000000000..c82257509 --- /dev/null +++ b/docs/test.md @@ -0,0 +1 @@ +first test file