Triangulate Example Commands #1357
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Abstract out the common logic in backward-compatibility-check command
…ommand which can let us run the check on a specific folder or file in a repository
…ince the logic is reusable.
…ompatibilityCheckCommand
Add deprecation notice to all the b/w compatibility related commands which will be eventually removed
…l bring the repository back to the original state if the command is aborted in between
…d unnecessary logs in the backward compatibility check result logs
…le override in sub-classes of BackwardCompatibilityCheckBaseCommand
…patibility-check command
- This class will be used in example generation and parity with other protocol impls.
- New Abstract Classes for Examples Command. - Common Interface for example generation. - Moved InteractiveServer to application. - Move example template to JunitSupport. - Other HTML, CSS, JS Fixes.
- never show validation alert when testing. - fix main tag size and example name break.
- Use multi-level inheritance with interfaces. - Introduced a common base command with shared functions and cmd line options. - UI, UX fixes on frontend, etc.
- Use composition / delegation inplace of multi- inheritance. - Update dictionary usage in example_parity. - Fix errors caused by main merge.
- Reuse tests from `ExamplesCommandTest` and `ExamplesInteractiveServerTest`. - Fix typo in ExampleValidationResult. - add few other tests.
- Don't print dictionary in use, already printed by loadDictionary method.
- update descriptions so they're similar across protocols / implementations. - move `extensive` argument to ExamplesBase.kt
- Use Feature.createContractTestFromExampleFile in example testing.
- Add tests for inline examples validation.
- Use Result instead of TestResult, add result report in-case of test Failure. - [WIP] modifications to Feature test function createContractTestFromExampleFile. - Don't use ExactValue Pattern for response.
- use consoleLog and consoleDebug from log package - use restrictive access modifiers when possible. - add consoleDebug to log package.
- Code cleanup, moved thymeleaf to core completely, junit calls to core for html report - Move examples Dataclasses to core. - Remove unneeded Ktor deps from application.
- Clean up code - minor fixes
- Move validation result logging into class for reusability. - Other CSS and JS Fixes.
- load externalised example after parsing contract file to feature in OpenApiExamplesFeatureStrategy - Add test to ensure canonicalPath is used when matching example File to examples in scenario. - update test for example creation in Feature.
StarKhan6368
force-pushed
the
example_parity
branch
from
badea42 to
3b229f1
Compare
- minor refactors to ExamplesInteractiveServer
- [WIP] Example generation no longer checks for existing examples in interactive server. - Modifications to tableRow Generation, pre-calculate rowSpans for table rows.
- Rewrite Interactive JS to support multi example - Refactor to template and CSS styling - Generate Button needs to be moved - [WIP] Generate Button needs to be moved
- Generate More Button should appear on last group column of the row. - use viewTransitions if available, fallback to requestAnimationFrame for smooth layout shifts. - Minor refactorings.
- ExamplesInteractiveServer should send the URL with http prefix, - POST requests being made to render HTML should also include protocol prefix with host and port. - Include iframe in core/resources to test server with a post request mimicking TMF and codespace
- Use a global counter to append a unique number to dile name. - Fix - OpenApi Interactive tableRow creation for cases with same path method and status but differing content-type. - Remove dropdown in drill-downs and chevron-down icon. - Modify updateSpans to take extraInfo into account. - Other CSS and JS fixes.
- Rename `atomicCounter` to `exampleFileNamePostfixCounter` to convey its functionality. - Update Example Generate tests to expect integer postfix on filenames. - Update OpenApiExamplesInteractiveTest to do the same and multiple example generations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: Triangulate Example Commands across protocols / implementations.
How: Created Abstract classes for example generation, validation, and interactive server, which can then be reused across protocols for implementing examples commands.
Additional Features:
Checklist:
Note: This branch was created from the triangulate_bcc_commands.