Fixed status code 1 issue with backward compatibility #1459
+4
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harikrishnan83
requested changes
Dec 13, 2024
| @@ -92,7 +92,10 @@ abstract class BackwardCompatibilityCheckBaseCommand : Callable<Unit> { | |||
| ).filter { | |||
| File(it).exists() && File(it).isValidSpec() | |||
| }.toSet().also { | |||
| if(it.isEmpty()) exitWithMessage("No specs were changed, skipping the check.") | |||
| it.takeIf { it.isEmpty() }?.run { | |||
There was a problem hiding this comment.
Just curious, why do we have to switch to takeIf? Can we not make the if(it.isEmpty()) condition body a block body and just put the logger line and exitProcess with 0?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed status code 1 issue while running backward compatibility check when no spec files change is found