Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify the command line and GUI for the interactive server #1471

Merged
merged 5 commits into from
Dec 13, 2024

Conversation

StarKhan6368
Copy link
Collaborator

@StarKhan6368 StarKhan6368 commented Dec 12, 2024

What: Unify the command line and GUI for the interactive server

Why:

How:

Checklist:

- Unify path for GUI and command-line validations.
- Modify example reading in SchemaExample and ExampleFromFile to use
  return values that can be handled cleanly.
- Use a common function that does the generation.
- Add allowOnlyMandatoryKeysInJSONObject to CMD for parity with GUI.
- Update test setups.
# Conflicts:
#	application/src/test/kotlin/io/specmatic/core/examples/server/ExamplesInteractiveServerTest.kt
#	core/src/main/kotlin/io/specmatic/core/examples/server/ExamplesInteractiveServer.kt
#	core/src/main/kotlin/io/specmatic/core/examples/server/ExamplesView.kt
#	core/src/main/kotlin/io/specmatic/core/examples/server/SchemaExample.kt
@joelrosario joelrosario merged commit d745f64 into main Dec 13, 2024
2 checks passed
@joelrosario joelrosario deleted the int-ser-clnup branch December 13, 2024 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants