Add Take function in the migration package. #97
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the
pool.go
definesTake
as the primary way to take a connection.Ideally if the migrations package can follow the same interface, it would be easy for interoperability.
But migrations package does not provide
Take
, instead it providesGet(ctx) (conn, error)
(which is different from theGet(ctx) conn
in pool.go)Changing the signature of
Get
would be a breaking change, but addingTake
would instead atleast make a interoperable interface.