Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Take function in the migration package. #97

Merged
merged 5 commits into from
May 4, 2024

Conversation

blmhemu
Copy link
Contributor

@blmhemu blmhemu commented Apr 27, 2024

Currently, the pool.go defines Take as the primary way to take a connection.
Ideally if the migrations package can follow the same interface, it would be easy for interoperability.

But migrations package does not provide Take, instead it provides Get(ctx) (conn, error) (which is different from the Get(ctx) conn in pool.go)

Changing the signature of Get would be a breaking change, but adding Take would instead atleast make a interoperable interface.

@zombiezen zombiezen enabled auto-merge (squash) May 4, 2024 18:14
@zombiezen
Copy link
Owner

SGTM. Thanks!

@zombiezen zombiezen disabled auto-merge May 4, 2024 18:16
@zombiezen zombiezen enabled auto-merge (squash) May 4, 2024 18:16
@zombiezen zombiezen merged commit 990af03 into zombiezen:main May 4, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants