react-native-edge-to-edge #28
Conversation
|
For me it would be perfect to get following metadata (from Android/C++):
or reliable Ofc I can do it by myself, but Im also facing a lot of edge cases. So single API for all would be the best! |
android/src/main/java/com/zoontek/rnedgetoedge/RNEdgeToEdgeModuleImpl.kt
Outdated
Show resolved
Hide resolved
| <item name="android:windowTranslucentStatus">true</item> | ||
| <item name="android:windowTranslucentNavigation">true</item> | ||
| <style name="Theme.EdgeToEdge" parent="Theme.EdgeToEdge.Common"> | ||
| <item name="android:navigationBarColor">@color/systemBarDarkScrim</item> |
There was a problem hiding this comment.
I would like to suggest adding a variant with Theme.AppCompat.Light.NoActionBar theme, as not all applications that have to be created are designed to support dark theme and dynamic switching.
There was a problem hiding this comment.
Something like this
Theme.EdgeToEdge - default (current implementation)
Theme.EdgeToEdge.Light - will be using Theme.AppCompat.Light.NoActionBar theme under the hood
android/src/main/java/com/zoontek/rnedgetoedge/RNEdgeToEdgeModuleImpl.kt
Outdated
Show resolved
Hide resolved
| @@ -39,8 +41,8 @@ android { | |||
| } | |||
| defaultConfig { | |||
| buildConfigField("boolean", "IS_NEW_ARCHITECTURE_ENABLED", isNewArchitectureEnabled().toString()) | |||
| minSdkVersion safeExtGet("minSdkVersion", 21) | |||
| targetSdkVersion safeExtGet("targetSdkVersion", 33) | |||
| minSdkVersion safeExtGet("minSdkVersion", 23) | |||
There was a problem hiding this comment.
Heads up, 0.76 will have a minSdkVersion of 24
There was a problem hiding this comment.
@alanjhughes This library is compatible with RN 0.73+, that's why I keep minSdkVersion to 23 for now.
No description provided.