Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Windows Support #137

Closed
namrog84 opened this issue Mar 31, 2021 · 1 comment
Closed

Add Windows Support #137

namrog84 opened this issue Mar 31, 2021 · 1 comment
Labels
feature request New feature or request

Comments

@namrog84
Copy link
Contributor

namrog84 commented Mar 31, 2021

Feature request

Add windows support

Why it is needed

Because many React-Native modules are now supporting Windows.
https://github.com/microsoft/react-native-windows

Many projects (including where I work) use react-native-localize in cross-platform apps. And windows is 1 of those platforms. We have been using a private RNL implementation for windows for last 1+ year.

Code sample

I will have a PR out soon adding full windows implementation.

Example of example app working. It still needs some minor changes before I put out an actual PR.
https://i.imgur.com/ywMNfp2.png

Note: Not ready yet, but if anyone is interested until I release actual PR.
https://github.com/namrog84/react-native-localize/commits/master

@zoontek
Copy link
Owner

zoontek commented May 22, 2021

Thanks, I just published the 2.1.0 with it: https://github.com/zoontek/react-native-localize/releases/tag/2.1.0 (poke @crutchcorn)

@zoontek zoontek closed this as completed May 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants